Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753510AbXK0Gj1 (ORCPT ); Tue, 27 Nov 2007 01:39:27 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751053AbXK0GjQ (ORCPT ); Tue, 27 Nov 2007 01:39:16 -0500 Received: from rhun.apana.org.au ([64.62.148.172]:4135 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750730AbXK0GjQ (ORCPT ); Tue, 27 Nov 2007 01:39:16 -0500 Date: Tue, 27 Nov 2007 14:38:59 +0800 From: Herbert Xu To: Joonwoo Park Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, tristan_schmelcher@alumni.uwaterloo.ca, acme@ghostprotocols.net Subject: Re: [PATCH] [NET]: Fix TX bug VLAN in VLAN Message-ID: <20071127063859.GB2942@gondor.apana.org.au> References: <003f01c82dca$305acd40$9c94fea9@jason> <20071126112631.GA26599@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 922 Lines: 26 On Tue, Nov 27, 2007 at 02:32:49PM +0900, Joonwoo Park wrote: > > Thanks Herbert. > Well.. I think patch would work propely for AF_PACKET also. > (I did not insert BUG() macro in my patch) > How do you think? Are you sure? I thought you need to check both in the xmit function. That is, if (veth->h_vlan_proto != htons(ETH_P_8021Q) || VLAN_DEV_INFO(dev)->flags & VLAN_FLAG_REORDER_HDR) { Otherwise you'll miss AF_PACKET packets when REORDER is off. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/