Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp804095rdb; Fri, 17 Nov 2023 13:17:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IHnWgqzyRLnYbHPQ2wlrBbnDzrkQAwiLhBNRxyH65DiafH5wLzrXsVJ8fr7BehQz6oQd7gx X-Received: by 2002:a17:90b:3ec1:b0:274:6839:6a8c with SMTP id rm1-20020a17090b3ec100b0027468396a8cmr817495pjb.6.1700255875222; Fri, 17 Nov 2023 13:17:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700255875; cv=none; d=google.com; s=arc-20160816; b=siLiCSK54CGbScmdf6YgY/O4euw3dVQyUy3tVsGZhYjBbjJ46nqclRoJkXNQUfQ2Uk 5F1KQaZanOEBlYa4ZkQnTzlk4yw/VwBXLMo3RlQE/aeJwQJUZnTSAuG2Djvy0h6twq9d KBlyyxFBaynzI6tqm9qYJIfWbuB07RC2q0aP1zPK2uzJ36THIx9KG6aQxdbNklkJNE31 a5Nq2uKtmS2i4Dkj0DmMQdY0B41YY0xNIqaICW7WgPIFQUfngj5utvexT5GX0JQ4ffTL Rq7ZuB8FJzmqoEPNC+0+8iE3E8jSuSGB9N2SMog/UIZT6S+3sHSnCDWQ9DiH8HaceCmz utpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=qmYlKG0kPZLIIrSw3oG0B8tE2VGO6LF42SOfK2yZUBQ=; fh=m7aiqQkesIu1VuUFNb5yBMSDYJJ+P27xv68/s8vWm1U=; b=N3wwtOxGJaU/uh4DhGFFtnq48gRKMAwXE8QbDAguEYKYLSNjRvIYlT53+ttaZzpSvv 8SvgSsYLCumCuaoKOVD02d6cLchERnbaR6mOfb1yhyHjt/E/qcJXjRVVjY82klAJi/SJ 1zDX3A9pLICJ/kpdAIC5DrubOqtg/FhGQfP6c+L4steIbe41x803fNYEFCVCIXFIlBjA 8pJP6i0Oh02EQI9S3AUADur59VCJ52P5gXyLee0VyegeV1vAeXw7CQrsRHCl+vrCgYGT 3doYB8W9mBTeFPqhMW2RSDTP4uZQVWouxr6yI68OtSC7iW9hVkpSqd0pHxeRbeu+yaW7 QPhQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id ng4-20020a17090b1a8400b0027717627cf6si5316326pjb.41.2023.11.17.13.17.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 13:17:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id D5D0C82B485B; Fri, 17 Nov 2023 13:17:50 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346373AbjKQVRg (ORCPT + 99 others); Fri, 17 Nov 2023 16:17:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235797AbjKQVRN (ORCPT ); Fri, 17 Nov 2023 16:17:13 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 672712132; Fri, 17 Nov 2023 13:16:45 -0800 (PST) X-IronPort-AV: E=McAfee;i="6600,9927,10897"; a="457871004" X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="457871004" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2023 13:16:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10897"; a="909530057" X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="909530057" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga001.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2023 13:16:15 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1r46CD-0000000EuA0-00Ja; Fri, 17 Nov 2023 23:16:13 +0200 Date: Fri, 17 Nov 2023 23:16:12 +0200 From: Andy Shevchenko To: Andrew Davis Cc: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pinctrl: as3722: Use devm_gpiochip_add_data() to simplify remove path Message-ID: References: <20231116223045.274211-1-afd@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231116223045.274211-1-afd@ti.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_SOFTFAIL,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 17 Nov 2023 13:17:51 -0800 (PST) On Thu, Nov 16, 2023 at 04:30:45PM -0600, Andrew Davis wrote: > Use devm version of gpiochip add function to handle removal for us. Seems reasonable. Consider also to convert to dev_err_probe() (in a separate change). Reviewed-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko