Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <465b920e-9a0a-42c1-bf6c-451fb2471956@wolfvision.net>
Date:   Fri, 17 Nov 2023 23:25:54 +0100
User-Agent: Mozilla Thunderbird
From:   Michael Riesch <michael.riesch@wolfvision.net>
Subject: Re: [PATCH v11 2/3] media: rockchip: Add a driver for Rockchip's
 camera interface
To:     Mehdi Djait <mehdi.djait@bootlin.com>, mchehab@kernel.org,
        heiko@sntech.de, hverkuil-cisco@xs4all.nl,
        krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
        conor+dt@kernel.org
Cc:     linux-media@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
        alexandre.belloni@bootlin.com, maxime.chevallier@bootlin.com,
        paul.kocialkowski@bootlin.com
References: <cover.1700132457.git.mehdi.djait@bootlin.com>
 <db605935ad21c4780b73db87605b52d30bc936a4.1700132457.git.mehdi.djait@bootlin.com>
Content-Language: en-US
In-Reply-To: <db605935ad21c4780b73db87605b52d30bc936a4.1700132457.git.mehdi.djait@bootlin.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YzhFU3FJMFVOb1pRK2xTWWpkdG5sY2cyZCt3VlJIdVdHZHhESVlNSUlUc0Nu?=
 =?utf-8?B?MjVOUy90WW9seGJHV0pNTGlXT2JNV3pWN01FaXFmbXZkVTF6eDRkUEFzR2Jj?=
 =?utf-8?B?UVZNUmdaRUJqUnBDVmdnTGdPSFFJMmVCajlyOGg5TmFzN0EwRzZUYWZDWEQ3?=
 =?utf-8?B?eWF2eFVaSGdMWm0zSzNyaVpBendRbDdmbVhlMnluQmw1VngzdzE3d3JGV2Fm?=
 =?utf-8?B?YlJVNXd0ODZZT2IwV2lZbnhpNldWNmFuTUU0SnhPZW5ETEhNMHZJemc2YUVY?=
 =?utf-8?B?VUYzQ3d4dGFlTUNZQlBxaGVKQ2huZmp3aDNkTWZ2SWU0VnhnRHRNakM2VEE1?=
 =?utf-8?B?ekdRa2VmaE81ckV6Z0drZEVCUjBUbjIvUzA3eG0vVVpsS1ZVdUhYYmtIWGlG?=
 =?utf-8?B?TFlVWnBJNlV1UkJSbmswTm5NZE13aTBrdFBBaTdMQi9lcDFVUlBBcVRQRktR?=
 =?utf-8?B?ajZMK1dRamRGSUxEVktHN2oyMVJYc2dzM0lDTytkbXdkRGx1aHVjVmliemgy?=
 =?utf-8?B?U2h6K1hZZ2R4MVYrRUlUa3VKT1ZEWlM2Z0dsN09UWUVhQW9vSlVkbEhuczNi?=
 =?utf-8?B?ODNwZGRURnM0c1ZKZXRSbGNpWjBFdEJTcTRtNmNqSnFCbGRVaEJNWnhUdVhh?=
 =?utf-8?B?MnhFWlVuOU1PUW44UUJvS2xpWTFVZXNDbU5uc2Nneml5ZDJGVi9oMVRqazNN?=
 =?utf-8?B?M04vaUVEQUU0Z0NjVGowVy82eEx6SXpaRUZWSW5OVU9DR1BzQWN5VUc1V1ZT?=
 =?utf-8?B?a3Era0ttbGFQUTBlYlBQcmpROE80N1oycG4xcjZya2N1V3NpdWViWjczaFhx?=
 =?utf-8?B?RjlXcGVWUU15VDhLOVNEMDhoMi8zZ0g4Z1RtdUVGK3hUOXA5OUt4c0N5U1dw?=
 =?utf-8?B?dVUzMXF1TmNRMzJRNnFlNFlrbUVTbDFkWXNIazFSL0ZBR0dINVZIY0RFdFMx?=
 =?utf-8?B?VFVVODhiLytEWEhZaUh2UTg0TXQzRXlSeElhRGd1UndOY3h6YThvVXU4TlBS?=
 =?utf-8?B?VjUraXJnWUZoMFkvbEtZOEJ0NFhnaDBKZ1ZiZ0liK2szL0U1Rnp1RFdYcGJ2?=
 =?utf-8?B?L1BnMXpiT0prV3F1bUZZeURPdzEwL0FSL2lBS1dFSVdBOENQZzlhU09CVjJK?=
 =?utf-8?B?TGRrUDMvbERTd0J1NWxiZ1R3azJhaU84cW9tV1pNSS9Dd292ZlhqRGt3Rm12?=
 =?utf-8?B?TmtrWURNZmFMcXhyR0EvWTE4emVJS1lvTmZDaFVBdkxjcGp5aFNjOHFHWm1m?=
 =?utf-8?B?Q2RrNFR1QWZqRjFxNENadzg4OG1qMUJ6SEhwS1NTM3RpWVZaNkhVSjBFNldj?=
 =?utf-8?B?M3JJYXBCUVFYUUlVWllSZUtEZjdoN2VRUkUvWXZ5TUJtNVNKaDUwYStOYjJY?=
 =?utf-8?B?RWI1QTZXRGVBY0k3eEM3cGtNaVBRbW1KenovZ3F5YjhvUnk0SERJZ3AyaHFF?=
 =?utf-8?B?eGtobEpNclFiMlBvQjBySFovMHBraGk3MjdNVFBJWm81dUJPVk9ZSFU1SzRK?=
 =?utf-8?B?U3MwRnYvMmRSdW1NYlNlVmRzRXFqalI1a3lob1p0cjhDbGdHVWEvMm1kVWhH?=
 =?utf-8?B?bmpyMHp0MkNMbG8yUUtwYzc3azJCNkVYVXNiQ3JvdytjeGwxcXFObVh4dzJI?=
 =?utf-8?B?S255SC85UGNmV2VTVzFpVTdIU2RmQjZVQytIUU1KRXdPZHVhSzBrd3RuTHpU?=
 =?utf-8?B?S1QwZEU1YndvODMyTnhlT0h1V3FtWkxMVTQvY2NyUi9sOTAybmdPOGVUWW9T?=
 =?utf-8?B?bS9ibTFWTGdVYkNGU1ZGbWUxUXlMeWlZNG5XNEpyREtGaTNObFcyRnJRK0ts?=
 =?utf-8?B?eWYyY0RTWndnZWJPZ0d6UG5TUDZ5K3NXaHZuTGJjekRlTGlGRGtXY2NnMGpP?=
 =?utf-8?B?VXlCTVZ3K01Ba1JENlludFFER0FocVRoWi9uanVUQTQ1aW1WVWFaMWpOMHJI?=
 =?utf-8?B?NUZ0OUhSTnk3UFZuUlppdllNTmdjOUdOdzBxbFJVOEtVb1c2YlNUeVNkSFZl?=
 =?utf-8?B?NnlqYUEwSEgyY3JWQ3hkN0FRMHBuY1pMWE5qY1NkYis2TUlyNEt5cVl2OWtk?=
 =?utf-8?B?ZXVVdEhzaksxalFMRGRPamdSNk9HR3JaMmcwNy9iL0hVVXVuUVhWcGRnZk16?=
 =?utf-8?B?R21PcFl4MHpZU3ZhL1c5Y3FjeG5iUnA1Y1cxcXduM1JRYmdYRHY2R0VxdzdW?=
 =?utf-8?B?QVJnNVJyWkQzbloyVXQ4alhjS0lycTRISmlsTVdHd29lMHYzN2hyekhUcXV4?=
 =?utf-8?B?ekVrM3pQR0paNkFaYnBqRnJXQkt3PT0=?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 098535c3-1ed2-4dbb-ff2f-08dbe7bc2b44
X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB9155.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2023 22:25:57.0310
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6p18rYv8PNJL/H+IzSaSfJzmvRODy54bG4ofAZoyPwD9bydjW7fhOZCpzVAaBeK9e+uTjn2NFpZsI4/P7RjbAOMsenBelzIqxCG2jjyP4pU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5867
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Fri, 17 Nov 2023 14:26:22 -0800 (PST)

Hi Mehdi,

One more thing:

On 11/16/23 12:04, Mehdi Djait wrote:
> [...]
> diff --git a/drivers/media/platform/rockchip/cif/capture.h b/drivers/media/platform/rockchip/cif/capture.h
> new file mode 100644
> index 000000000000..533e62f518da
> --- /dev/null
> +++ b/drivers/media/platform/rockchip/cif/capture.h
> @@ -0,0 +1,21 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Rockchip CIF Driver
> + *
> + * Copyright (C) 2023 Mehdi Djait <mehdi.djait@bootlin.com>
> + */
> +
> +#ifndef _CIF_CAPTURE_H
> +#define _CIF_CAPTURE_H
> +
> +struct cif_device;
> +
> +void cif_unregister_stream_vdev(struct cif_device *dev);
> +int cif_register_stream_vdev(struct cif_device *dev);
> +void cif_stream_init(struct cif_device *dev);
> +void cif_set_default_format(struct cif_device *dev);
> +
> +irqreturn_t cif_irq_pingpong(int irq, void *ctx);
> +void cif_soft_reset(struct cif_device *cif_dev);

This cif_soft_reset occurs only here?! I think it should be removed.

> +
> +#endif
> [...]
With that (and maybe the renaming "Rockchip CIF Camera Interface" ->
"Rockchip Camera Interface (CIF)" throughout the driver, if you find
that suitable) addressed:

Reviewed-by: Michael Riesch <michael.riesch@wolfvision.net>

Thanks and best regards,
Michael