Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp871811rdb; Fri, 17 Nov 2023 15:47:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IHefEUqaXBjbiHQbpO6yxjQ0ySackBrOrquRBHMLMQHFB7FqSv+C5j95cxe4nPHDuLJt77r X-Received: by 2002:a17:902:70c8:b0:1cc:ef37:664a with SMTP id l8-20020a17090270c800b001ccef37664amr1084930plt.31.1700264859885; Fri, 17 Nov 2023 15:47:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700264859; cv=none; d=google.com; s=arc-20160816; b=B4FgoKWxPblXeZkcY0uvVTBO/4QHdVqW+TZ6vguwpn47SF1SqrbH0Skp0/z9irst2l mNQoE8Gnt0qwsA81Ee2mobVnOJjtSBuMq2hyg8FxSkEiwRD0lZkgcw49rfy6m7lk6R/m yLqc/kwqkbjyC5mCRUy0MgBjR6oKjdUyw6RaDbtgnHHT8ozdjK5PXwYu25GxiVe+V256 iNAY9swhlYmizmeYfBEUX8buyZQV0zaVGd7l2nNTqgg06jo2oxhoyLq+3zDkNGIDl2ji rweZ3iR7WvNPKfU2+EVyDMoevgTh9pKx7S+cXhcLUMm5Xb9b1cAStHYjKrMmNhUNqGxa 60LA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=8wM1V3uKaxmMfTVNrngWaOySMlzElI42CeEpsG+l1pg=; fh=Bwc7oFTHyXa5amfl/BMsNxrw9+0lRQlv6Q50Zh8tLvc=; b=HbCbGrwqufb2fVoZLzBdW+zKcFA/9G1+yj4OocQmtfQsq3sQ0/iibHo90gI8yFGF7l 9mENkkMi8YAl1NVkDYQl84WbvCEksBJNq3GDC3onEFphxvVNWpr+D4h0e0UozunnnyV6 lKiaUJ1k3XKLSdLVKZtfAVSE4ZHLvqH/6O3lZeA1kXu0kGo7OpGGtu6VeRoYzOaMdTXN k7qqGYbCWDn+T+1IP0jU1OdumpwGtWy8+eLPCD2vsWCTGLUl5FcVayct1ABgVCE1NNFE 7AhS5ayHK+0n3dg+0wXyLu+9B1WihZK1Z/Sg5k/Omt8XhH1iGPm9sjC/Ddu40Vaq+0Pz bWLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YITZQTWl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id c14-20020a170902d48e00b001c5d09c7b0dsi3046328plg.458.2023.11.17.15.47.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 15:47:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=YITZQTWl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id BE67982CAC1C; Fri, 17 Nov 2023 15:47:38 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346265AbjKQXrj (ORCPT + 99 others); Fri, 17 Nov 2023 18:47:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229823AbjKQXrh (ORCPT ); Fri, 17 Nov 2023 18:47:37 -0500 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4119DD7A for ; Fri, 17 Nov 2023 15:47:34 -0800 (PST) Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-50930f126b1so3354092e87.3 for ; Fri, 17 Nov 2023 15:47:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700264852; x=1700869652; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8wM1V3uKaxmMfTVNrngWaOySMlzElI42CeEpsG+l1pg=; b=YITZQTWlANVnWGW8Ochntl6IgCfSOeYbxCZulV+blBKr664tkfZV75r/n513c231Mc XUqsfW3fnH3ormjillLoept7DhRXOLKjoOlSA1Fbbm1IlSRW12D5pBMRMkVTKs8JEFrs gnYALStXuc+pGf+lr1JqvUpExmmAZv99VZ7f6Dx0moXBIJHlvkTDGT/iAxw/+QJo2ssW 1ZmlXOGFLj4MJ/x8t0VaQ0slm8xgdyXi3i7DNmVPXuQvaYh1A6ZpWLRS7ZZJRjqVys/G GVaDXIdghcadJ/fsr+Q6Tl5ONiJ+jHxTrja5VH34TwhNuzjaaRY+Og54nrpqIuq6zpMG T9Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700264852; x=1700869652; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8wM1V3uKaxmMfTVNrngWaOySMlzElI42CeEpsG+l1pg=; b=mGtrJFJ/XG57/PHFyEt7JwgpcMtyKGABXBCcysSoBDBikErfitbCnv8yqqcqz1N57N MttdBb9TSiKbb1IXt5v3EoBh1FXess7XRGYJR+OA9Ag0QLhilA1nq82nAZ3gGNBqqzAY eOR7UtVdUaPkF9H9HGzqEKINQil9AXX7FT+zgpAZc+Lyqg4hWnlKvBIR/CVy3/oCNu0e OaO0iEChUvFgk4QdH4wJdS2JSLfoemkq3j72j09Kb7scfoMDejyAEbMrqtI8MAVlguVh lKzP0bgq3OiyIpnjvnody9+/HpBqmeMnMkTq3ItWGbwnT3TxvbAsoXYrm/gsfmxHBIlh q1uw== X-Gm-Message-State: AOJu0YzM0UwWP8tq0l7gKx0SHkM0DTT8C8Uzw9dL/ztxeGqn1s4xLE3S P38O36AFTFAp09narKn1FwMYDQ== X-Received: by 2002:ac2:54a4:0:b0:507:9a49:2d3d with SMTP id w4-20020ac254a4000000b005079a492d3dmr766293lfk.31.1700264852473; Fri, 17 Nov 2023 15:47:32 -0800 (PST) Received: from [192.168.201.100] (178235187040.dynamic-4-waw-k-2-3-0.vectranet.pl. [178.235.187.40]) by smtp.gmail.com with ESMTPSA id s16-20020aa7cb10000000b00544f8271b5fsm1168871edt.8.2023.11.17.15.47.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Nov 2023 15:47:31 -0800 (PST) Message-ID: <041f239f-7b40-4681-8c6c-2268f9c2c684@linaro.org> Date: Sat, 18 Nov 2023 00:47:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] USB: dwc3: qcom: fix resource leaks on probe deferral Content-Language: en-US To: Johan Hovold , Greg Kroah-Hartman Cc: Andy Gross , Bjorn Andersson , Thinh Nguyen , Krishna Kurapati PSSNV , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231117173650.21161-1-johan+linaro@kernel.org> From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: <20231117173650.21161-1-johan+linaro@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 17 Nov 2023 15:47:39 -0800 (PST) On 17.11.2023 18:36, Johan Hovold wrote: > When reviewing the recently submitted series which reworks the dwc3 qcom > glue implementation [1], I noticed that the driver's tear down handling > is currently broken, something which can lead to memory leaks and > potentially use-after-free issues on probe deferral and on driver > unbind. > > Let's get this sorted before reworking driver. > > Note that the last patch has only been compile tested as I don't have > access to a sdm845 device. > > Johan I'll sound like a broken record, but: is there anyone in the world that is actively benefiting from this failed experiment of using the ACPI tables that were shipped with these SoCs? There are so so so many shortcomings associated with it due to how Windows drivers on these platforms know waaaay too much and largely use ACPI to "bind driver x" and I simply think it doesn't make sense to continue carrying this code forward given little use and no testing. Konrad