Date: Tue, 27 Nov 2007 00:00:08 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Prakash Punnoor <prakash@punnoor.de>
Cc: "peerchen" <peerchen@gmail.com>,
       "linux-kernel" <linux-kernel@vger.kernel.org>,
       "pchen" <pchen@nvidia.com>, "acurrid" <acurrid@nvidia.com>
Subject: Re: [PATCH 1/2] msi: set 'En' bit of MSI Mapping Capability on HT
 platform
Message-Id: <20071127000008.1d4dc323.akpm@linux-foundation.org>
In-Reply-To: <200711251121.49585.prakash@punnoor.de>
References: <200711251121445151346@gmail.com>
	<200711251121.49585.prakash@punnoor.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1090
Lines: 32

On Sun, 25 Nov 2007 11:21:45 +0100 Prakash Punnoor <prakash@punnoor.de> wrote:

> Yay:

Sounds good.

> One thing I noticed in the patch:
> +		if (((bridge_dev = pci_find_slot(0, 0)) != NULL) &&
> 
> You rather want to use pci_get_bus_and_slot instead, as pci_find_slot is 
> deprecated.

yup.  I'll queue this to get it a bit of testing but won't send it to Greg,
in the expectation that an updated version will be prepared.

Please do feed the diff through scripts/checkpatch.pl too - there are a
large number of trivial coding-style glitches in there.


Also, your [patch 1/2] will break the build unless your [patch 2/2] is
applied.  This will break git bisection so please avoid it.  It is
appropriate to fold both these patches into a single one.

And please avoid sending multiple patches under the same title, as these
two were.

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/