Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <c40ddfd4-5781-4382-a3f1-c18cbfb22b34@infradead.org>
Date:   Fri, 17 Nov 2023 18:26:32 -0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] checkpatch: add judgment condition for Kconfig help test
Content-Language: en-US
To:     Cixi Geng <cixi.geng@linux.dev>, apw@canonical.com, joe@perches.co,
        dwaipayanray1@gmail.com, lukas.bulwahn@gmail.com,
        akpm@linux-foundation.org
Cc:     linux-kernel@vger.kernel.org
References: <20231116153904.15589-1-cixi.geng@linux.dev>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20231116153904.15589-1-cixi.geng@linux.dev>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi--

On 11/16/23 07:39, Cixi Geng wrote:
> From: Cixi Geng <cixi.geng1@unisoc.com>
> 
> The has_help only counted the  situation which the patch file add
> a help line, when the config was renamed and  modify description,
> the has_help is zero for the "help" line not added.
> 
> here is one case:
>     the modify file: drivers/iio/adc/Kconfig  line(1047)
> 
>     -config SC27XX_ADC
>     +config SPRD_ADC
>      	tristate "Spreadtrum SC27xx series PMICs ADC"
>      	depends on MFD_SC27XX_PMIC || COMPILE_TEST
>     +	depends on ARCH_SPRD
>      	help
>     -	  Say yes here to build support for the integrated ADC inside the
>     -	  Spreadtrum SC27xx series PMICs.
>     +	  Say yes here to build support for the integrated ADC inside of the
>     +	  Spreadtrum SC27xx and UMPxx series PMICs.
> 
>      	  This driver can also be built as a module. If so, the module
>      	  will be called sc27xx_adc.

OK, I made those changes to that Kconfig file and ran checkpatch.
I didn't get any of the following checkpatch results.

Are you using a current version of checkpatch?

> the checkpatch result:
>     WARNING: please write a help paragraph that fully describes the config symbol
>     #23: FILE: drivers/iio/adc/Kconfig:1050:
>     +config SPRD_ADC
>     +	tristate "Spreadtrum's ADC PMICs driver"
>      	depends on MFD_SC27XX_PMIC || COMPILE_TEST
>     +	depends on ARCH_SPRD
>      	help
>     +	  Say yes here to build support for the integrated ADC inside of the
>     +	  Say yes here to build support for the integrated ADC inside of the
>     +	  Say yes here to build support for the integrated ADC inside of the
>     +	  Spreadtrum SC27xx and UMPxx series PMICs.
> 
>      	  This driver can also be built as a module. If so, the module
>      	  will be called sc27xx_adc.
> 
>     total: 0 errors, 1 warnings, 17 lines checked
> 
> Fixes: b8709bce9089 ("checkpatch: improve Kconfig help test")
> Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com>
> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 25fdb7fda112..402009d08505 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3616,7 +3616,7 @@ sub process {
>  					$needs_help = 1;
>  					next;
>  				}
> -				if ($f =~ /^\+\s*help\s*$/) {
> +				if ($f =~ /^\+\s*help\s*$/ || $f =~ /^\s*help\s*$/) {
>  					$has_help = 1;
>  					next;
>  				}

-- 
~Randy