Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <06648cde-e8d9-42d0-a8ef-15c9a9b8850a@gmail.com>
Date:   Sat, 18 Nov 2023 18:45:49 +0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] power: supply: Fix indentation and some other warnings
Content-Language: en-US
To:     Charalampos Mitrodimas <charmitro@posteo.net>,
        Sebastian Reichel <sre@kernel.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Mario Limonciello <mario.limonciello@amd.com>,
        qinyu <qinyu32@huawei.com>, Nick Alcock <nick.alcock@oracle.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Huacai Chen <chenhuacai@kernel.org>,
        Kai-Heng Feng <kai.heng.feng@canonical.com>,
        Andreas Kemnade <andreas@kemnade.info>,
        Ian Molton <spyro@f2s.com>,
        Szabolcs Gyurko <szabolcs.gyurko@tlt.hu>,
        Anton Vorontsov <cbou@mail.ru>
Cc:     Linux Power Management <linux-pm@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20231117230658.65809-1-charmitro@posteo.net>
 <ZVf48PWBpvKULeXT@archie.me> <CX1VDFVCGNKO.3JX5QY0LZQ51B@beast>
From:   Bagas Sanjaya <bagasdotme@gmail.com>
In-Reply-To: <CX1VDFVCGNKO.3JX5QY0LZQ51B@beast>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/18/23 17:36, Charalampos Mitrodimas wrote:
> Hi Bagas,
> 
> On Sat Nov 18, 2023 at 1:36 AM EET, Bagas Sanjaya wrote:
>> On Fri, Nov 17, 2023 at 11:06:58PM +0000, Charalampos Mitrodimas wrote:
>>> These were mentioned by checkpatch:
>>> 	Errors:
>>> 		(1) code indent should use tabs where possible
>>> 		(2) switch and case should be at the same indent
>>> 	Warnings:
>>> 		(1) quoted string split across lines
>>> 		(2) Missing a blank line after declarations
>>>
>>> Based on this comment from "include/linux/module.h", modules with
>>> multiple authors should use multiple MODULE_AUTHOR() statements.
>>> 	/*
>>> 	 * Author(s), use "Name <email>" or just "Name", for multiple
>>> 	 * authors use multiple MODULE_AUTHOR() statements/lines.
>>> 	 */
>>> 	#define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)
>>
>> Shouldn't MODULE_AUTHOR fix be separate patch?
> 
> Sorry, I should have mentioned in the commit that the warnings "quoted
> string split across lines" pertained to the MODULE_AUTHOR line. 
> 
> In the commit message I'm just clarifying why I used multiple
> MODULE_AUTHOR statements.
> 
> Should I send a v2 patch with a revised commit description?
> 

OK but as separate patch.

-- 
An old man doll... just what I always wanted! - Clara