Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Sat, 18 Nov 2023 17:36:09 +0000
From:   Catalin Marinas <catalin.marinas@arm.com>
To:     Jim Cromie <jim.cromie@gmail.com>
Cc:     linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH 2/2] kmemleak: add checksum to backtrace report
Message-ID: <ZVj2CRI7452gm6lH@arm.com>
References: <20231116224318.124209-1-jim.cromie@gmail.com>
 <20231116224318.124209-3-jim.cromie@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231116224318.124209-3-jim.cromie@gmail.com>
Precedence: bulk

On Thu, Nov 16, 2023 at 03:43:18PM -0700, Jim Cromie wrote:
> Change /sys/kernel/debug/kmemleak report format slightly, adding
> "(extra info)" to the backtrace header:
> 
> from: "  backtrace:"
> to:   "  backtrace (crc <cksum>):"
> 
> The <cksum> allows a user to see recurring backtraces without
> detailed/careful reading of multiline stacks.  So after cycling
> kmemleak-test a few times, I know some leaks are repeating.
> 
>   bash-5.2# grep backtrace /sys/kernel/debug/kmemleak | wc
>      62     186    1792
>   bash-5.2# grep backtrace /sys/kernel/debug/kmemleak | sort -u | wc
>      37     111    1067
> 
> syzkaller parses kmemleak for "unreferenced object" only, so is
> unaffected by this change.  Other github repos are moribund.
> 
> Signed-off-by: Jim Cromie <jim.cromie@gmail.com>

Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>