Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758131AbXK0JcU (ORCPT ); Tue, 27 Nov 2007 04:32:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752893AbXK0JcD (ORCPT ); Tue, 27 Nov 2007 04:32:03 -0500 Received: from smtp2.linux-foundation.org ([207.189.120.14]:43506 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751179AbXK0JcA (ORCPT ); Tue, 27 Nov 2007 04:32:00 -0500 Date: Tue, 27 Nov 2007 01:31:19 -0800 From: Andrew Morton To: Denis Cheng Cc: linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Randy Dunlap Subject: Re: [PATCH 2/2] ide-scsi: use print_hex_dump from Message-Id: <20071127013119.d12b7791.akpm@linux-foundation.org> In-Reply-To: <1196061373-6394-1-git-send-email-crquan@gmail.com> References: <1196061373-6394-1-git-send-email-crquan@gmail.com> X-Mailer: Sylpheed 2.4.1 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2784 Lines: 72 On Mon, 26 Nov 2007 15:16:13 +0800 Denis Cheng wrote: > these utilities implemented in lib/hexdump.c are more handy, please use this. > > ... > > --- a/drivers/scsi/ide-scsi.c > +++ b/drivers/scsi/ide-scsi.c > @@ -242,16 +242,6 @@ static void idescsi_output_buffers (ide_drive_t *drive, idescsi_pc_t *pc, unsign > } > } > > -static void hexdump(u8 *x, int len) > -{ > - int i; > - > - printk("[ "); > - for (i = 0; i < len; i++) > - printk("%x ", x[i]); > - printk("]\n"); > -} > - > static int idescsi_check_condition(ide_drive_t *drive, struct request *failed_command) > { > idescsi_scsi_t *scsi = drive_to_idescsi(drive); > @@ -282,7 +272,7 @@ static int idescsi_check_condition(ide_drive_t *drive, struct request *failed_co > pc->scsi_cmd = ((idescsi_pc_t *) failed_command->special)->scsi_cmd; > if (test_bit(IDESCSI_LOG_CMD, &scsi->log)) { > printk ("ide-scsi: %s: queue cmd = ", drive->name); > - hexdump(pc->c, 6); > + print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 16, 1, pc->c, 6, 1); > } > rq->rq_disk = scsi->disk; > return ide_do_drive_cmd(drive, rq, ide_preempt); > @@ -337,7 +327,7 @@ static int idescsi_end_request (ide_drive_t *drive, int uptodate, int nrsecs) > idescsi_pc_t *opc = (idescsi_pc_t *) rq->buffer; > if (log) { > printk ("ide-scsi: %s: wrap up check %lu, rst = ", drive->name, opc->scsi_cmd->serial_number); > - hexdump(pc->buffer,16); > + print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 16, 1, pc->buffer, 16, 1); > } > memcpy((void *) opc->scsi_cmd->sense_buffer, pc->buffer, SCSI_SENSE_BUFFERSIZE); > kfree(pc->buffer); > @@ -816,10 +806,10 @@ static int idescsi_queue (struct scsi_cmnd *cmd, > > if (test_bit(IDESCSI_LOG_CMD, &scsi->log)) { > printk ("ide-scsi: %s: que %lu, cmd = ", drive->name, cmd->serial_number); > - hexdump(cmd->cmnd, cmd->cmd_len); > + print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 16, 1, cmd->cmnd, cmd->cmd_len, 1); > if (memcmp(pc->c, cmd->cmnd, cmd->cmd_len)) { > printk ("ide-scsi: %s: que %lu, tsl = ", drive->name, cmd->serial_number); > - hexdump(pc->c, 12); > + print_hex_dump(KERN_DEBUG, "", DUMP_PREFIX_OFFSET, 16, 1, pc->c, 12, 1); > } > } > Would you believe that this patch (which removes code) actually increases drivers/scsi/ide-scsi.o .text by 75 bytes? I didn't look to see why - probably that huge arg count is hurting, possibly some additional strings being emitted? Either way, perhaps a simple little front-end to print_hex_dump() is called for. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/