Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
From:   Yuran Pereira <yuran.pereira@hotmail.com>
To:     bpf@vger.kernel.org
Cc:     Yuran Pereira <yuran.pereira@hotmail.com>, andrii@kernel.org,
        mykolal@fb.com, ast@kernel.org, martin.lau@linux.dev,
        song@kernel.org, yonghong.song@linux.dev, john.fastabend@gmail.com,
        kpsingh@kernel.org, sdf@google.com, haoluo@google.com,
        jolsa@kernel.org, shuah@kernel.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-kernel-mentees@lists.linuxfoundation.org
Subject: [PATCH bpf-next v2 0/4] selftests/bpf: Update multiple prog_tests to use ASSERT_ macros
Date:   Sun, 19 Nov 2023 00:10:23 +0530
Message-ID: <GV1PR10MB6563AECF8E94798A1E5B36A4E8B6A@GV1PR10MB6563.EURPRD10.PROD.OUTLOOK.COM>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: GV1PR10MB6563:EE_|AM0PR10MB3713:EE_
X-MS-Office365-Filtering-Correlation-Id: 1cb15348-1671-4030-db07-08dbe865e127
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: EtPHSsHbVbnQVPfgUD953NYwfPhsT97t2sYNuspb1MOEjPbBuqcgGUZeLC6aIAYc5NpDzD1mXdHT4HlHTs6nw+a9B4R3EWh5xM3iCyMpISKgM9O//unPYtZVRsytTp+ZyjFIvO3r/0HmYJVFGVQhkit4P8DgDDRK2TJCuAPmGCCpurNcN954CktoSuuyvyajZoh+lZznf4Ibe7LV+OmbcWk4UdRkVhMVph7i9lFlZxlFTC9JAL7T31NiHsImhNyZafXJ7xL6aOV/JRVXMXy2Uh0qMkPOo96yNV+BzBUe/rVaJSQIvpS2JSo1ZWra/VpEjSGXLZSL+O30UiQx0i9CdKqoFeOOZVueX4YGJLqpyEsitu8v1yLFTcFMi/v+tqv9wi0mg9D3qsUp3mfcQfv2NLB0+io8sF8rwIhyG3pFYtICWOVuLFuoCtF6jtGTb8QP1RWe5nmroRfslag7/NT79ZggCcp+vDTzY8y8/35hjyx6BtpmqQNaDWtkjSOJ0wPJARPRPdVPm1UvCPWh8s1rflCtANqvfmDK4ggtdQ8xG1332xsi95Br8sjPbqqOYhlBISwxuPZH7fRCa6LqXtCCKUFLNkQZsl1WEdQp19WZ2CwF18Ait/Ns/smNYLQ10jnd
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/oVrnni1+OPDk6vZZhMYw06+MNeIJdR44mXBTezHqf3Iwthza/bdlW62N1+Z?=
 =?us-ascii?Q?/JlTxzNEcPKHsfneovLwfj/jjZJkTqbPV+NnP+O5LGvC8bJ0bStGBswwgMN5?=
 =?us-ascii?Q?HpHrB0ZIUELXpJh7B6jwsCJ2GuzS8iDn6GjVww9C0Tt/oDqceIyn3bHQUjJn?=
 =?us-ascii?Q?K50/kmhPRELkai9nw+QHIOxr4pC0m1l+TpDD3hH4lVGi+6eqS6icytTRRIvG?=
 =?us-ascii?Q?91PSFu1vzxNMaGg/4RNl3yAo6rSaWAAIZ0UDm7ZfJTGqZO7LVxlmG8iQTlWL?=
 =?us-ascii?Q?Orz7PIq+bLImocS9G7dTYYpaVmETgRyKU2e7R8M4eukP7/eqCjuNXsCuqDn/?=
 =?us-ascii?Q?cBmAr9FM4tG4jU9RjbZbypmVgSQ4mUBHuxpcqMtphiymSp7H9W7LTn4TDdDK?=
 =?us-ascii?Q?AGrJWeEPQ0x/HcgQ+srI8LRlvaJ8ItseTmbA6BSWzWXOvS763TuKDlQpycxQ?=
 =?us-ascii?Q?+fQi3Ba3WIXInhHmJtKt2gWmTfOESGfnoXovwyUsT7UoUIHEOGZZrEqikhGD?=
 =?us-ascii?Q?9SWrReOqTDUCRb675rosFgrY6LKSTysHIC/gxaFEi6EtvjES6XD54KXDKyLv?=
 =?us-ascii?Q?CHMX/0U2pp0CMwOSs4qMgwsn7j46PTej74e5Jx8vNGHklxzVRpsp/9ZNaznb?=
 =?us-ascii?Q?0tsFg9RNm59WTE5oirq2yK06hwZlBquWo4aHkAl3mTtlJCUnMQuxB1mbzhDd?=
 =?us-ascii?Q?cpqhyPuuy86trnh7ikquUC24ByW6yd4pf/fHboyGRz3P8d241KTIzFPXGJs/?=
 =?us-ascii?Q?sCF73iyKR4dUTE4dzjjhSQ8EN8qBrE3os/KP3RTTn+lO7XFTMdVB3hWLpcXR?=
 =?us-ascii?Q?iDGJ81S/9UId+0/R6q3ANjuf9nqfxYNj2fE8g/bedGIdI9Ayy4VtWbxtdA52?=
 =?us-ascii?Q?zeDr+xeBpZmLApAAp4KuX+rIjeLRcJGces+r2bU6HizZXu2PlH7lfaU5qAaC?=
 =?us-ascii?Q?Gj8PGZrSN6oGpYmF7L4XliYhWhgO1srszBdjRU64CTW1DdRqa8oiBICybAsl?=
 =?us-ascii?Q?4poUZk4+FaoTBQbAqChTpcDJhzTa4XdYqSpu7BUAl/OALsVVYpNnsj7ApDuQ?=
 =?us-ascii?Q?46gm5kQ1NhubCzUPy9d+/qW0nzGVbZTGm9xoMpGGA8buStJqnblLVKqnHZwr?=
 =?us-ascii?Q?2kU5mpD8XDdOhabzJbDPLSYEA0Ji66j0QchDFXCCFtjHR4tiyjKK6BiT7H7H?=
 =?us-ascii?Q?e1+xNQrPRNLHVFh1JhL3qUavnMUmatGjsTFJLRwza1H9flToIYUlLE6EMUQ?=
 =?us-ascii?Q?=3D?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-6b909.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 1cb15348-1671-4030-db07-08dbe865e127
X-MS-Exchange-CrossTenant-AuthSource: GV1PR10MB6563.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2023 18:40:47.3271
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR10MB3713
X-Spam-Status: No, score=0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,FORGED_HOTMAIL_RCVD2,FREEMAIL_FORGED_FROMDOMAIN,
	FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Sat, 18 Nov 2023 10:41:14 -0800 (PST)

Multiple files/programs in `tools/testing/selftests/bpf/prog_tests/` still
heavily use the `CHECK` macro, even when better `ASSERT_` alternatives are
available.

As it was already pointed out by Yonghong Song [1] in the bpf selftests the use
of the ASSERT_* series of macros is preferred over the CHECK macro.

This patchset replaces the usage of `CHECK(` macros to the equivalent `ASSERT_`
family of macros in the following prog_tests:
- bind_perm.c
- bpf_obj_id.c
- bpf_tcp_ca.c
- vmlinux.c

[1] https://lore.kernel.org/lkml/0a142924-633c-44e6-9a92-2dc019656bf2@linux.dev

Changes in v2:
- Fixed pthread_join assertion that broke the previous test

Previous version:
v1 - https://lore.kernel.org/lkml/GV1PR10MB6563FCFF1C5DEBE84FEA985FE8B0A@GV1PR10MB6563.EURPRD10.PROD.OUTLOOK.COM/

Yuran Pereira (4):
  Replaces the usage of CHECK calls for ASSERTs in bpf_tcp_ca
  Replaces the usage of CHECK calls for ASSERTs in bind_perm
  Replaces the usage of CHECK calls for ASSERTs in bpf_obj_id
  selftests/bpf: Replaces the usage of CHECK calls for ASSERTs in
    vmlinux

 .../selftests/bpf/prog_tests/bind_perm.c      |   6 +-
 .../selftests/bpf/prog_tests/bpf_obj_id.c     | 204 +++++++-----------
 .../selftests/bpf/prog_tests/bpf_tcp_ca.c     |  50 ++---
 .../selftests/bpf/prog_tests/vmlinux.c        |  16 +-
 4 files changed, 106 insertions(+), 170 deletions(-)

-- 
2.25.1