Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp1393413rdb; Sat, 18 Nov 2023 14:50:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IEUl80n9EZ5xe9d0HWgqP2X0EvJimxA8AGeSKoJWuHMhhD3Qdmn+s5MaqJrX+OdFu+cpdGv X-Received: by 2002:a17:903:5cd:b0:1cc:6b55:fd3 with SMTP id kf13-20020a17090305cd00b001cc6b550fd3mr3449034plb.42.1700347856393; Sat, 18 Nov 2023 14:50:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700347856; cv=none; d=google.com; s=arc-20160816; b=yiSkTnYtT/ZAYb1YS9vK/GWIh6fQwq8/71bv74hCgCN5UOXzwboP1IRV/DcBRifGRn XllCn3IL3zW9cmpP61804pBRbFg7fNUJLWBAsDFm1hyKqhinGNw/PSp80ywqp4AJhWBP NzrblYkMtEFheh9fNOnrnMyBLh8jB4UahDlg5qNWRNx+FYjQVCwWh55wHYardyKTd/KI 8S5lPK5KLjm2mNl9EDtW/YBV3ei+G5LWYB0/sqgtMiIH1VQyc8Vf7/+W4dvMeRatXBxG 9F3TItkj9nWuvMwNMaq95/GgaEzKBLa/3Fq2iNr2sqaa1/pIKl7OBv5FPJXqmLJrntjt Nsqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=o386RTvOhAFgndJeNqCVQcdAOdQEOcc9CfrDmqkyA4k=; fh=QdJR9jtNIj2Sbd7syGL/9waVyGlQYJT1MzIZmEabwTw=; b=KSkETIepXjV17qiTN7wwaWpP/IQBVjeoZRs9CsB3quibPKpze/lqVpbc6IehGcGe6r t/3sXe6SdBjeEdzQjl5iRuOaiYucMGIc5VrKHymbpQfUv/5W82YLBSgP3pQJgQzRLZiH SH4ZTWlDd2UxBWZuslFu76DHfbpaYleminIzOlsiecezjcgdVWG+B33hcnaBFBR9Jrrw +WpC/Sxa2cSdteBOcWp3VwKBSP72jK9OfWDqyJR8mCXkmRHvY6ou3UAaYf+TLsAM3o38 kie00WQrU/JwFNrqnCjd7XRCkfS3S5HYrYVCXovaF2AWa/pEIBH8tSPH4QRWMqzsJkUU zekw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AVadxAym; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id b14-20020a170903228e00b001cc2523cf08si5307117plh.428.2023.11.18.14.50.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 14:50:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AVadxAym; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 7F4B380ADF17; Sat, 18 Nov 2023 14:50:55 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229766AbjKRWuw (ORCPT + 99 others); Sat, 18 Nov 2023 17:50:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229610AbjKRWuv (ORCPT ); Sat, 18 Nov 2023 17:50:51 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4CBE131 for ; Sat, 18 Nov 2023 14:50:47 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22F40C433C8; Sat, 18 Nov 2023 22:50:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700347847; bh=uQ/ZSMcPli58vrb2wZICC9Grz2rXBkOrQowxrcXgkO4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=AVadxAymdMxzQOCkCvQNww/5PBBPuoRgATXpsklBGLOebAkssLi332HEOy35Wec8i b9cpyaf6Po7KG2unaQ/Zx1JMKN6vTOyXVrfxcbg6le6lZOXggwqJa2GZzwmBzZRBjV dt7FkjEOJnbBHezfTyQBE1TN98HILGaQaW0MyjAe1jY/q/EBHZ+MEYYsdh9hyD6Osq dZplJYKsGZzzesycWyKVuzxoDdTfrHBd1MD0/cBKNAueid3ty9M2e1nppWIOlvlm+v 9e/9xFfxbyzMAHJu3dGTKj7VMvt3slTHvgnlcTm981hek7dGv61L95i7bT9Ip8pRnK +ObAfK5ZGSQqw== Date: Sat, 18 Nov 2023 14:50:46 -0800 From: Jakub Kicinski To: Justin Lai Cc: , , , , , , , Subject: Re: [PATCH net-next v11 05/13] net:ethernet:realtek:rtase: Implement hardware configuration function Message-ID: <20231118145046.7bb8efca@kernel.org> In-Reply-To: <20231115133414.1221480-6-justinlai0215@realtek.com> References: <20231115133414.1221480-1-justinlai0215@realtek.com> <20231115133414.1221480-6-justinlai0215@realtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sat, 18 Nov 2023 14:50:55 -0800 (PST) On Wed, 15 Nov 2023 21:34:06 +0800 Justin Lai wrote: > + .ndo_vlan_rx_add_vid = rtase_vlan_rx_add_vid, > + .ndo_vlan_rx_kill_vid = rtase_vlan_rx_kill_vid, > +#ifdef CONFIG_NET_POLL_CONTROLLER > + .ndo_poll_controller = rtase_netpoll, > +#endif > + .ndo_setup_tc = rtase_setup_tc, This patch is still way too huge. Please remove more functionality from the initial version of the driver. You certainly don't need VLAN support or CBS offload to pass packets.