Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp1423293rdb; Sat, 18 Nov 2023 16:22:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IGGE1Og65jDIHOQfK1QlcShqSg5QD/D/ghUNmW3/a7+l38InsJzhfWi+U+xKwSmDXm4KWLn X-Received: by 2002:a05:6a20:959b:b0:187:5684:4b82 with SMTP id iu27-20020a056a20959b00b0018756844b82mr3326173pzb.10.1700353345305; Sat, 18 Nov 2023 16:22:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700353345; cv=none; d=google.com; s=arc-20160816; b=sXuPojUWG7/70RXtPqzTJqEFP5JPaDB+aHh+is7t/uwZdJNl7KkWaCjZzvjumbRBMk 9kuW8C9qWc7woL7Q1xVomH+Qi7gVUjRmFj3vtEEkXnF4sHAY9GjCsOEIxnCmcpKve5JK 1i2F/A3OTUi0cYJIQSkbt22F5E6LMGWurHlrJgH+VlWUg8crUqZ+yGSxcvkh3QI6CSLw X0zXqucSVSTSlHVniZkWgOvAaMeeyUqaao9TKAIciXW84E/clyOXCF8M0GzJLZSES4Ay iJGHEWAF0zi/X+LV9acCMwWfWrkLRd0Rq2siN8LqVmrl98hlBD6fgXS6Y16qNlyj1HWP Ah7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=njhZ+VEXY43nM/ztzb1ihZasqdd6Cd8C+mifV4uY/i8=; fh=4jluAnvSBpl3XgT0Uwi2Fw5LymOaqCQn07JelCE178o=; b=nf4bVyJtYIt3nZuw9SR/YeaBksyLUv8p9iJOj4QzchAB+7i/zLXc5X8uja4vLW1MCD rU1ZR96DB3JfvAyfwN5wfFMJkqmc1ak/10rYrAVs+7/qxYSZtrIros1dQ/cSMy73Yjrv 0zUi2d7R9vPQF0/rP25p7xXHxCmRmdCw32JeXTBRljIEYhOImLtNRBXf/xs4xWGzpFUp uOGOdtfeM2pDU6c2NsbUR/QWY8yqyo3538NaAbJthzKNSBkV9C3QZd83Vc2oBZnXFu9O 9mXjxJfW3AuI4mbkgxZVN9XfsupG+dmagJXjW3uZIn0lIe+hjbrzn/+j/JspTOOWz8gR iKtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ogU1lkuB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id jh6-20020a170903328600b001cc50f67fd9si4858222plb.511.2023.11.18.16.22.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 16:22:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ogU1lkuB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id A0346805117A; Sat, 18 Nov 2023 16:22:22 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229766AbjKSAWU (ORCPT + 99 others); Sat, 18 Nov 2023 19:22:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229722AbjKSAWT (ORCPT ); Sat, 18 Nov 2023 19:22:19 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53A2A192 for ; Sat, 18 Nov 2023 16:22:16 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2133BC433C8; Sun, 19 Nov 2023 00:22:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700353335; bh=njhZ+VEXY43nM/ztzb1ihZasqdd6Cd8C+mifV4uY/i8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ogU1lkuBP7h3e4Pzq67ZPDXlPApu6eBJFWXVCwbtfba0b6iRlchETP6JbVXt2Kg84 WZk1ID/f0CPrv4pqA0cFpbM6CD2vfLwYyXNFHF0caNHVbUBFKA2xzPmG2C8foB+24A RPnMARKe0y7cL6DzwBSiqWCXhErVcnGHSFb7MUCG2zk7jFXAaVKLPiltp08JGmHpB7 B1QVwwqNMEfvL5Vx6tdlZQIHR7TqrYaHPZziEtgbJn1C4GiUkiCf3X8GZj/N2bRWcK fic+xmWgPANV0O9gwxO5dLDpwlMzmyNWqsoLqQXjk2UjsuYY810GFeH9mrD/awKNP6 ZSP1DPLEUqe7A== Date: Sat, 18 Nov 2023 16:22:14 -0800 From: Jakub Kicinski To: Luo Jie Cc: , , , , , , , , , , , , , Subject: Re: [PATCH v5 4/6] net: phy: at803x: add the function phydev_id_is_qca808x Message-ID: <20231118162214.7093d46c@kernel.org> In-Reply-To: <20231118062754.2453-5-quic_luoj@quicinc.com> References: <20231118062754.2453-1-quic_luoj@quicinc.com> <20231118062754.2453-5-quic_luoj@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sat, 18 Nov 2023 16:22:22 -0800 (PST) On Sat, 18 Nov 2023 14:27:52 +0800 Luo Jie wrote: > +static inline bool phydev_id_is_qca808x(struct phy_device *phydev) Please drop the "inline" keyword. The compiler will decide what's best.