Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp1423679rdb; Sat, 18 Nov 2023 16:23:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IGpjDDEfin1ifqn3v7pIs2LjT9z9YtK4otf41zxwfYjYLTSIeTeJmnbls3+bUdKVd9PelCV X-Received: by 2002:a05:6808:1642:b0:3a3:95f9:c99b with SMTP id az2-20020a056808164200b003a395f9c99bmr4202289oib.35.1700353435400; Sat, 18 Nov 2023 16:23:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700353435; cv=none; d=google.com; s=arc-20160816; b=ZGwKMhKM+pdjP8dDmX1JxX8QtmACbJ1DgtdhyqcV2sT8JL5KI3cqge+k5o6fhlp8Vv cFmq2WCFe+QDPYOwHPRSI6uASz1+or+yUYCW1CzDdUwC1S1Vjww15CJCtp2a9HC33qfm cTWlixnNXb6Ht1ECVXRvkO5rhWB3viCUSP0EbiWyk0ChJSM6BvLVT8G1oX8Iag4bubpn cpjRxoFpUsru4r7KOhsy3OBNTivFmRIkIU4MnVSewfIC/ta3r/ml7FcybtwHd7jREuUV +Tts0eScCH3O0OGv0TQGs5yCMoNwNcklS5lHAeZV6Q6yjAW6kLLZECKCyZyyKnzgBAdf nEVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=6BrLLsbWOWGeAcZq+VJ+JQZz5mhUl+bsl8hgX6Nh3gc=; fh=4jluAnvSBpl3XgT0Uwi2Fw5LymOaqCQn07JelCE178o=; b=cpO0VOLDRZiDKZ4jeO1QFIWd3en+bnqcT6hHWI/Lo5e/T+8xd4xyJ4SoXW6kUPSWCy onH2Le9wnY7Im5o3g5at3HJ/+J8EgNLpy2+JhQf7ja1bw+CwKz5ZJtM2aY24fqqQyRQP CTwK9yy95NaGVNmWMHJVJSaYEdJJ7lZ9IRtbQxT4jqKAZgpetTSguWWKTSDBhgfgWkKz RO3uzY13N3YSAxPaGok+u9PgdOjEP6rxTX+07TYQStrKhv4Yxee+CmC+Qz5ooxZ+k14g KI9jDRc/aR6uB3A1OugVMvwMcJUGdRxbjy5Bwj4D9yM0MttEFEjEJYICpXl6BjOgb8sJ iQOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oATT8xp4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id e191-20020a6369c8000000b00578a43e3b0bsi5135263pgc.655.2023.11.18.16.23.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 16:23:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oATT8xp4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 45D0D80A5F8E; Sat, 18 Nov 2023 16:23:54 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229924AbjKSAXw (ORCPT + 99 others); Sat, 18 Nov 2023 19:23:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229722AbjKSAXv (ORCPT ); Sat, 18 Nov 2023 19:23:51 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D02D6131 for ; Sat, 18 Nov 2023 16:23:48 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA873C433C8; Sun, 19 Nov 2023 00:23:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700353428; bh=V60ZCbQw/VscUoWlSULCrP5V5BNoqEvg6B+bmvnfU+w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oATT8xp4EVfNPEIfP0BVmfLN3VIpusAJ274bozQGBStcdQLrlaK6l4he+rzSDAEk8 29uTWkXIVYeYF44C0egMrO3tjSyvG2Zv4eljYROYTR0YaPu3V7Ittx5Bx2mSduJOxC KSUuyxs9MfJUfjLR+N7DcqzOLKy0WpjnQAEtEN+ZVMJkU5KoscdK7eXuNOOs8nvjgJ MSdZ6E8mSXLpYieYylUzxh9av24FyJW8TKhLirVa9EON0pVGoDvGrmURr76CIdmbTW gE7JXIW96/8jdYAR4hF9Ag8aJKc4GKQQ/0ebBaQSgTdxzOpBJPJWad+zcX9ATCAcwL hnOhHWa4UnzLw== Date: Sat, 18 Nov 2023 16:23:46 -0800 From: Jakub Kicinski To: Luo Jie Cc: , , , , , , , , , , , , , Subject: Re: [PATCH v5 3/6] net: phy: at803x: add QCA8084 ethernet phy support Message-ID: <20231118162346.0c66226a@kernel.org> In-Reply-To: <20231118062754.2453-4-quic_luoj@quicinc.com> References: <20231118062754.2453-1-quic_luoj@quicinc.com> <20231118062754.2453-4-quic_luoj@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sat, 18 Nov 2023 16:23:54 -0800 (PST) On Sat, 18 Nov 2023 14:27:51 +0800 Luo Jie wrote: > + /* There are two PCSs available for QCA8084, which support the following > + * interface modes. > + * > + * 1. PHY_INTERFACE_MODE_10G_QXGMII utilizes PCS1 for all available 4 ports, > + * which is for all link speeds. > + * > + * 2. PHY_INTERFACE_MODE_2500BASEX utilizes PCS0 for the fourth port, > + * which is only for the link speed 2500M same as QCA8081. > + * > + * 3. PHY_INTERFACE_MODE_SGMII utilizes PCS0 for the fourth port, > + * which is for the link speed 10M, 100M and 1000M same as QCA8081. Wrap the comments please. Please use checkpatch with --max-line-length=80