Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Sun, 19 Nov 2023 20:51:19 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Oliver Sieber <ollisieber@gmail.com>, Takashi Iwai <tiwai@suse.de>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Sound System <linux-sound@vger.kernel.org>,
        Linux ALSA Development <alsa-devel@alsa-project.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: Re: Fwd: acp3x: Missing product ID for Thinkpad T14s Gen2 AMD Ryzen
 7 PRO 5850U
Message-ID: <ZVoS13B2Br9U8mvu@archie.me>
References: <8bd0e77f-720b-4804-bbd8-477bd7df938e@gmail.com>
 <251c1bea-8250-40dd-bdea-1cd739d1e77a@gmail.com>
 <a75ce6e7-5012-43d8-a222-dd2639c5969c@gmail.com>
 <78149e00-12b5-459b-8754-a17dd974916d@gmail.com>
 <87sf54jyjl.wl-tiwai@suse.de>
 <826bb4f4-c6ea-4c45-a0e0-5ca826f0cfe0@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="RgrZYw5NPeRGwo21"
Content-Disposition: inline
In-Reply-To: <826bb4f4-c6ea-4c45-a0e0-5ca826f0cfe0@gmail.com>
Precedence: bulk


--RgrZYw5NPeRGwo21
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Nov 19, 2023 at 09:54:32AM +0100, Oliver Sieber wrote:
> Hi,
>=20
> in the following I provide my proposed patch for the bug report on Bugzil=
la
> [1]. Let me quote from it:
> > Hey,sound/soc/amd/renoir/rn-pci-acp3x.c has a hard-coded list of quirks=
=2E It seems like some product IDs may be missing. In my case, I am using a=
 Lenovo Thinkpad t14s gen2 with an AMD Ryzen 7 PRO 5850U.
> > My audio output is fine but my internal microphone cannot be found.
> >=20
> > Running `dmidecode` yields:
> >=20
> > Handle 0x000F, DMI type 1, 27 bytes
> > System Information
> > 	Manufacturer: LENOVO
> > 	Product Name: 20XGS1KT02
> > 	Version: ThinkPad T14s Gen 2a
> >=20
> > Could it be that one may have to add the product ID "20XGS1KT02" to the=
 hard-coded list of quirks in rn-pci-acp3x.c?
> >=20
> >=20
> > It seems as there have been similar problems in the past, e.g.https://b=
ugzilla.kernel.org/show_bug.cgi?id=3D216270.
>=20
> My proposed diff looks as follows:
>=20
> Subject: ASoC: AMD Renoir - add DMI entry for Lenovo ThinkPad T14s Gen 2
> From: Oliver Sieber
> The ThinkPad T14s Gen 2 laptop does not have the internal digital
> microphone connected to the AMD's ACP bridge, but it's advertised
> via BIOS. The internal microphone is connected to the HDA codec.
>=20
> Use DMI to block the microphone PCM device for this platform.
>=20
> Signed-off-by: Oliver Sieber <ollisieber@gmail.com>
> ---
> diff --git a/sound/soc/amd/renoir/rn-pci-acp3x.c
> b/sound/soc/amd/renoir/rn-pci-acp3x.c
> index b3812b70f5f9..754e24d55e6f 100644
> --- a/sound/soc/amd/renoir/rn-pci-acp3x.c
> +++ b/sound/soc/amd/renoir/rn-pci-acp3x.c
> @@ -199,6 +199,13 @@ static const struct dmi_system_id rn_acp_quirk_table=
[]
> =3D {
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 DMI_EXAC=
T_MATCH(DMI_BOARD_NAME, "20NLCTO1WW"),
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 }
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 },
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 {
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 /* Lenovo ThinkPad T14s Gen 2 */
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 .matches =3D {
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 DMI_EXACT_MATC=
H(DMI_BOARD_VENDOR, "LENOVO"),
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 DMI_EXACT_MATC=
H(DMI_BOARD_NAME, "20XGS1KT02"),
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0 }
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 },
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 {}
>=20
> =C2=A0};
>=20

Hi Oliver,

Did you forget Takashi's suggestion to follow formal patch submission
procedure [1]? Hint: It is suggested to use git-send-email(1) when
sending patches, as it handles them as-is (e.g. no wordwrapping,
tabs preserved).

Thanks.

[1]: https://lore.kernel.org/alsa-devel/87sf54jyjl.wl-tiwai@suse.de/

--=20
An old man doll... just what I always wanted! - Clara

--RgrZYw5NPeRGwo21
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHQEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZVoS1AAKCRD2uYlJVVFO
oxEwAP9tVEhVvsolMp9atXWPaMw9tMx11FLXrcNpseXNiPTpWwD40zHKn4qSaSFA
d+qO6fzkUeHigQdKkJrzBoLskjqsAg==
=bWQV
-----END PGP SIGNATURE-----

--RgrZYw5NPeRGwo21--