Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp1693665rdb; Sun, 19 Nov 2023 06:45:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IElIzkd878YFPTqFHvZeNNgn7C3W1by3kqxMCJ4+1f0A9x/C2fPGrQUL66/nDc2PBy9dwF4 X-Received: by 2002:a05:6a20:9f8b:b0:187:27d3:1592 with SMTP id mm11-20020a056a209f8b00b0018727d31592mr3471768pzb.37.1700405102078; Sun, 19 Nov 2023 06:45:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700405102; cv=none; d=google.com; s=arc-20160816; b=MPFDP6rYtWRW3WKyVr9knPB1uaWmlOKoeb+Qv2DoilF+6jkCuLUZo+tZoCHZfRlU1g G8tpbp874usm4jIU2WPGjdY+ZSlDPlg+FGIGoq40k9ydJWYCNL6cxzSKioPZhavXmXL0 qLpOEEr+Wx68o63gujgUezsqeNEt3pmqySOuMWexmfIYXV5mYQnHQ+NBpT9jJ/xYlE/z 4kJqM0bOPA2DZcI66lla64VEEhO+qYxVe8Lc3nXrKlGMMjKhc0cD47xLErAcFjEEKIbu 775cPdVjCjBdX7e9Glbas8T50zxh27jgsAT0m7mwhKPnZfydFe8iMqaPa7WYQ+u4K9eN 1QtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=5ZI6+aQ9+c+bpfwBYIcSU777SeZBaK2MLQMxaHGRpFI=; fh=2JZ+UG1AogFwOcDhtSf278wL4E3lSlZ+nT3qMgBPsh0=; b=COEPot+VxY+nlvs/Y0U5iKLpxUW4ewy/yMMO/8ijXwuuDDqT9nfzPhUAzrNPkmkdVa ZT88hTZwDzoVpmoACaJ0yCzWyXnUO0TbFwarJdoAKELnCciW/YGRZxrNYoQnAffkXe1s L/4llLy1VtiJBjaoW232WPZyVQ8kNHRnOw1tzx/ZpcXWVLqGzC50IH0Nduz1OcAEeD6n /2ItLe0JyHiyAGXE2/fifnhzxwI1eWB6cxYxjWYWDys8R9fiQYIvXCNgaGg5urLLaQid ESx8ejA811SsBsZMXLpd0hJj0YiqtllGSnkDeJ7g7DFeTP14HchLHJ3KCUW1GBY8vxex ROcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=OiEUm9QF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id w2-20020a056a0014c200b006cb894c66edsi976173pfu.93.2023.11.19.06.45.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 06:45:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=OiEUm9QF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id B9752809D446; Sun, 19 Nov 2023 06:44:59 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231441AbjKSOk7 (ORCPT + 99 others); Sun, 19 Nov 2023 09:40:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231228AbjKSOkr (ORCPT ); Sun, 19 Nov 2023 09:40:47 -0500 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B515F2; Sun, 19 Nov 2023 06:40:44 -0800 (PST) Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2c79d8b67f3so43499781fa.0; Sun, 19 Nov 2023 06:40:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700404842; x=1701009642; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=5ZI6+aQ9+c+bpfwBYIcSU777SeZBaK2MLQMxaHGRpFI=; b=OiEUm9QFSNEg91mUf5F9nvElGp3BqlxbGkMmoFkVZQjSIl3Cc+J6oI+PYFjH1Yktft 8cocuDDr8/2JOlz+29xLDOOa+6GFXgui9m9qNzQ4xE6yIj+6kMwtm8pzOIQik5pefzrk jJZMolZ/D5RdutkZGDc83NluZUstx4LSLRHfJmO7w6fSNl6za5wBD6cqsN5vbngXlDy6 TvdyhfaTEsZn63URdl8r0MqG7f2g+eSUwiMGctTO+arwKgvYOuXjxj7VEoai0cSAuzEK 8KPoynhIVv+iQOfzLbLlnAJkzdtKsq4f6xLPCfpVHpKcRtY8Npc4aQLD6+epgi3lQ41f FTfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700404842; x=1701009642; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5ZI6+aQ9+c+bpfwBYIcSU777SeZBaK2MLQMxaHGRpFI=; b=bD79H/fpnTiv5p+vtxExhG3uWKzfEk/OQksRjR8/K8nhOOrrpd5Jkc0ORrXy9O27T0 rILJwr7T8/gxfEO0mq0jNYWa9b3QrxnKwe3q1SrDQlihDT58SfY9Kpg4uSkuXCum/nLz /NFIy3naX3+By2O5zamkuEywdNVlhR/sQ6Ufa1uGzSnbyCXWo/3cgff9ET1r79kRQ49U 0p6LZ1BNZwVFeIfBhd1ekew2no5PRVeZTwjN01CjdVilD0gvIDkGUPcGRdpZTiHZK050 Pvi27AaezJKBDbbRzBRyb+4RbIn6idVlEiOPHueIwvvyaM90SmSCo1cxQFKuBpSgTnDN zbqA== X-Gm-Message-State: AOJu0Yzb+evu48fuN3kl8OjgVnYZ7uW0Pn0ZdLpQliqJkXPQSeT2dsXg 3FYaz9lpaxZ1gINn0+fjK4E= X-Received: by 2002:a2e:2245:0:b0:2c8:713c:b506 with SMTP id i66-20020a2e2245000000b002c8713cb506mr3263978lji.43.1700404842251; Sun, 19 Nov 2023 06:40:42 -0800 (PST) Received: from skbuf ([188.26.185.114]) by smtp.gmail.com with ESMTPSA id a3-20020a05600c348300b0040a5e69482esm14598744wmq.11.2023.11.19.06.40.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 06:40:42 -0800 (PST) Date: Sun, 19 Nov 2023 16:40:39 +0200 From: Vladimir Oltean To: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= Cc: Daniel Golle , Landen Chao , DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Russell King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Frank Wunderlich , Bartel Eerdekens , mithat.guner@xeront.com, erkin.bozoglu@xeront.com Subject: Re: [PATCH net-next 02/15] net: dsa: mt7530: use p5_interface_select as data type for p5_intf_sel Message-ID: <20231119144039.gvbima26zhktf6bd@skbuf> References: <20231118123205.266819-1-arinc.unal@arinc9.com> <20231118123205.266819-3-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231118123205.266819-3-arinc.unal@arinc9.com> X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sun, 19 Nov 2023 06:44:59 -0800 (PST) On Sat, Nov 18, 2023 at 03:31:52PM +0300, Arınç ÜNAL wrote: > Use the p5_interface_select enumeration as the data type for the > p5_intf_sel field. This ensures p5_intf_sel can only take the values > defined in the p5_interface_select enumeration. > > Remove the explicit assignment of 0 to P5_DISABLED as the first enum item > is automatically assigned 0. > > Signed-off-by: Arınç ÜNAL > Acked-by: Daniel Golle > --- Reviewed-by: Vladimir Oltean