Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp1716708rdb; Sun, 19 Nov 2023 07:32:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IF11FhWNI9ZR65gVVageV3/gAb/jC/jW+PjfZYOGbxdiJCUosoS5lto4GV0ji1Ej5jcSsFI X-Received: by 2002:a17:90a:c:b0:280:5b33:d30 with SMTP id 12-20020a17090a000c00b002805b330d30mr4882579pja.44.1700407939148; Sun, 19 Nov 2023 07:32:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700407939; cv=none; d=google.com; s=arc-20160816; b=o3W+fhUoYd5BljYPghYZJz3pd8WcEn5Z/z1c/xEACdGlcwo+ySLbkgQkjEMwTpTCNB QDnc25LC849+Yd9uj0Vizt378Dun40msG2d4D/jIOIFfD56GaR4z+JJlY8AqYXQnlB9M D+cNk5nOcyLtub3IaWrXI5OTBVPrXgI3YJZ/uCQZzzXz4DdfoJD5hFFuPFm+Hg+w2rvJ TQ9kNHvskX5S3Bu5czTiMrtGEmorixEVxWT5jBtMdDhNAXyX7f+ujj1eu/l3RPV4nLN2 ls8xFMYQV+1/g2SP4tXcYRbZ51TjZqBpknS0njxz95ZCnil8enM+i8pG0ZF7x5+00JPi eBWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=VJDSDW6Pnxgedb2WwvdXdi3IPWir2LFj6HcK4uMq+TE=; fh=hiWpBIwgvERwoxUk7mrmmuTGAWPkj1XZzqBye9hNZi0=; b=vEq0UjCRBNFk7gwodNCHQ4G5nds1Jl1Dc1pXHMIZmzaEg1BC09PQWvswvSwyIA/C0R 0WkXQnDn6JEDMu5KFSIpfwdfbMvlo8gQ1igmWeMHuBKhH4bChNtlMzRS391ENVF0ie+Z KsVu0jBkqL7ZfJkNA4dcHCQ0qXbptylqMI8wN4OF+roSU4yyRxmmsmCWK5qwZdXITTug o9csEW775VxG0Evly4cShCWGN669kFzyzllhxq24cXa2XwigRko5JSgzRMmOdjhTTskn TTZdhqOFMy4trhc72i7io1IfwVjAfnk/kxMahr16W9uunePJswS5B/o8rU1X46r/AkDX HYjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HJ2UPx9i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id sr13-20020a17090b4e8d00b00276df8c5b83si6757914pjb.143.2023.11.19.07.32.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 07:32:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HJ2UPx9i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 1BFCC807C85C; Sun, 19 Nov 2023 07:31:49 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229820AbjKSPbs (ORCPT + 99 others); Sun, 19 Nov 2023 10:31:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229642AbjKSPbq (ORCPT ); Sun, 19 Nov 2023 10:31:46 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3980C2 for ; Sun, 19 Nov 2023 07:31:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700407902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VJDSDW6Pnxgedb2WwvdXdi3IPWir2LFj6HcK4uMq+TE=; b=HJ2UPx9ik7g/XWy5UxZrE1EwMopu0Wg48qHjJ+vPp2Z4k5lMYX+YAx0ZWcaY4EcPU7L1ea 2rIjfiPxhEPrqrX4CygnqgJZwzdFDtFLL4NhDChAQIpoyydMsVqblmyc0fIud//MLjouXd qPAFt66vzh8rubWoxf6r+ftD+xS5FF8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-517-aaxRoKxrNoKaooQ-KTCq4A-1; Sun, 19 Nov 2023 10:31:39 -0500 X-MC-Unique: aaxRoKxrNoKaooQ-KTCq4A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 910D7185A782; Sun, 19 Nov 2023 15:31:38 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.31]) by smtp.corp.redhat.com (Postfix) with SMTP id 5F08D2026D4C; Sun, 19 Nov 2023 15:31:34 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Sun, 19 Nov 2023 16:30:33 +0100 (CET) Date: Sun, 19 Nov 2023 16:30:28 +0100 From: Oleg Nesterov To: Tejun Heo Cc: syzbot , boqun.feng@gmail.com, brauner@kernel.org, cgroups@vger.kernel.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, lizefan.x@bytedance.com, longman@redhat.com, michael.christie@oracle.com, mingo@redhat.com, mst@redhat.com, peterz@infradead.org, syzkaller-bugs@googlegroups.com, wander@redhat.com, will@kernel.org Subject: Re: [syzbot] [cgroups?] possible deadlock in cgroup_free Message-ID: <20231119153028.GB29401@redhat.com> References: <000000000000f5b0d0060a430995@google.com> <0000000000009642b4060a4f017f@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sun, 19 Nov 2023 07:31:49 -0800 (PST) On 11/19, Tejun Heo wrote: > > On Thu, Nov 16, 2023 at 05:25:05PM -0800, syzbot wrote: > > syzbot has bisected this issue to: > > > > commit 2d25a889601d2fbc87ec79b30ea315820f874b78 > > Author: Peter Zijlstra > > Date: Sun Sep 17 11:24:21 2023 +0000 > > > > ptrace: Convert ptrace_attach() to use lock guards > > Looks like the tasklist_lock conversion in ptrace_attach() forgot _irq. > Peter, Oleg? Yes, please see Re: [syzbot] [kernel?] inconsistent lock state in ptrace_attach https://lore.kernel.org/all/20231117094531.GN8262@noisy.programming.kicks-ass.net/ Oleg.