Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Sun, 19 Nov 2023 17:30:55 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Conor Dooley <conor@kernel.org>
Cc:     Elad Nachman <enachman@marvell.com>, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com,
        pali@kernel.org, mrkiko.rs@gmail.com,
        chris.packham@alliedtelesis.co.nz, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        cyuval@marvell.com
Subject: Re: [PATCH v5 2/3] dt-bindings: arm64: add Marvell COM Express boards
Message-ID: <1d19b6da-2d16-41d1-8c04-587890dcda52@lunn.ch>
References: <20231119102638.1041978-1-enachman@marvell.com>
 <20231119102638.1041978-3-enachman@marvell.com>
 <20231119-avatar-implicate-75cd2f12dff5@spud>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231119-avatar-implicate-75cd2f12dff5@spud>
Precedence: bulk

> > +      - description:
> > +            Alleycat5X (98DX35xx) Reference Design as COM Express Carrier plus
> > +            Armada CN9131 COM Express CPU module
> > +        items:
> > +          - enum:
> > +              - marvell,ac5x-car-with-cn9131
> 
> Why not just marvell,cn9131-ac5x-carrier or similar? The "with" isn't
> particularly helpful.

As the description says, this is the combination of the SOM plus the
carrier to give a complete RDK.

Elad, do the RDK as a whole have a name? You can use that here for the
compatible.

	Andrew