Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp1816172rdb; Sun, 19 Nov 2023 11:29:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IHjRBM0h5m63yNLjwYvMHzeSLefrR0KhhoV+3draj08OavfJNO1MyxTApWNoUvGvhOKUjLN X-Received: by 2002:a05:6808:1986:b0:3a7:500a:a491 with SMTP id bj6-20020a056808198600b003a7500aa491mr7939007oib.28.1700422179826; Sun, 19 Nov 2023 11:29:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700422179; cv=none; d=google.com; s=arc-20160816; b=rbSvJpzwX0Gh1r98mBDb34p+PPGcvFOyMvak5Sh/1+uHBmW5KHPEeGRSw4vI1bsZl6 qCVqIrVwFVtEnnoaUAqRTuPdpIp5BK4cA8MVez3Mx2HjPykW0Fse5Pb5vze/tXarWg6a 8asQmU9o3Ej49fBj+RWX0kfTyIz6Q+UoJDmzQH5VdpsMs7d0psSYM2FjORMw2AellnxA c6S2PUAbMszMnESXS+Js1SS6JaFInZeZ2KBlLxgPgd+2UlpKHhT0lBXUe/LarR6YdWVp uqLuKFBVgWNbVP+CsjDbUlFtRHiptB3qpiOvlQryRnYN3aw0ulQDVwkJA9GJl146As25 JmgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version; bh=xHMDn9WqlIhOM4pdUV508kZkDTPFdPrxhYelNg2I9HQ=; fh=qg+tc2IKAn9Q9b0KukgJFql+Uv7AKFDHHat2gi5tZAc=; b=YWC4+5s53dP65jY8LHEWrHpaC0NlhiWuRqmer/HRhznbDYULih3711WSx+7VgzxrOm pNEUpcaCrQ6KoSthSSMQ++FGFfxvhVD4WGgJba6nsQctbbWclYehCfva3UMn2lSv6t6h bySptCm+MkLnUgnWZVrWg9DI4Ipx8ISgCebkVlw8MtI4fwRjUKM6O4vMzWIPSGBsUGhv /mMLH/oYMIRRCHvni0UXMyM0LW4qUkaBipW5OOkdCvUhOjP8BMLaMEaRi7R/MlLUTb62 Upv2o0A/Tm+a5nNiUkYfYPIWnifC9+h++1RpdMq3tZhS2esZo+8waXQbRjV2B1mkVvMX 6XFQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id b36-20020a631b24000000b005c1b28061b0si7002618pgb.65.2023.11.19.11.29.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 11:29:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 93A4780A1858; Sun, 19 Nov 2023 11:29:38 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229665AbjKST3i convert rfc822-to-8bit (ORCPT + 99 others); Sun, 19 Nov 2023 14:29:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229557AbjKST3h (ORCPT ); Sun, 19 Nov 2023 14:29:37 -0500 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 090ADE5 for ; Sun, 19 Nov 2023 11:29:34 -0800 (PST) Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-5caa401f151so238157b3.0 for ; Sun, 19 Nov 2023 11:29:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700422173; x=1701026973; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nSuZWXA7VX1qqz2aTwL0m12B4oKVg9yE4zPN8KTIR1o=; b=M7i2QgDVwddSCIXkyHjXwmHtUhoOcFMLXb35aIN3fINi1ONWrIEquOsokPEjKb7GUB 0s7eSA6FbDE+ZDNCNZX6PN+uUfHMVKNptlJiQYcdKteMKC9QPE47BSDnwioxkZmbcZXi /252n3mcF0UnL8VPJhyf65lqXAWNJfXYYsUgNlN+OtYgpbe4aNyQ4Zzzckvi18kOOuMh TIu+ld76Cpc1wxym7piNBq7Mi2rNdU8LDusTKk5CDQbX2VUSxFfDTwnzhDtkBlEQHQ+s pKcrF+eScYTxRb3P+dNMnkjBQ/wtCJcKnCW+XPPsp6llT3G+QX6QSAy/reyJhaVkZZAu w78g== X-Gm-Message-State: AOJu0YxYBAb+lPgkoGgMZKVOtcH01qCrN9JaxpVQke37ufbRms9ozVmC QpEPzY+axUBH8+oIBZ1D7jhXzM5kCyLAhA== X-Received: by 2002:a05:690c:2b89:b0:5a7:af97:c787 with SMTP id en9-20020a05690c2b8900b005a7af97c787mr4597330ywb.11.1700422173134; Sun, 19 Nov 2023 11:29:33 -0800 (PST) Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com. [209.85.128.170]) by smtp.gmail.com with ESMTPSA id y7-20020a0def07000000b005a247c18403sm1917273ywe.37.2023.11.19.11.29.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Nov 2023 11:29:31 -0800 (PST) Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-5c5b9c142e8so30589707b3.3 for ; Sun, 19 Nov 2023 11:29:30 -0800 (PST) X-Received: by 2002:a81:dd09:0:b0:5a7:fbd5:8c1 with SMTP id e9-20020a81dd09000000b005a7fbd508c1mr5935678ywn.17.1700422170381; Sun, 19 Nov 2023 11:29:30 -0800 (PST) MIME-Version: 1.0 References: <20231118155105.25678-1-yury.norov@gmail.com> <20231118155105.25678-33-yury.norov@gmail.com> In-Reply-To: <20231118155105.25678-33-yury.norov@gmail.com> From: Geert Uytterhoeven Date: Sun, 19 Nov 2023 20:29:19 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 32/34] m68k: rework get_mmu_context() To: Yury Norov Cc: linux-kernel@vger.kernel.org, Hugh Dickins , Andrew Morton , linux-m68k@lists.linux-m68k.org, Jan Kara , Mirsad Todorovac , Matthew Wilcox , Rasmus Villemoes , Andy Shevchenko , Maxim Kuvyrkov , Alexey Klimov , Greg Ungerer Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sun, 19 Nov 2023 11:29:38 -0800 (PST) Hi Yuri, Thanks for your patch! On Sat, Nov 18, 2023 at 4:51 PM Yury Norov wrote: > ALSA code opencodes atomic find_and_set_bit_wrap(). Switch it to ALSA? > dedicated function. > > Signed-off-by: Yury Norov The rest LGTM, but as it's Coldfire code, I'd like to defer to Greg. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds