Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   Yuran Pereira <yuran.pereira@hotmail.com>
To:     kgdb-bugreport@lists.sourceforge.net,
        linux-trace-kernel@vger.kernel.org
Cc:     Yuran Pereira <yuran.pereira@hotmail.com>,
        jason.wessel@windriver.com, daniel.thompson@linaro.org,
        dianders@chromium.org, rostedt@goodmis.org, mhiramat@kernel.org,
        linux-kernel@vger.kernel.org,
        linux-kernel-mentees@lists.linuxfoundation.org
Subject: [PATCH 2/2] trace: kdb: Replace simple_strtoul with kstrtoul in kdb_ftdump
Date:   Mon, 20 Nov 2023 05:39:31 +0530
Message-ID: <GV1PR10MB6563DC208657E86715361E94E8B4A@GV1PR10MB6563.EURPRD10.PROD.OUTLOOK.COM>
In-Reply-To: <GV1PR10MB65635561FB160078C3744B5FE8B4A@GV1PR10MB6563.EURPRD10.PROD.OUTLOOK.COM>
References: <GV1PR10MB65635561FB160078C3744B5FE8B4A@GV1PR10MB6563.EURPRD10.PROD.OUTLOOK.COM>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: GV1PR10MB6563:EE_|AS8PR10MB6173:EE_
X-MS-Office365-Filtering-Correlation-Id: 0043e2f8-305c-43e9-eb33-08dbe95d0827
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: lXrK6pfk9eMDSXua+6UMg6vLTYb5DgQTL3zbC5fEfj/WwsbRKOrx+o4zv9Vc1cBs7WqvGMXbWVgzpC4/fn9py4nNiCKa437uOk+QaxIuNuWgGp4JTLwAUjIFRBuB5tkK3Z95ffmUmfnJB9UnMzgRWa13H3uJjK1JEL+rO5K9CIiudzyndsR88ytGN4xLAhrLQM1USVW+wvNFz+Gk2jivQSzY4j/qIVtx7tGLTxSSgLkwgaCrP8RbetD4CkzbI9+KMILc9e0d8x8C79gJLmXXoZ6gy67/5+acy2G/QSy/j8JBGKsv99rGQgMWiK17N0M2dzj32wdMibVHIRE4p01pZQb5XL5GhXzcxbuyMQhECKazK1HoEdcem0ES6K+nGIyaAi2Df9K0sFPkZQjem9jQHNGRyRaz5GPOj45lfOYve+ADdPTxhmYmcp+ONEZCmvtnf5fRArvH7n7Cc2HONHx2B44CUKr9d4jBfRbbby0XS1Ny2n6E1fO8seKVwPfxmOlIZ7pxaO6rfINPm4dBN2Mhf23Xk8nLX2W2DKHlxjh1las1iNs5ovBB47MkwvZlAe4m+X8fmciNQQ94T+nFiCuKsAA++5ZMUG6rhhzaSGmRNvtPDJmnCW63j1d03+Ktriyx
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RKP9mj73Pe3+qqs/6VmIFcWml/Ltbgz8XylAS+FPRYI7Eh6UdrtW87mf0hWS?=
 =?us-ascii?Q?d4laJxyLfH+HnM1Gzo3uSeXC9U9OT4Ojgp7JZWNFsnG1MwRis9UDZoczmLXZ?=
 =?us-ascii?Q?wMckyUGwxmrNKn8g0tBwW5TVdr5MHta/RxbdPUX6fxwuz3zGkRQNsqSr/4z+?=
 =?us-ascii?Q?DB6xSBJ4knpX3aTLriUquIkpmTz2GbZigmlWUb60rbfWxwPqPL3454QPZVO6?=
 =?us-ascii?Q?jO6L6v2tlFDb3/D2nfAVLa5lJVFNjpMSgCizf48clG70Evt0xdwWnyAKDk4P?=
 =?us-ascii?Q?a5D8poT7IT0+Kk/rmSjzIkq+BOmFzJXPluscUcl/dTjgn7hOfpieEcK7BpqP?=
 =?us-ascii?Q?lZpfSyLx5RQQ5Gelu+7mdD64oSqaHGVQyG3Livs3sGmCvr26lGojqZtYy8T3?=
 =?us-ascii?Q?6npkZh/jV22lxke+mNahwYD5YKUEqTmaLbUHD5bER2p7mreKQUWSDfO6ZDfq?=
 =?us-ascii?Q?kb1HzNSDrLHNDyrugYqNNCZWIMcOatTyvTNgZPxitj+EGMEXVpfjGkR41krB?=
 =?us-ascii?Q?4ie+7Soig6JYuDLxOP4sBbyENWFGUsP21qDpI5x78ZWhlUz7+tGcaP/25GZK?=
 =?us-ascii?Q?bSMkPHZYJnLVgWfKajkp+3/v6qhwSXLGojji0/FE3TSZt0y/nXRcuOJn/h/P?=
 =?us-ascii?Q?tvl0Xq2G10fSDSnAOeoJO21rx2I791UVxA57ZBB1P8yFBvNG8mZEiV3O6w/K?=
 =?us-ascii?Q?BP3eh4WwILyUpJ5MhGaBc8Cm5ewJDVTvv0f7G6v2kKPzQG00EzLEWUwp8wAz?=
 =?us-ascii?Q?sACkdwvsWv53b47feQ5wf/I1x1zhO5sJMBl29nFTA3fwswy2OahltNEhn344?=
 =?us-ascii?Q?PN04DyuuglvzdTkWZQALg+eZ0BUHjW1poEQGyJFhyhXASO1Mj/ZEszxWQDpE?=
 =?us-ascii?Q?B/ffVsTBFNPj0Oei2wMBRF0dAnVE4zym5CXNq7FnRADLEVwSteUFiUllgune?=
 =?us-ascii?Q?z0yIF7gHSziU4wfvGez2KrLGf3kyml3Z3Y8guZxfV8aLbvmiBwKg+09Gi+pX?=
 =?us-ascii?Q?0FBtA5LP3+LDq2aukBlBdpA8ncTxXA7JRIwu/kr51JUkwdLDHC2QkmsQ0i8R?=
 =?us-ascii?Q?+du7/UvgEpCdRlgC2vuJW5NOstsckF7GbmOPaM0okv1vja9AnurylTjXh9w+?=
 =?us-ascii?Q?ziDBcKUPD9f1SVxsvOykRV7s70N3nPiA3Q0lCEmgv7SMdCnng1OBuMCq94HI?=
 =?us-ascii?Q?ozZyKJty+efsyJ8bTf+kCRS9jSPZ/sV0WwDT0cNcjGmVkWLprTq8SvOotZ8?=
 =?us-ascii?Q?=3D?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-6b909.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 0043e2f8-305c-43e9-eb33-08dbe95d0827
X-MS-Exchange-CrossTenant-AuthSource: GV1PR10MB6563.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2023 00:09:58.4302
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR10MB6173
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sun, 19 Nov 2023 16:10:05 -0800 (PST)

The function simple_strtoul performs no error checking in scenarios
where the input value overflows the intended output variable.
This results in this function successfully returning, even when the
output does not match the input string (aka the function returns
successfully even when the result is wrong).

Or as it was mentioned [1], "...simple_strtol(), simple_strtoll(),
simple_strtoul(), and simple_strtoull() functions explicitly ignore
overflows, which may lead to unexpected results in callers."
Hence, the use of those functions is discouraged.

This patch replaces all uses of the simple_strtoul with the safer
alternatives kstrtoint and kstrtol.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#simple-strtol-simple-strtoll-simple-strtoul-simple-strtoull

Signed-off-by: Yuran Pereira <yuran.pereira@hotmail.com>
---
 kernel/trace/trace_kdb.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/kernel/trace/trace_kdb.c b/kernel/trace/trace_kdb.c
index 59857a1ee44c..3891f885e4a6 100644
--- a/kernel/trace/trace_kdb.c
+++ b/kernel/trace/trace_kdb.c
@@ -96,23 +96,21 @@ static int kdb_ftdump(int argc, const char **argv)
 {
 	int skip_entries = 0;
 	long cpu_file;
-	char *cp;
+	int err;
 	int cnt;
 	int cpu;
 
 	if (argc > 2)
 		return KDB_ARGCOUNT;
 
-	if (argc) {
-		skip_entries = simple_strtol(argv[1], &cp, 0);
-		if (*cp)
+	if (argc)
+		if (kstrtoint(argv[1], 0, &skip_entries))
 			skip_entries = 0;
-	}
 
 	if (argc == 2) {
-		cpu_file = simple_strtol(argv[2], &cp, 0);
-		if (*cp || cpu_file >= NR_CPUS || cpu_file < 0 ||
-		    !cpu_online(cpu_file))
+		err = kstrtol(argv[2], 0, &cpu_file);
+		if (err || cpu_file >= NR_CPUS || cpu_file < 0 ||
+				!cpu_online(cpu_file))
 			return KDB_BADINT;
 	} else {
 		cpu_file = RING_BUFFER_ALL_CPUS;
-- 
2.25.1