Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <65fae3db40ada9a2bc3d1333f27d9a4f4db6ac72.camel@linux.ibm.com>
Subject: Re: [PATCH] misc: ocxl: link: Remove unnecessary (void*) conversions
From:   Andrew Donnellan <ajd@linux.ibm.com>
To:     Li zeming <zeming@nfschina.com>, fbarrat@linux.ibm.com,
        arnd@arndb.de, gregkh@linuxfoundation.org
Cc:     linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Date:   Mon, 20 Nov 2023 15:12:46 +1100
In-Reply-To: <20231113014533.11064-1-zeming@nfschina.com>
References: <20231113014533.11064-1-zeming@nfschina.com>
Autocrypt: addr=ajd@linux.ibm.com; prefer-encrypt=mutual;
 keydata=mDMEZPaWfhYJKwYBBAHaRw8BAQdAAuMUoxVRwqphnsFua1W+WBz6I2cIn0+Ox4YypJSdBJ+0MEFuZHJldyBEb25uZWxsYW4gKElCTSBzdHVmZikgPGFqZEBsaW51eC5pYm0uY29tPoiTBBMWCgA7FiEE01kE3s9shZVYLX1Aj1Qx8QRYRqAFAmT2ln4CGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQj1Qx8QRYRqAdswD8DhIh4trRQYiPe+7LaM7q+0+Thz+CwUJCW3UFOf0SEO0BAPNdsi7aVV+4Oah6nYzqzH5Zbs4Tz5RY+Vsf+DD/EzUKuDgEZPaWfhIKKwYBBAGXVQEFAQEHQLN9moJRqN8Zop/kcyIjga+2qzLoVaNAL6+4diGnlr1xAwEIB4h4BBgWCgAgFiEE01kE3s9shZVYLX1Aj1Qx8QRYRqAFAmT2ln4CGwwACgkQj1Qx8QRYRqCYkwD/W+gIP9kITfU4wnLtueFUThxA0T/LF49M7k31Qb8rPCwBALeEYAlX648lzjSA07pJB68Jt39FuUno444dSVmhYtoH
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.1 (3.50.1-1.fc39) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2023-11-13 at 09:45 +0800, Li zeming wrote:
> The link pointer does not need to cast the type.
>=20
> Signed-off-by: Li zeming <zeming@nfschina.com>

Acked-by: Andrew Donnellan <ajd@linux.ibm.com>

> ---
> =C2=A0drivers/misc/ocxl/link.c | 14 +++++++-------
> =C2=A01 file changed, 7 insertions(+), 7 deletions(-)
>=20
> diff --git a/drivers/misc/ocxl/link.c b/drivers/misc/ocxl/link.c
> index c06c699c0e7b1..03402203cacdb 100644
> --- a/drivers/misc/ocxl/link.c
> +++ b/drivers/misc/ocxl/link.c
> @@ -188,7 +188,7 @@ static void xsl_fault_handler_bh(struct
> work_struct *fault_work)
> =C2=A0
> =C2=A0static irqreturn_t xsl_fault_handler(int irq, void *data)
> =C2=A0{
> -	struct ocxl_link *link =3D (struct ocxl_link *) data;
> +	struct ocxl_link *link =3D data;
> =C2=A0	struct spa *spa =3D link->spa;
> =C2=A0	u64 dsisr, dar, pe_handle;
> =C2=A0	struct pe_data *pe_data;
> @@ -483,7 +483,7 @@ static void release_xsl(struct kref *ref)
> =C2=A0
> =C2=A0void ocxl_link_release(struct pci_dev *dev, void *link_handle)
> =C2=A0{
> -	struct ocxl_link *link =3D (struct ocxl_link *) link_handle;
> +	struct ocxl_link *link =3D link_handle;
> =C2=A0
> =C2=A0	mutex_lock(&links_list_lock);
> =C2=A0	kref_put(&link->ref, release_xsl);
> @@ -540,7 +540,7 @@ int ocxl_link_add_pe(void *link_handle, int
> pasid, u32 pidr, u32 tidr,
> =C2=A0		void (*xsl_err_cb)(void *data, u64 addr, u64 dsisr),
> =C2=A0		void *xsl_err_data)
> =C2=A0{
> -	struct ocxl_link *link =3D (struct ocxl_link *) link_handle;
> +	struct ocxl_link *link =3D link_handle;
> =C2=A0	struct spa *spa =3D link->spa;
> =C2=A0	struct ocxl_process_element *pe;
> =C2=A0	int pe_handle, rc =3D 0;
> @@ -630,7 +630,7 @@ EXPORT_SYMBOL_GPL(ocxl_link_add_pe);
> =C2=A0
> =C2=A0int ocxl_link_update_pe(void *link_handle, int pasid, __u16 tid)
> =C2=A0{
> -	struct ocxl_link *link =3D (struct ocxl_link *) link_handle;
> +	struct ocxl_link *link =3D link_handle;
> =C2=A0	struct spa *spa =3D link->spa;
> =C2=A0	struct ocxl_process_element *pe;
> =C2=A0	int pe_handle, rc;
> @@ -666,7 +666,7 @@ int ocxl_link_update_pe(void *link_handle, int
> pasid, __u16 tid)
> =C2=A0
> =C2=A0int ocxl_link_remove_pe(void *link_handle, int pasid)
> =C2=A0{
> -	struct ocxl_link *link =3D (struct ocxl_link *) link_handle;
> +	struct ocxl_link *link =3D link_handle;
> =C2=A0	struct spa *spa =3D link->spa;
> =C2=A0	struct ocxl_process_element *pe;
> =C2=A0	struct pe_data *pe_data;
> @@ -752,7 +752,7 @@ EXPORT_SYMBOL_GPL(ocxl_link_remove_pe);
> =C2=A0
> =C2=A0int ocxl_link_irq_alloc(void *link_handle, int *hw_irq)
> =C2=A0{
> -	struct ocxl_link *link =3D (struct ocxl_link *) link_handle;
> +	struct ocxl_link *link =3D link_handle;
> =C2=A0	int irq;
> =C2=A0
> =C2=A0	if (atomic_dec_if_positive(&link->irq_available) < 0)
> @@ -771,7 +771,7 @@ EXPORT_SYMBOL_GPL(ocxl_link_irq_alloc);
> =C2=A0
> =C2=A0void ocxl_link_free_irq(void *link_handle, int hw_irq)
> =C2=A0{
> -	struct ocxl_link *link =3D (struct ocxl_link *) link_handle;
> +	struct ocxl_link *link =3D link_handle;
> =C2=A0
> =C2=A0	xive_native_free_irq(hw_irq);
> =C2=A0	atomic_inc(&link->irq_available);

--=20
Andrew Donnellan    OzLabs, ADL Canberra
ajd@linux.ibm.com   IBM Australia Limited