Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <874jhh2g8s.wl-kuninori.morimoto.gx@renesas.com>
From:   Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To:     Daniel Baluta <daniel.baluta@oss.nxp.com>
Cc:     broonie@kernel.org, daniel.baluta@gmail.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        iuliana.prodan@nxp.com, shengjiu.wang@nxp.com
Subject: Re: [RFC PATCH] ASoC: simple-card: Use dai_id from node description
In-Reply-To: <20231117163900.766996-1-daniel.baluta@oss.nxp.com>
References: <20231117163900.766996-1-daniel.baluta@oss.nxp.com>
User-Agent: Wanderlust/2.15.9 Emacs/27.1 Mule/6.0
Content-Type: text/plain; charset=US-ASCII
Date:   Mon, 20 Nov 2023 04:36:20 +0000
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JwsYedNYMCyroSdzkTYQsBSDyJ3RgSGdQXd92kQqamW54YcxlzfRzPSST8kY?=
 =?us-ascii?Q?zuSULLtDaFCgQriTa1MbVwdwSFuOVlb3VJM/VVUhYGjLi1cRgv+CTHvqHyAC?=
 =?us-ascii?Q?5m/Ym+s0TGU3g27tyUuC0DacXeNhPaeZE7/KKDhHaD+1RIJOyzcQy8gu+fTk?=
 =?us-ascii?Q?AxWA+F/LqryGwOtfhGoflktKU0av82aEcmDQMCH5POu/K8zUBZ1aXjRN011C?=
 =?us-ascii?Q?7DYcKjB7A+DHj59JvSNHhzZ+B4ENC8/zOAAU6P3ws9x0ix9vmWB9PEV5z0yX?=
 =?us-ascii?Q?aHxPYofvqLpSLb2epvtqS4JvsjzEbvQDXiWnFAwaROb9NGZlPMlEIZ3liuj8?=
 =?us-ascii?Q?uIfhIp7xRwTJu6qpLUAxyciVUcid3QIWMRMf97zrXhE4lHQdscdTBADnkLMA?=
 =?us-ascii?Q?thonw+5NFsET0m4oRggrD0aijxUUhMkNTQy429OsB+xbGuj6CV6uAVqgpPLQ?=
 =?us-ascii?Q?XTdblkVtz4DRYN5KS5JQ2i8OCO8s55XQSVSu7+oj/7Z7KjKhPu+VsmGKueOR?=
 =?us-ascii?Q?Ko/JSpYsvhlY7fLsu/VnKKIHq7h4muvvn8AnIzcc/oefPahXaypD6PvBvLCO?=
 =?us-ascii?Q?fkuDPjRU0ryQnvZk+KkhvC2Wo/nOzsMvEnnSXQ5isORDP1Ef88AwlcpnAUpI?=
 =?us-ascii?Q?N39St8QfXpaEPApOae/KS9lW/k50NQqk6A4aW1E7zWb2qbd82nsL67GathNq?=
 =?us-ascii?Q?AX+jfu7n0o9mjc90LUZBJPm/vnccmjT+qays0qqFQW0D/+vBtYxT1ApMiux7?=
 =?us-ascii?Q?WfTjMKnzxWvspq4TMi+EiHzOhmyebsQ+52qYKSoNyb5cVZWi8/jx96Hblkqo?=
 =?us-ascii?Q?ObUySbLKDgKi7XqZf/AzzaAhdJeRdCo2xg8sLa7FZuWoYmz32dim3cHfWyQl?=
 =?us-ascii?Q?HyGWcxqnAFjjFZFaTId/oXdrS5YILRAlK+xF2spWmwMgE66zZ/gnMzJUCu/5?=
 =?us-ascii?Q?0w53mtpeCudpBYAFetdg1z4PvqjvN2B9TolKstCdtswtpf3cYYWp4w3sz8jW?=
 =?us-ascii?Q?YBITyvbGBfzi7PSqkEmd+Y3BvZCuA0eG5in7D/55je921mF2Wt6O7/I7fR6v?=
 =?us-ascii?Q?BGws6fKVB8/JzUUKha46xKa0sdlCshiM3/h/PQ++xe/inzz77D7fJIJsel7u?=
 =?us-ascii?Q?EVNWDqLTWoUFVFZhxPZCXCuU+D3m1oaQjhQIGrgjdxIXC82iKwBCOOOswO4T?=
 =?us-ascii?Q?jzBjB8qWvYJcYhPZ0A8TZuCCpEjk8AluA9WTTgaNqgUFLabtaWNE+fHGzeaC?=
 =?us-ascii?Q?J9pml0ysg+Obnik26ZzjEmfQE2YnGr6P263pAT5dOAQ50lawGuRdNp9FpDcT?=
 =?us-ascii?Q?9G49BFtCc9x6HufsATzQwbtpXhdY8ilRu5ai1u/g+LIiu65+lgpZrD18Tvvc?=
 =?us-ascii?Q?UKO2CkgpFjmBAR5WCzZThb6oDWorV//rjOO67IwxQdkiTG4MYCfTISXNK2nu?=
 =?us-ascii?Q?Oqw8P13OwScUtYMOM03OOyKacXYpu3rLmkDGQKeBzSlH5PIRdx4ji9xHWVNf?=
 =?us-ascii?Q?Bd3VG5MPXyt177djUji+i5cO6RUsHGBlvdEOLPYJl4EYdUfwKO6DK66NUaTY?=
 =?us-ascii?Q?yG11mpl0G2BtWmugE0PBZtTB+OADrxtLW86OF7Zmo3eVV9qwTXmmFVfBVtgx?=
 =?us-ascii?Q?BWquLts4R5nqIUrSZek04+E=3D?=
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 771ef9e5-6f6f-4b11-5a57-08dbe9823e2e
X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB10914.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2023 04:36:20.2718
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /VWRE4meupIicca34oxfzz/+y4jAuDkkO/VDCZMjEepfor6u6jTuqfmqnNCxLS357lGp5ut4sHLYOybY1Bsgzon9B0ZeQ+ivhBlWusdoqVMz/pywnAdR/FPy7Sw4/Ptm
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OS3PR01MB10374
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sun, 19 Nov 2023 20:36:33 -0800 (PST)


Hi Daniel, Mark

> We can specify DAI id using reg property. When dts
> node has only 1 DAI simple-card always assumes that DAI id is 0.
> 
> But this is not correct in the case of SOF for example which adds DAIs
> staticaly (See definition of snd_soc_dai_driver in sound/soc/sof/imx/imx8m.c)
(snip)
> -	args.args_count	= (of_graph_get_endpoint_count(node) > 1);
> +	args.args_count	= (of_graph_get_endpoint_count(node) >= 1);

If my understanding was correct, for example you want to use 2nd DAI
but your DT has only 1 port (thus, it is using reg property) ?

Current simple utils is assuming (1) DT has all DAI settings, (2) having
reg property is option.

But current DT requests reg property.
So maybe it is good time to remove non-reg-property support ?


Thank you for your help !!

Best regards
---
Kuninori Morimoto