Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Mon, 20 Nov 2023 09:04:36 +0200
From:   Louis Peens <louis.peens@corigine.com>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     Denis Arefev <arefev@swemel.ru>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, oss-drivers@corigine.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        lvc-project@linuxtesting.org
Subject: Re: [PATCH] nfp: flower: Added pointer check and continue.
Message-ID: <ZVsFBACC05VrrCfw@LouisNoVo>
References: <20231117125701.58927-1-arefev@swemel.ru>
 <ZVd4RYURdHLL+F2h@LouisNoVo>
 <20231118202207.16a60834@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231118202207.16a60834@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ecQplg93IAUxxFi5uMOZ16gQ4sCzFd/ATtZOdGDGKZD1ErgjYMqw/PHYqw9I?=
 =?us-ascii?Q?Kmisd9XHUwMDtYl9VKjYQHE8u0UGd+oObFy9ctfF511yIsjiIqBEZgvauEFS?=
 =?us-ascii?Q?s3SA66BeQl49GDoNoP2BT4+cZLn6sgJ+4eKadJhu37v7coRmVtLxtVAlL6cZ?=
 =?us-ascii?Q?mzkE5nsbifDR3bWko0zNGjJ3FqIVUyj1YAvkIQqrEE50DzFHFxDiV/2P8UTK?=
 =?us-ascii?Q?eYlyIkcKRurBWdDe3AxH7vhckSgEWZkLeJqyGELbBnWPBFUgL+V0Xeire2wz?=
 =?us-ascii?Q?zi7gWDakm+xreXIQYzZtnoACQr3HOchZ3u2wJJcL5lQjlteQR7dVFJvpPWKj?=
 =?us-ascii?Q?N9nCO6rE9BPPLLNm0OHEMWXFmJybUEbnz3o3Vc2gJFn+JA1kR9MwMB3I0BcQ?=
 =?us-ascii?Q?s81HXA6zkY/iwlRXB9fzrN7Mb9skUGP1QjWELTI8Fo9hLob9k5m1ifAyqGsz?=
 =?us-ascii?Q?x5Mnjsto3YFbE4gwz4whT6IKbRhGByCvoZESDs/4vFMxU3N8aT1qmBD22NN5?=
 =?us-ascii?Q?Np3dVi9rBphUDqmkPZw9qru59YUD/ww//IWrYvflpjmPyjTGn1jAIT3tRDXf?=
 =?us-ascii?Q?Wleif2UMQ4Yjqtk1T9qrFkWVp468pO7XhjodI41/gfULke95tjR82pEG+1Sf?=
 =?us-ascii?Q?t96SUDKS4mrB7+fpzKTcqwU9/gkkbzfwoiKEZppn1P/czmvcODooAtX8dIer?=
 =?us-ascii?Q?P7dkEuuU/VdsR7NrPSru2nn4MAgn4hCXhqowNPhqL766k87WJbK0uFjQEDvU?=
 =?us-ascii?Q?GgxNwGE4oJznKYWZa33RD8jBAy+NM+wDE2WoUc+xQUoS0khcXr/Sd6XlyEQf?=
 =?us-ascii?Q?enoUwsKKOYnHTqIBKn65S0p5dYkKRISaGPISx8QSC//YAZ0z3DklccQ4+zg1?=
 =?us-ascii?Q?vZUz+Y+b30/Hf7AwzYtpzYQk+7cs3WrByujC9q7razWLW/PAZQ8Kbrx/eGpY?=
 =?us-ascii?Q?M4VUYUgcLjJOz9uf6fkJ7mQVl9TCFBQZ9emc7MRffD/7eOmqfVG2Kd6pgKLI?=
 =?us-ascii?Q?4v57aMXX8HIT5MejcCzeGb5B1ml0fuPBSnQrDZl6kx/ZE3xOd8t9xkT77z7q?=
 =?us-ascii?Q?KladzOxT2nkzte8N+paiMe/Qz1pMZT8cdMsaeAA94eEzpO+uMaLGqHSL5ThY?=
 =?us-ascii?Q?yF3rYjgFmKc5gZWDB1TN2qQhMWNJmNuOJ3/LmwJ8ufJ3hUHQp2K7vz4whby8?=
 =?us-ascii?Q?F7g6MDpqKwV/OCyA/6iFUlfXwBajKYCCxUAc/lBIR1e9QjDMnama6ZoA6Ro+?=
 =?us-ascii?Q?cyYMJKww51ooY44P89Ut0iXiU5kjS5ZIx02ZKgA0pzmljhlercy4BuhgKAA0?=
 =?us-ascii?Q?KFmKotbBZntkFCnVJHmJY/2VihLsRLWxHal7ZKSXfWO6aqJO4khSk1p/6YVB?=
 =?us-ascii?Q?YtwREQ9aLBE6VTe/KwWyTL+BrTuXHNm9WK8cB4UBTigJGHS3vbX9xEOacy4a?=
 =?us-ascii?Q?6/iO7s0vB/gp3mH/FijZxWU/h4cPFEMjAxxa00VXivXUDY/i4aRegTqBV8w5?=
 =?us-ascii?Q?y+8FKKS0m1w7RrJ7iFdX1rpXfdxGFYi7X9RbvGLKiHtUyt8np28wRyITPPv0?=
 =?us-ascii?Q?CbWLB5qPp3nZzA/vn7fnLmgrusQ7JBm/F1CuqMY/5bd3VA5d7WAT2AjeceFI?=
 =?us-ascii?Q?Xg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 64bf7e51-73c7-4269-bcbd-08dbe996ff40
X-MS-Exchange-CrossTenant-AuthSource: CH2PR13MB4411.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2023 07:04:54.1127
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FjTDNa+FMjYZHNE07hBM/ZTw8ZM9v2MIGECbP+cCKqRyHmYsA2j28ZzOZU0oYXyBtNNMcoaoD6IbMb83O45ft3SFNCHaFwondhN7RCg2t/I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR13MB5915
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sun, 19 Nov 2023 23:05:10 -0800 (PST)

On Sat, Nov 18, 2023 at 08:22:07PM -0800, Jakub Kicinski wrote:
> On Fri, 17 Nov 2023 16:27:17 +0200 Louis Peens wrote:
> > >                 acti_netdevs = kmalloc_array(entry->slave_cnt,
> > >                                              sizeof(*acti_netdevs), GFP_KERNEL);
> > > 
> 
> Unnecessary new line, please remove it.
> There should be no empty lines between call and error check.
> 
> > > +               if (!acti_netdevs) {
> > > +                       schedule_delayed_work(&lag->work, NFP_FL_LAG_DELAY);
> > > +                       continue;
> > > +               }
> > > +  
> > Thanks for reporting this Denis, it definitely seems to be an oversight.
> > Would you mind adding a 'nfp_flower_cmsg_warn' here as well, so that
> > this case does not go undetected? Maybe something like "cannot
> > allocate memory for group processing" can work.
> 
> There's a checkpatch check against printing warnings on allocation
> failures. Kernel will complain loudly on OOM, anyway, there's no need
> for a local print.
Ah, thanks Jakub, I did not know that this is frowned upon. But I have
not thought about OOM - it would indeed not be a silent failure.

In that case I would be quite happy to add my Ack to v2 with the newline
comment addressed.
> -- 
> pw-bot: cr