Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Mon, 20 Nov 2023 15:14:37 +0800
From:   Yujie Liu <yujie.liu@intel.com>
To:     Linus Walleij <linus.walleij@linaro.org>,
        Kees Cook <keescook@chromium.org>
CC:     kernel test robot <lkp@intel.com>, <oe-kbuild-all@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>
Subject: Re: arch/arm/kernel/hibernate.c:29:40: warning: array subscript -1
 is outside array bounds of 'const void[2147483647]'
Message-ID: <ZVsHXZCZOKiPGOgD@yujie-X299>
References: <202310182007.8ziiRe0j-lkp@intel.com>
 <CACRpkdaB390mn2s3vrVAhaY9Portxdzc8bVkM5F3DtVy-k-r2Q@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CACRpkdaB390mn2s3vrVAhaY9Portxdzc8bVkM5F3DtVy-k-r2Q@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHc0dk83ZDhRRVBLZWtXb0lJaHB1ZnN3Zk9lRlNrS1MzSTlRWVRuRHlCdmxk?=
 =?utf-8?B?NDQyQjYwYmZ5d0xnOXNvT2t4MkFLamhDTi8rRWlET0kzVVJyY3JYRGZTVjhC?=
 =?utf-8?B?Vmx6L05WRmxhdXVsd2lVNEpnYUhWY0xPTXZEKzM3TnBrTlhQQTcxb2xyVXVh?=
 =?utf-8?B?UlhPVlRzdkJSRFhiMVlGTWRzcVA2dUYraVRJcHVvOUtrOW94WnNlaWViVGlY?=
 =?utf-8?B?bGg5Vm9kVnA2OVVITlNtK0JCNFFBOUJFY0VVZHc3N2tiZU12aXJkSnU3QXM4?=
 =?utf-8?B?V0xLK3VlYVpvSC84OVE4R0JQOUxXYUVGZWRrNm9ER2o4blJFaW90QkJtWjQr?=
 =?utf-8?B?eW1xTGpscmxCRHRaemF6TFJPaWZQUDVUdnAzVmZuS1F5Qnp0QjM3SWZWdHdV?=
 =?utf-8?B?TktEMWJBZFFJelhVY05oUytubzErclVkOXhacGxxZStLQWFTalcwMU90NExy?=
 =?utf-8?B?enRmcExHZjlYWmx2SVpJNmdQTDlTaERDalhMcEFqU1Z5UHllckxsdXlNWHdQ?=
 =?utf-8?B?UE9tWVNnb21vS0lmREFwK0xaQ0lMa0xpcGloUjM5S2VOQ0ZsMjc2YWNWc21T?=
 =?utf-8?B?QUVnalBpeGFLYjY1N0ZPaEs4d1J0ZzhpTjR0VmZZZFBRMDhseWxlQWtOTk4r?=
 =?utf-8?B?ZmppTmh4VGJTaHArMk5jOS9QeDMwZkFMQ2h0VmptSnpUd3hDdjRFZFFyUWZZ?=
 =?utf-8?B?eFJNOFRqNkNaeWhza1VsODZuMmZEaEZ2TFBxdVVwMDBHVis2ZkNSL0NuZjN2?=
 =?utf-8?B?cVZadnBSdFBFUGVNZVJhT3JrZUNOTWpJam9DLy9DQVRxTE5GMEVJbE94YWhM?=
 =?utf-8?B?VmFzb01CWVY0emh2TGFOQXBxa2tLUE9HYWxtQThONm1wNVBvTGhaWWZLSmVv?=
 =?utf-8?B?S1Z6bWdzQVRqVHJHTmZGYzl6ZmxkV3hlZzI0eFBxNnhVOEdTcjlibm1ycFpm?=
 =?utf-8?B?WW1FUStCazNXYVRubEFOSGsxNjdHSU14YUxCUGY5UkI2TCtYemFna2xiUlo2?=
 =?utf-8?B?bVdNNVlmOExXVXh5Z2FZOGJkbk9xd3JNODF6d2tCMWNKN2FyWVdpQlcvZi85?=
 =?utf-8?B?YUJjQ3RpYmlhM3VxalZOZEtVVVJKQklrc24zTnJzQTFkRk5KbXdJNjJsa0pN?=
 =?utf-8?B?MEJXRkxtMEozaEZ0dEQ5eks4MFkySHRQeVlwSjFYdVVuWFFROCs2RzVKcDY3?=
 =?utf-8?B?UjR2Ujd1Ni9KQmRFK2R6MzFpQTBZU1FNaW1UU3FnUXVET3pDMmxVdjZoTWV0?=
 =?utf-8?B?MFdkckxPeXVvZDBPOXpLVUl4OEFTZXpsNWczTWN3aVRCeXFFQ1VyQ1ZWU2dR?=
 =?utf-8?B?MlZtdHcyTlZVU2IvRnZXZStLallsUHNGY04xMUVkdU9YdVN1M0NGd2NpclFP?=
 =?utf-8?B?dDgxMWY5NnhXeWVlUFgxYm9hUGo4Si9uNDc1UjBzT2JSTDFPSk1iK2Rha0NL?=
 =?utf-8?B?cWNrc2wzMTlEbHQ2bEJYZHpBWEtPemxQeTFTYzNtUDhTTElvNkdrVy95aWE4?=
 =?utf-8?B?ZlpVdlZPSTI5UUtCUUxIUk4wVUdKeHFSdXBwZWk4VGwzRjViN1gybk1NZkh0?=
 =?utf-8?B?QmFMK1NIVTVZbDZSWE1UVXRsRkcxcnNibFZFdVFZRzBqSW9VaDR3YjN0UDAy?=
 =?utf-8?B?Um5MRmFEcmZXV3BXQkJvOEdrUDN1OGU0TVpYSmpxUURlS0pONXRnUHNSUGI0?=
 =?utf-8?B?Sm9FODNyMnY0bGxRU1g4R1F6VGQxazZBZnZVWTl2dUFOajd1L3R1ZUdEa2ps?=
 =?utf-8?B?VVdOMCthdUtZb2xIUzgrd2JoaEMxM2JUQnlVY1BPWFNJN2tWT3M0MVZZTEhR?=
 =?utf-8?B?QlBTWjVqZGtLYnRCMGUxVlo1Y2VuQmdKU3ZtYzEraXpyUndrdTFhQmgrMHYx?=
 =?utf-8?B?bmZWeEJTYVUvSjE2cmFZc0pISGt1N3FlK1VRblZpUm1kQ3dxcmxEaXFPaStQ?=
 =?utf-8?B?WHMrQytzbnRtQlB1QnV5QitQc0VMOFJ4cUViZEhFenc5U0l6Z2hrVnYxYzBo?=
 =?utf-8?B?YnZpcE1JNEgwQTVhNlVLRHkwYXVYTEZBVjJEMGFqbGo0WStFd2VUa085Z0I2?=
 =?utf-8?B?MUpVRndqakdWOWZacTg5WUpFOGtoMWpkM3lZVUJVRGJXMlpaZDM3UEtBSkRI?=
 =?utf-8?Q?iDqLF+TZgmpn7XrVB6F9AnAMX?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 87e1afe5-2db9-4133-d8ee-08dbe999012d
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6392.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2023 07:19:16.3289
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s37Ndwjtmn+DfYPKFaXhz5jwvN7hEq4AbuLyOdiyR9oHgZhcA/zRubk/SbR/irwwicICRxa78CLhE6RBoyhIqw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6260
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Sun, 19 Nov 2023 23:19:41 -0800 (PST)

On Mon, Nov 06, 2023 at 02:19:33PM +0100, Linus Walleij wrote:
> Hi Robot,
> 
> On Wed, Oct 18, 2023 at 2:17 PM kernel test robot <lkp@intel.com> wrote:
> 
> >    arch/arm/kernel/hibernate.c: In function 'pfn_is_nosave':
> > >> arch/arm/kernel/hibernate.c:29:40: warning: array subscript -1 is outside array bounds of 'const void[2147483647]' [-Warray-bounds=]
> >       29 |         unsigned long nosave_end_pfn = virt_to_pfn(&__nosave_end - 1);
> >          |                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> So the concern is that &__nosave_end  could be 0 and the -1 would make
> it wrap around?
> 
> It still has nothing to do with arrays, I don't get it.

Hi Linus Walleij, sorry that we couldn't explain this warning very
clearly. Let's consult Kees for more input.

Hi Kees, our robot has sent out several reports of "-Warray-bounds"
warnings. Thanks a lot for helping to analyze them. [1][2]

[1] https://lore.kernel.org/all/202309200904.CEED70DA33@keescook/
[2] https://lore.kernel.org/all/202311071521.099CAEA58@keescook/

As for some other reports, developers have some doubt about them that we
are not sure how to explain, such as the one in this report and
[3][4][5][6]. If it's not too much trouble, could you please help take a
look to see if these are valid warnings or false positives? Thanks a lot.

[3] https://lore.kernel.org/oe-kbuild-all/CACRpkdZ-1OcZ-cz0V218-VxAc07DMPvKWee3MHngs6Hrwv4zPA@mail.gmail.com/
[4] https://lore.kernel.org/oe-kbuild-all/20231019092258.c2cbwmmgffa33bro@vireshk-i7/
[5] https://lore.kernel.org/oe-kbuild-all/CANn89iKdMVNrV_0QienhpCJ98D7hj2sqOOYFhhSHBVHzvtkgWQ@mail.gmail.com/
[6] https://lore.kernel.org/oe-kbuild-all/CAOQ4uxjTv+5cB4z8TZQ02c5F3rags1HARoEQG9834A0+_+_twA@mail.gmail.com/

Best Regards,
Yujie