Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp2051782rdb; Sun, 19 Nov 2023 23:46:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IGOoejbJJ1LAiNz0a0yxoWo9YK/LzBB+DlS828wgWLQm+0vcwxvB5NYpZyL/JF4pqAWDC1w X-Received: by 2002:a17:902:f68a:b0:1cf:677d:964d with SMTP id l10-20020a170902f68a00b001cf677d964dmr175519plg.25.1700466363270; Sun, 19 Nov 2023 23:46:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700466363; cv=none; d=google.com; s=arc-20160816; b=aVA1dvUzcEob3JtZ7GdslowYLxuJ6NmsnNJdLq/yDuAm51WpJP3BLIieVauWZh78iD 9R1MncnjVu8EWyYZ2zan3GWhk6rWHEuUymPaM4uy+1YtMkgvG4sA2DY7paXVG9mBsa89 7yFgHPw4kPumARDByiXPeI4klT2KuZRiyETYN1GyERPMMmW1dwGn3I7FmbG297BF29uS 3JkO+ea9blAU+2e9ogq98F72fWlRX6i/b/WcInWGFUZLLa3uJAv7q+3St75hWGNP99VL NfLF68zX664vFQ1i6dJmq2iZeuVxRMF12A/sREcy8dzy08WtEj7u2+z34AmaZbhej+UE qqQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id; bh=9iPG+meBGpkxceVS3F6vB/et8ulW4BgxlRlyOQXry5Q=; fh=cMxvAA54vo1UIp57LlUFBpiOLSu9WHexdK+2dehgsVc=; b=F4txQZtnTBkp2kP9IzSKVrcFUj3ORiLYjXNupwm1UK8UBa+FLLUPNsXDlqEf4lDhul juQnyALArwHlcf6ArRItSbw86+PEBTGREI13SqHgwQciHVpWM0iVu8NHOeXMWwxEBk6U XvBtf5bqzW/4R55wr+7QStYA+pgiCqqD20WzQLtUIa46mE/SoR6Jr/gMsFBRMZO7GxYK WADGiQ5Sk/ESMfOtGJz9LzG062ftcs+ZUN0P/B97rz4frZUbAGlEsRKoINzL0O0uNztk FgT6iA0Ng/4lJeZ8H1JpbJA+XKDhrh+kY6vC8htruJPB9/iKq/GYrL0wtFE4HZpBzL3H UNHA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id u12-20020a170903124c00b001c732b6869csi7995466plh.63.2023.11.19.23.46.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Nov 2023 23:46:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 3D4C18092151; Sun, 19 Nov 2023 23:45:53 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231961AbjKTHpp (ORCPT + 99 others); Mon, 20 Nov 2023 02:45:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229483AbjKTHpo (ORCPT ); Mon, 20 Nov 2023 02:45:44 -0500 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C962FB4; Sun, 19 Nov 2023 23:45:40 -0800 (PST) Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-40806e4106dso8115265e9.1; Sun, 19 Nov 2023 23:45:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700466339; x=1701071139; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9iPG+meBGpkxceVS3F6vB/et8ulW4BgxlRlyOQXry5Q=; b=nk/4fzzcs6GRrk/XPRfrR6RO0VFeVwZG292XikSrET4Ehw/PDnRG9h8j4zotN7+A7Q 7Hmjb5+4vnqNC/s6YcA13e3yb2YgKBvtt4wAAMJQQZ2EtSKKTTEfgKA9hW1lNsbwDY2/ WHfbqQ42FNtSgmqjDqMG42WgQee61n3vTMZXhBFtuf9VE/QVXrohGXwc7jRw+AudTL9F wzQDf8bHSkbDJ27q6nfLvxDFC/4sMJdcbgtj85ICQTUC5vAag7JHYin53Eyj0phBbnTo +thS4WvWaaORd8oqn6Ve3CO4BQq1v5qUjL40zzu/yJz1TfHZBxs83GF1Op2o3My+FmsV HSmQ== X-Gm-Message-State: AOJu0YxAx/bw4NvD7zbb6dNZb2bjmoTL8a9zBXg7g1nisHOY60+dooPe 6xEiA1LLNCoJnUBf4owzq4cAQ64EbyFiMReN X-Received: by 2002:a05:600c:1d18:b0:403:c70b:b688 with SMTP id l24-20020a05600c1d1800b00403c70bb688mr5163267wms.6.1700466338978; Sun, 19 Nov 2023 23:45:38 -0800 (PST) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:59? ([2a0b:e7c0:0:107::aaaa:59]) by smtp.gmail.com with ESMTPSA id r5-20020a05600c458500b003fefaf299b6sm12561119wmo.38.2023.11.19.23.45.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 Nov 2023 23:45:38 -0800 (PST) Message-ID: Date: Mon, 20 Nov 2023 08:45:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9] /proc/sysrq-trigger: accept multiple keys at once Content-Language: en-US To: Tomas Mudrunka Cc: corbet@lwn.net, gregkh@linuxfoundation.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, rdunlap@infradead.org References: <670993bf-a8ef-4561-8213-6a37d0598d83@kernel.org> <20231115103408.193561-1-tomas.mudrunka@gmail.com> From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: <20231115103408.193561-1-tomas.mudrunka@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Sun, 19 Nov 2023 23:45:53 -0800 (PST) On 15. 11. 23, 11:34, Tomas Mudrunka wrote: > Just for convenience. > This way we can do: > `echo _reisub > /proc/sysrq-trigger` > Instead of: > `for i in r e i s u b; do echo "$i" > /proc/sysrq-trigger; done;` > > This can be very useful when trying to execute sysrq combo remotely > or from userspace. When sending keys in multiple separate writes, > userspace can be killed before whole combo is completed. > Therefore putting all keys in single write is more robust approach. > > Signed-off-by: Tomas Mudrunka > --- > V8 -> V9: Fixed english bit more Please check my comments to v6 more carefully once again. Plus: > --- a/drivers/tty/sysrq.c > +++ b/drivers/tty/sysrq.c > @@ -1150,16 +1150,28 @@ EXPORT_SYMBOL(unregister_sysrq_key); > #ifdef CONFIG_PROC_FS > /* > * writing 'C' to /proc/sysrq-trigger is like sysrq-C > + * Normally only the first character written is processed. Normally, <-- comma > + * If first character is underscore, all characters are processed. the first an underscore Maybe it would make sense to prepend "However, " to this very sentence? thanks, -- js suse labs