Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     "Liu, Yi L" <yi.l.liu@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC:     "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
        "joao.m.martins@oracle.com" <joao.m.martins@oracle.com>,
        "Zeng, Xin" <xin.zeng@intel.com>,
        "Zhao, Yan Y" <yan.y.zhao@intel.com>
Subject: RE: [PATCH v7 1/3] iommufd: Add data structure for Intel VT-d stage-1
 cache invalidation
Thread-Topic: [PATCH v7 1/3] iommufd: Add data structure for Intel VT-d
 stage-1 cache invalidation
Thread-Index: AQHaGViOWXGe59nutU2rEx/0zRDvrrCC4vag
Date:   Mon, 20 Nov 2023 08:26:31 +0000
Message-ID: <BN9PR11MB52761D7A88BB2F655355A7728CB4A@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20231117131816.24359-1-yi.l.liu@intel.com>
 <20231117131816.24359-2-yi.l.liu@intel.com>
In-Reply-To: <20231117131816.24359-2-yi.l.liu@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bgIfpCEbEEmM5VI0Xcn8NBdl9S8FKh2bWd110T2lce4QNEKSFwehSNKBHz97?=
 =?us-ascii?Q?/my4pnEmZd3ySSudw7xOUuffqqJpTNFH/3X9UZsNomWPOPgpJJ6ttG0bpGNd?=
 =?us-ascii?Q?1XCCt+B14jl1JVxTsZ8xK4Y8/GON6qqVKuZACM7bdwd8fnjbg47i3GMLn3sG?=
 =?us-ascii?Q?uJeQyoc+spx5qLw2pMBBtjDtpz/ljOzHb0WEit7T9zg65mVFP0LDZUVJvG/I?=
 =?us-ascii?Q?ADCF4OByT7zl5YU5nJAchEexOKrWrEBFROquJQ4dSBGoFKljPvan5w43CxiI?=
 =?us-ascii?Q?GrdLvn7DdjjmqDjvEBzYJA6lWRpSgdYbs8TQezHyfbneebyDRuu9UckNQouV?=
 =?us-ascii?Q?g6ZdjAPa1ZQYZrlP0wljddcx4QVgJHjHZc2SimNpOPY4grPP02d5IylU5sw0?=
 =?us-ascii?Q?haDvtGnNi2/DKO7Xgyp1HH3jeiR472D6c2PUJRBjlLtWUyqLmRKIrtslWNlJ?=
 =?us-ascii?Q?JUKNYq1TRy594HAbKEPHlqPbtf+6RSS/IZ11o6ec92aZeD7qmFkVHXTpy2Gt?=
 =?us-ascii?Q?2DcPLDsYSTE0vzRHufdzzaj0OkG/nNtYtBuwAxu9qdq5Rxd1N8W3WuIst7YV?=
 =?us-ascii?Q?0dGgtTKwOW7WcN0Y/I12xavgEeK1i1xKG2cX/57KMKmoiyEICP0yo6M2le40?=
 =?us-ascii?Q?BiheMhQ2zYFajgToHUQyWawTaHAl/6cwyNSsP4j66Qq6MswFxDjzamYSKAkE?=
 =?us-ascii?Q?1tneuIOCmkJ5qqUNKJrfbO8YALSAg0l283jO16DV/52SrpYtjV2+twSljvcz?=
 =?us-ascii?Q?f3aoz9qS9G6rlvXuiBYB+8v5itGDb1iSYRoVdii6fdZLvcZT84p7MCtiqCpt?=
 =?us-ascii?Q?c/gC28aUK/Hnkq72EUIymjIUcNO3mNVtAmXmm6kdu8rsNG490W1nQWJERwL2?=
 =?us-ascii?Q?kKhiEIvBattu7jG3HHUkNdGLLC2pR+L8u7O1OrlLgeMfAlqzX7I35Ih8Ptu9?=
 =?us-ascii?Q?+Ms1KPK+8BpHmGCm40+BMEgSh1Cc3rjmRFV2INSeF5ut3yYuajQbTVR+olJv?=
 =?us-ascii?Q?zS1WqMktqr40vNWoiiyz79tctEj2XqLz+85bZMQb6diXoWL8kpTZpd2v7liL?=
 =?us-ascii?Q?5+MMlJ7G+A8YnBNMbhvbq5cJHk/VAD+w9bj1e4bw/L8/dB4TWaJLcJlYDCXt?=
 =?us-ascii?Q?evEn9p1dxmIK2+7Z5hfY8d7Gq+rHr4DCRDPNfW1t4GsKQp0TmMYWRhGFIsdg?=
 =?us-ascii?Q?jwZEKxotpo3DZX/avgFRA+qVoSAT12lPXsEjM5WPutz973O6X0HMPV3ZN7Ch?=
 =?us-ascii?Q?klB0PGZTv+PECCDM6eoFZAEuOyqEVbnO8BO/ic+EE34TAwYohzpl9Adf2zXR?=
 =?us-ascii?Q?Tlt0Sups/lWI+E829LZ/Pz+uh70h0wTwzq8ZQzpih/NSQyVPBQOxUAAYMF0s?=
 =?us-ascii?Q?Ykeg9BSIqBkEv3ftKY9Ps/Sq8rqGWhk1OCMLVIad77ae0TzxiIpRdJSEkwPH?=
 =?us-ascii?Q?FnlA5E3fLkUimOTlOictWYYJ0bKDQzvPG4Sa7Dj+Rlqsz2bq6VIx6oAgplgT?=
 =?us-ascii?Q?sF5DFsqK40hOYfc0Tvdsdccw//fw76kyy4U3R2j8BMLrSwTHCVmpzmlC4bAX?=
 =?us-ascii?Q?sRsLvMjhCzSsi0W5tBASpjIlMtfd+NgJRniT0IjD?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b261aa3a-b5c5-49f5-bf57-08dbe9a266a6
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Nov 2023 08:26:31.9143
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: cRNKul8qATZQkMuMdEgvObvNY63CQUBW0h/uoQn7F6nSY+9/8QWjgr9sLl3ZIsHyWcWp2SZ4DBvwQXCyVg6/Ww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5995
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 20 Nov 2023 00:26:51 -0800 (PST)

> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Friday, November 17, 2023 9:18 PM
>=20
> This adds the data structure for flushing iotlb for the nested domain
> allocated with IOMMU_HWPT_DATA_VTD_S1 type.
>=20
> This only supports invalidating IOTLB, but no for device-TLB as device-TL=
B
> invalidation will be covered automatically in the IOTLB invalidation if t=
he
> underlying IOMMU driver has enabled ATS for the affected device.

"no for device-TLB" is misleading. Here just say that cache invalidation
request applies to both IOTLB and device TLB (if ATS is enabled ...)

>=20
> +/**
> + * enum iommu_hwpt_vtd_s1_invalidate_flags - Flags for Intel VT-d
> + *                                           stage-1 cache invalidation
> + * @IOMMU_VTD_INV_FLAGS_LEAF: The LEAF flag indicates whether only
> the
> + *                            leaf PTE caching needs to be invalidated
> + *                            and other paging structure caches can be
> + *                            preserved.

remove the words after 'and'

> +
> +/**
> + * struct iommu_hwpt_vtd_s1_invalidate - Intel VT-d cache invalidation
> + *                                       (IOMMU_HWPT_DATA_VTD_S1)
> + * @addr: The start address of the addresses to be invalidated. It needs
> + *        to be 4KB aligned.

remove "of the addresses"

> + * @npages: Number of contiguous 4K pages to be invalidated.
> + * @flags: Combination of enum iommu_hwpt_vtd_s1_invalidate_flags
> + * @__reserved: Must be 0
> + *
> + * The Intel VT-d specific invalidation data for user-managed stage-1 ca=
che
> + * invalidation in nested translation. Userspace uses this structure to
> + * tell the impacted cache scope after modifying the stage-1 page table.
> + *
> + * Invalidating all the caches related to the page table by setting @add=
r
> + * to be 0 and @npages to be __aligned_u64(-1). This includes the
> + * corresponding device-TLB if ATS is enabled on the attached devices.

put words about device-TLB to last paragraph. Putting it here is confusing
as if it only applies to invalidate-all.