Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp2086759rdb; Mon, 20 Nov 2023 01:12:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IEyQibSEY804LyXqh0XS4alM6Bzy21GwpTztZZWf8LiMKC1pU53QdytDKxa/GB2aRC2K1yQ X-Received: by 2002:a05:6808:1598:b0:3a8:7f65:a94 with SMTP id t24-20020a056808159800b003a87f650a94mr9817928oiw.42.1700471562950; Mon, 20 Nov 2023 01:12:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700471562; cv=none; d=google.com; s=arc-20160816; b=xxYCY1m8jFPoMW8JYRZH75XCyEtnyIvFKUBszH7/kfRghgwQjPqix6s425Gaf/vq03 jJxMx8phqyqMV1AG7poz4W+hFfnEgshXVVIdpdkHS3sXSF4Of+NbFyqedg4iZnD26aEv IonWN0goQzO2VecA+xSqa7gGs2RtyWrdvCYLqBxsLHCy8435HN2TxbEWxVAH1P4wfbmg fKQlGlYLiXUd6FECiMP6yEG2/tc54SKtxjCaSFc/HKFt5a4Ai/z017+Nm312Jy95Alna bSIF5mHUO22+0XZsG0MTkAWI0GWcgLvlyCul2ww51Qe44mBeJdpLPBy/lhk4kAd7B8+b uSfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=dn+deSCqKxZiPD4ZYV6WLZxGoOy6UrgLLiD8g0+6MLA=; fh=hoVuLoyTYFRbY97yzhMJ3Hpx1hG+RYP9wd025aR1tgI=; b=RWsP94eki1ZyPBU2Nrm/RVjrwZrz+GtIbqm96gD7DeyssZoawSh+oSdHVNJCeoiGTW qNUMzMExCBNKGy6lODWFwH7XMNGbQAILrWL/5nMYy1Hz40P0BBYefCofqguIeS3Dbwq4 3B3XHJIFc5FXrBg6nfan7ZnD7Vx11aG6K6tUVTzfjZzeNPkXiT0K9ZIo+wzU8Z8iRFCM JVtbIswAI1PFUVnn3IbG+N+V8PaMQi0xtX6rJljh6v/2kZ/ybkaFOtWMRhACsvYwmlbE Zi4t3QI0hrsbwObt99HTrkgN4vAzPBImucvn3duBQSB84n92ZEJq5CX1oUZcuQ2qDyPE 44ow== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id y18-20020aa78f32000000b006cb4cf0e36asi5100058pfr.381.2023.11.20.01.12.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 01:12:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 25D8B805B04B; Mon, 20 Nov 2023 01:12:00 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232419AbjKTJLh (ORCPT + 99 others); Mon, 20 Nov 2023 04:11:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232138AbjKTJLc (ORCPT ); Mon, 20 Nov 2023 04:11:32 -0500 Received: from mail.nfschina.com (unknown [42.101.60.195]) by lindbergh.monkeyblade.net (Postfix) with SMTP id 08290A7; Mon, 20 Nov 2023 01:11:27 -0800 (PST) Received: from localhost.localdomain (unknown [180.167.10.98]) by mail.nfschina.com (Maildata Gateway V2.8.8) with ESMTPA id 74CA062960874; Mon, 20 Nov 2023 17:11:25 +0800 (CST) X-MD-Sfrom: suhui@nfschina.com X-MD-SrcIP: 180.167.10.98 From: Su Hui To: vincent.sunplus@gmail.com, vkoul@kernel.org, kishon@kernel.org Cc: Su Hui , linux-usb@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] phy: sunplus: return negative error code in sp_usb_phy_probe Date: Mon, 20 Nov 2023 17:10:47 +0800 Message-Id: <20231120091046.163781-1-suhui@nfschina.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 20 Nov 2023 01:12:00 -0800 (PST) devm_phy_create() return negative error code, 'ret' should be 'PTR_ERR(phy)' rather than '-PTR_ERR(phy)'. Fixes: 99d9ccd97385 ("phy: usb: Add USB2.0 phy driver for Sunplus SP7021") Signed-off-by: Su Hui --- drivers/phy/sunplus/phy-sunplus-usb2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/sunplus/phy-sunplus-usb2.c b/drivers/phy/sunplus/phy-sunplus-usb2.c index 0efe74ac9c6a..637a5fbae6d9 100644 --- a/drivers/phy/sunplus/phy-sunplus-usb2.c +++ b/drivers/phy/sunplus/phy-sunplus-usb2.c @@ -275,7 +275,7 @@ static int sp_usb_phy_probe(struct platform_device *pdev) phy = devm_phy_create(&pdev->dev, NULL, &sp_uphy_ops); if (IS_ERR(phy)) { - ret = -PTR_ERR(phy); + ret = PTR_ERR(phy); return ret; } -- 2.30.2