Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759059AbXK0PUk (ORCPT ); Tue, 27 Nov 2007 10:20:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756876AbXK0PUb (ORCPT ); Tue, 27 Nov 2007 10:20:31 -0500 Received: from ginger.cmf.nrl.navy.mil ([134.207.10.161]:63422 "EHLO ginger.cmf.nrl.navy.mil" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753480AbXK0PUa (ORCPT ); Tue, 27 Nov 2007 10:20:30 -0500 X-Greylist: delayed 2348 seconds by postgrey-1.27 at vger.kernel.org; Tue, 27 Nov 2007 10:20:30 EST Message-Id: <200711271440.lAREedEK011753@cmf.nrl.navy.mil> To: "Robert P. J. Day" cc: Joonwoo Park , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Reply-To: chas3@users.sourceforge.net Reply-To: chas3@users.sourceforge.net Subject: Re: [PATCH 4/4] atm/ambassador: kmalloc + memset conversion to kzalloc In-reply-to: Date: Tue, 27 Nov 2007 09:40:39 -0500 From: "chas williams - CONTRACTOR" X-Spam-Score: () hits=-1.7 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 903 Lines: 20 In message ,"Rober t P. J. Day" writes: >> > in any event, i just thought i'd point it out. if you're absolutely >> > sure there will never be another call to setup_dev() from somewhere >> > else, then, yes, it's safe. >> >> I understood your opinions. and partially agree with you. >> But isn't it a unfounded fear? > >i don't know, i just thought i'd mention it. if no one thinks it's an >issue, it's certainly fine with me. its very unlikely that setup_dev() is likely to be called from another code path. this patch looks fine to me. i will take it and get it submitted on the next merge. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/