Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <052cfc94-fba4-4d1a-9bc8-42d81c8cc1ad@theobroma-systems.com>
Date:   Mon, 20 Nov 2023 10:29:12 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/rockchip: lvds: do not print error message when
 deferring probe
To:     Fabio Estevam <festevam@gmail.com>,
        Quentin Schulz <foss+kernel@0leil.net>
Cc:     Sandy Huang <hjc@rock-chips.com>,
        =?UTF-8?Q?Heiko_St=C3=BCbner?= <heiko@sntech.de>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Mark Yao <markyao0591@gmail.com>,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org
References: <20231117-rk-lvds-defer-msg-v1-1-1e6894cf9a74@theobroma-systems.com>
 <CAOMZO5BVX3UmZ-45OphM6WDhz_ENkxm+Sr1dXkt4jR+Mmo-1Gg@mail.gmail.com>
Content-Language: en-US
From:   Quentin Schulz <quentin.schulz@theobroma-systems.com>
In-Reply-To: <CAOMZO5BVX3UmZ-45OphM6WDhz_ENkxm+Sr1dXkt4jR+Mmo-1Gg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VVFVamVYR3A3VVMxRnF6UDcrNG9VWUFLaGdKbkRJc2ZIbnBrRjZ6YnA0OXpV?=
 =?utf-8?B?MmZVQXlOSEwrNThIZmxKMHV3ZHFNaG9hSVRuSUNuOE5zOHppdlYrZFhwbXlN?=
 =?utf-8?B?MTlGV0tnUEcrV3FlWHNkVXFDQTJLTFZvSnNtYlE2bTZ1N0MyTWs0OVpqVHgw?=
 =?utf-8?B?RlYwODNwVjMvajVGL3doVWptNDRnZGcvUkt5dmVPZXpQeEFYV2pkWGh1SVdU?=
 =?utf-8?B?SkNMTVQ2aDYrLy81dzgxcFNpME1CQ3BLLy93dWpWN1M2dndnNE1qLzQ5Ky9S?=
 =?utf-8?B?QUxRYU9qVHJCOTRNcy9hSGpINVFPQ0I3T0JQZTU4cGFpTnNDMU5NQm81MWNx?=
 =?utf-8?B?QnRtMXN2enQ4Yjc5aFhTVFpad2o1U2l3OTNZNUlKcVAzN1BWTjEyRTZXb2hH?=
 =?utf-8?B?UDYrWHV2OGJsL1RidTdvbHcvNFVHd1hEN1VacmNnL29zUXBxTlRxWExOQVJo?=
 =?utf-8?B?UlN5REtnVjFaS1FlNXN4Z0JWWHpNSUlsNzBXUVVDTlowU3VvT0NtSkRzcFlW?=
 =?utf-8?B?VXcxS0c3Mmd3YWpPTVp3UkpmSXlXY0RUVW1DS3E4YVpkSXhNNU8xbjdXN3lL?=
 =?utf-8?B?cGgyTEJhREpJMUZWLzRjNmNJVjFYdE1RcU02bW1Tc0pPVFQ3K2FneW5HUzlX?=
 =?utf-8?B?Y0ltRzlyQ0FyT25Hai9xZC9IODBpa2hibFhQQWNMbkhTUEdkbmFFSjNaWVBI?=
 =?utf-8?B?MENRSVRpa2I2RXAvdFlJVVBMR3haVzd1N1pRN1dhT0d0WTV1YTVGaUJmaWc5?=
 =?utf-8?B?aExraFJrZ3B2MnVjbW9NazlNVjFIeldBajI1ZDQyUXdhQ1NwOTgveVJ5RlFI?=
 =?utf-8?B?SWJVV1RjMUtDc0NpZkdhVWs2cTFnSUV3akwzczFySDZmamw3eUdHY2RRZmZT?=
 =?utf-8?B?aTVKVThBK3djdTY5YkZLNjdEK2JtNnVjRjAzTVptWFRvenpuYzBkbTVLT011?=
 =?utf-8?B?TE1rNjNKd0pEeEtiSnNkTCtEQUFhVFpPVGFNa0VNektzVlFoNUJiUTB5QmRr?=
 =?utf-8?B?VUFVcWxHSnhVOUI1RzF5QmVYQUVIWU1IdHNlR29PNE1WTlZMYVNhMHJUNEVr?=
 =?utf-8?B?ajRKb0p6UlJrVytSZHBqUkhadlF3Ym9RUVBnL2VvVndxbXpKMVh6dlZPZk1k?=
 =?utf-8?B?bVVoNUM4U3ZUcFhNcGVIWXFPWWU2QjBlNDJlMDJ6aFNMVkU4aXlKdjIrVzVh?=
 =?utf-8?B?ajZTV2ZQbTdKVVRhdjh5enJGdmlreC9qVS9hZ1ZlQVMwLzlrQkJQbVNSaEFM?=
 =?utf-8?B?VTVTNUpCc2J5Q0VJZWFkN1VCQW5xMklEK1N2MmdIdi9CNlhxRWZMemVhUEpD?=
 =?utf-8?B?ZFRBUUk5alVtNHE2RFBWVU1lNDRaNi8wWDg5Ulg2emZnWUZUdGZBdFVxZXdX?=
 =?utf-8?B?NHNRT3NZN05Cb0lDVHl5UTQzQ29Yd1ovWCtzYXpvZHduL3Q5cTFCMEpCcmVu?=
 =?utf-8?B?OHRzTmNPVlFObmx2bTJtSmRHVFgySDVKWGZ1ckVqSzMxakVWSEJoRlNWR3RP?=
 =?utf-8?B?V3JXazE2MncvV1lYbVpPS09JTFBOK0o5RWF1SWxCNGhMNkVmQ0FyZkphTDVp?=
 =?utf-8?B?UThYbkVtRWhud3pBeVlqdDVvbkdOYzRPQmpQaVlabUxiZ2hodGxIT3ZvUDRE?=
 =?utf-8?B?NmRjejJVLzVaUU1STjhZZXd6QmQ0aGhvUU5xTkkzaHlZS1pQZ0l5OTBkYjhk?=
 =?utf-8?B?LzdleERra0VaRVVnaHlBbDUvSE9OeGViZ3ZUVWZCYTJiUGpWS1I1Y2ZYek9S?=
 =?utf-8?B?bVc3Y0JPSTNWVVJUdTVPcG10ZG45MjVwUjNITTV4dGtpcFV4U1R6RFc4VG52?=
 =?utf-8?B?YUsycEIwK2tCeFlrNFFpaDE3R2JzeFIrTWQvb0FlMlhSQTFIamRuRWpXY01v?=
 =?utf-8?B?ejdkSVR5OWhGQVBBSnRPMzZ3T2pSR2tyY1ZHU1BsQVJpYThSNytrVlc4MEgz?=
 =?utf-8?B?Ry9WYXNRRHh5NkRtc1owUitXQVAwMG9mcWlJSFFhZDFzN2NmMjkzbkJURE9D?=
 =?utf-8?B?akxVblIvSXp2dXFBVHdxeTlrUmZ4R1FFWlFKUUkrT05DOTJDR1dXb3k5NDR3?=
 =?utf-8?B?OVZPbEtzT3pqWTROQllBQ28vdURybnhLalQ5QWpjRzZRY0JqZFpCaXFRaXpG?=
 =?utf-8?B?WGZVQ2dkcjZvaFhKQm5rOGVmVUZmRXdhandHWHA5ZWUwTm16WGJxZXpBOXpi?=
 =?utf-8?Q?RyzlnQOfZe80To/A0fq6iY8=3D?=
X-OriginatorOrg: theobroma-systems.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a455d85b-8a58-4948-855e-08dbe9ab2947
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8536.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2023 09:29:14.5767
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5e0e1b52-21b5-4e7b-83bb-514ec460677e
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NoSk4o/qQcbD6rDcFEVAkXlT0nvCLpzkP2uz9MbBXfBSZgiFTHOa5eiKIwFUIRW/Tedd9XweAU/wBxfS3KzrPaR8b5CbgSF/CdYWEEQv79nKshZp6a62wKeS7AKaYRLy
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9097
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 20 Nov 2023 01:29:33 -0800 (PST)

Hi Fabio,

On 11/17/23 20:27, Fabio Estevam wrote:
> Hi Quentin,
> 
> On Fri, Nov 17, 2023 at 3:31 PM Quentin Schulz <foss+kernel@0leil.net> wrote:
>>
>> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>>
>> This scary message may happen if the panel or bridge is not probed
>> before the LVDS controller is, resulting in some head scratching because
>> the LVDS panel is actually working, since a later try will eventually
>> find the panel or bridge.
>>
>> Therefore let's demote this error message into a debug message to not
>> scare users unnecessarily.
> ...
> 
>> diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c b/drivers/gpu/drm/rockchip/rockchip_lvds.c
>> index f0f47e9abf5a..52e2ce2a61a8 100644
>> --- a/drivers/gpu/drm/rockchip/rockchip_lvds.c
>> +++ b/drivers/gpu/drm/rockchip/rockchip_lvds.c
>> @@ -577,7 +577,7 @@ static int rockchip_lvds_bind(struct device *dev, struct device *master,
>>                  ret = -EINVAL;
>>                  goto err_put_port;
>>          } else if (ret) {
>> -               DRM_DEV_ERROR(dev, "failed to find panel and bridge node\n");
>> +               DRM_DEV_DEBUG(dev, "failed to find panel and bridge node\n");
>>                  ret = -EPROBE_DEFER;
> 
> What about using dev_err_probe() instead?

Either is fine by me, will send a v2 and DRM maintainers can decide for 
themselves before merging :)

Cheers,
Quentin