Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   Lukas Funke <lukas.funke-oss@weidmueller.com>
To:     Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>
Cc:     Lukas Funke <lukas.funke@weidmueller.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH] net: phy: Fix potential null pointer access
Date:   Mon, 20 Nov 2023 10:32:54 +0100
Message-Id: <20231120093256.3642327-1-lukas.funke-oss@weidmueller.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nzwm7PiGmF82ax/8V9OMvEaGqGSFajkogdceNHimL+a29Ji/ZQsIpWNN3kfw?=
 =?us-ascii?Q?q6Q6e0x5rMmhCWgxNp2nmfXF4/Yu1aC22ZZhWU/tirtk63+1ttRnNj4UQuuo?=
 =?us-ascii?Q?cu9/FljTGWkW+oa8gKf8P++4swChcNEZgXygsuKU+ob0uQK/C5z5gNz4PFDi?=
 =?us-ascii?Q?hoJV0rGR58jYT2dW+4e9PiauijbKEGgmgA5NLiQdt56up+dj4OoxxivJ12Dr?=
 =?us-ascii?Q?MLlj2lqkssTNezstP9fbfJ+rh2U7ZAJMpLlB95ZIPr7HRl/Ud5VH5mLFT5PP?=
 =?us-ascii?Q?k5kkvrp3BvGWjJ9txCEh4wiCXySJURNmTTUNp4QiebqFEuiFU5CDKOB9NcxR?=
 =?us-ascii?Q?+4WGhJ3LzatGPnb1jVHvkD9ICqyJerIO9wZG7MDzo8t3ory84yttLA7p5V2H?=
 =?us-ascii?Q?WT0k/dnd4dR2Pm7mYYMpDnXWDNb1A20A7Capiz+V23eoPejz8/tnpF7ofEOP?=
 =?us-ascii?Q?5ISgobmCFtBEi3jIBXXnYmFXMJ82AzfPA4pJT5pMxFkgsTgLZ7DZf4NjJbn6?=
 =?us-ascii?Q?2jAMfIQsN0eYUVI30t8HeW5xbAO/mQyQy974PAegzYNkYuihw0Lbi5ZypIyi?=
 =?us-ascii?Q?B24n2aD635KyYDFDTpdADnHYmoDt2GYmR/v37Jjm4Jb0Q7d+lJYzMjuKNC8J?=
 =?us-ascii?Q?xtig/OGr0U0aExhGvz2vj5Rtt8NVEH/fygTqajNxx1pMbZTKzWTq9MpQnnxq?=
 =?us-ascii?Q?FPaqTzAS5imdW3ow8yf/ZMPlQuqgYDUFBokoBERvlPvwu15u/M6rTAIBA0Da?=
 =?us-ascii?Q?Xm8aEFngvrrsucCq2BO49jn7cILCG3/cR/gBTepWATI8bdzG99sDMJSw7wGG?=
 =?us-ascii?Q?1gKh+fFgazKw7DIo7AAY8qfthT7QvqoWaeOPUf3f9DihdEMJ63yQSp2F6PMX?=
 =?us-ascii?Q?jOFGljsaRtm7GHLDDscSEJsZfVkjSSPu9u4KF3v2t4PuCoY4wGN2gUUSqajc?=
 =?us-ascii?Q?Tggz3Xl17i9q8fHto19zsW9VJSpk2GjT02PzN5rA3QwP9FtCKmwmmzMYyeT/?=
 =?us-ascii?Q?iJKxxfYAXlR3yZHNIUCwEcUnYyaHXMnM4QWkxrQdQOILZFeBvms2bkc8001C?=
 =?us-ascii?Q?xwb5myLnoyqq/oav+NlrVrjMG/vOJw9V6Moe4YQl9IGUxLPrFfSsIwBrI+oV?=
 =?us-ascii?Q?1FJ8VTZa86QFdxPZTAEjTfaqAbA+wlwCiMbL0zfksxN9ZvgrFV6Z0i24MMXX?=
 =?us-ascii?Q?8NpXgfL4YOJ2zgOa+qA319/KsDNhYv33t+dIlsFeaTWNcaTrdtVlixKQdpbN?=
 =?us-ascii?Q?K/9QMI72Y6FP/DAnI/UrcAoJIkLSiOXb73evmSqoJJfu9gJ65FLi7BlhRql9?=
 =?us-ascii?Q?IYpEvuJs7rV4IxrZDprWaH+mpn/Ggn9vKTc9jHoPevr3z/4mMAerN9FhG9zN?=
 =?us-ascii?Q?RnRnxWHltmLZjsr8rcY/MnJUsTX7F4K5B6XYUc1nO7cucmOgPFAMOwdJscaQ?=
 =?us-ascii?Q?fmE25cyvzjpql21aoMQeGfgmwqDaTNBaSOtdg80uQVLSaaZFmZP7eih7sOQo?=
 =?us-ascii?Q?9qpwZQXaBOCumOpJ269MJX6ZVq8tlAty6K32cGn7jO1QkYqvdBgd2tPy6LLv?=
 =?us-ascii?Q?Xi0Ms+/yVNo4MepJ/JkEvVrFMFnVgwG8r9fBD9OFHy0C/YXVXns99JbTPx83?=
 =?us-ascii?Q?Bw=3D=3D?=
X-OriginatorOrg: weidmueller.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4f3e8210-6f11-433a-8c28-08dbe9abb2d1
X-MS-Exchange-CrossTenant-AuthSource: AS2PR08MB8431.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2023 09:33:05.3157
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e4289438-1c5f-4c95-a51a-ee553b8b18ec
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VHFPgfTga3niZGM0xJ+aZgzsLNNUNI9OaK/ryzDlHb/8BbrwFEqpLBntHMU5Qkz5XOeCEIIS17Rr34pvO13oRw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6592
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 20 Nov 2023 01:33:15 -0800 (PST)

From: Lukas Funke <lukas.funke@weidmueller.com>

When there is no driver associated with the phydev, there will be a
nullptr access. The commit checks if the phydev driver is set before
access.

Signed-off-by: Lukas Funke <lukas.funke@weidmueller.com>
---
 drivers/net/phy/phy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 1135e63a4a76..4de83e3cab77 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -136,7 +136,7 @@ EXPORT_SYMBOL(phy_print_status);
 static int phy_config_interrupt(struct phy_device *phydev, bool interrupts)
 {
 	phydev->interrupts = interrupts ? 1 : 0;
-	if (phydev->drv->config_intr)
+	if (phydev->drv && phydev->drv->config_intr)
 		return phydev->drv->config_intr(phydev);
 
 	return 0;
-- 
2.30.2