Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <6322fd4c1967a518310140c35ab34f65@mail.infomaniak.com>
Date:   Mon, 20 Nov 2023 10:33:38 +0100
Subject: Re: spi: imx: Increase imx51 ecspi burst length fails on imx6dl and
 imx8mm
From:   linux@bigler.io
Reply-To: linux@bigler.io
To:     Francesco Dolcini <francesco@dolcini.it>
Cc:     Stefan Moring <stefan.moring@technolution.nl>,
        Linux regressions mailing list <regressions@lists.linux.dev>,
        Mark Brown <broonie@kernel.org>, linux-kernel@vger.kernel.org,
        linux-spi@vger.kernel.org
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
References: <8a415902c751cdbb4b20ce76569216ed@mail.infomaniak.com>
 <e4f12422-1c47-4877-88b3-dfa9917331a2@leemhuis.info>
 <f4439fd1-7c2d-4a96-9116-1dbe04fceac0@leemhuis.info>
 <CAB3BuKA+qOY+UhWR-9Ov3qsz3wQr8q8n38MrEMf3FMCthr04yA@mail.gmail.com>
 <2fcdd99eee9ee4f5d34fa1abab2f51bb@mail.infomaniak.com>
 <CAB3BuKARgJhaVNFsP1FQ+2yLe18QU9H17fHKjc-Sf3izE+MZ1Q@mail.gmail.com>
 <86566391db9c5044f1a082bc8ec697a2@mail.infomaniak.com>
 <ZVsdNGyVrTJ/Kv3n@francesco-nb.int.toradex.com>
In-Reply-To: <ZVsdNGyVrTJ/Kv3n@francesco-nb.int.toradex.com>
Precedence: bulk

Hi Francesco

I run the test and it worked fine. The transmitted data matches with the re=
cived data, no diff.

BUT!!! on the MDIO it is completly different !!!
When I request to send 4kB Data I measure on the line 16384Byte.

The data is again   3Dummy Bytes followed by the databyte.
So the error symetic on send and recive

Regards Stefan

Am 2023-11-20T09:47:48.000+01:00 hat Francesco Dolcini <francesco@dolcini.i=
t> geschrieben:
>  On Mon, Nov 20, 2023 at 09:27:10AM +0100, linux@bigler.io wrote:
>=20
> >    Load the spi-dma (imx-sdma 302c0000.dma-controller: loaded firmware
> >  4.5), run the spi_imx and the spidev as kenelmodule.
> > =20
> >  I run the code on a Toradex Verdin Development Board and use the
> >  imx8mm-verdin-nonwifi-dev.dts
> > =20
> >  To add the spidev I patched imx8mm-verdin.dtsi
> >  diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi b/arch/a=
rm64/boot/dts/freescale/imx8mm-verdin.dtsi
> >  index 6f0811587142..262500940adc 100644
> >  --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> >  +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi
> >  @@ -209,6 +209,15 @@ &ecspi2 {
> >          cs-gpios =3D <&gpio5 13 GPIO_ACTIVE_LOW>;
> >          pinctrl-names =3D "default";
> >          pinctrl-0 =3D <&pinctrl_ecspi2>;
> >  +
> >  +       spidev@0{
> >  +               compatible =3D "micron,spi-authenta";
> >  +               reg =3D <0>;
> >  +               #address-cells =3D <1>;
> >  +               #size-cells =3D <0>;
> >  +               spi-max-frequency =3D <20000000>;
> >  +               status =3D "okay";
> >  +       };
> >   };
> > =20
> >  as a spidev test program I used=20
> >  https://raw.githubusercontent.com/raspberrypi/linux/rpi-3.10.y/Documen=
tation/spi/spidev_test.c
> =20
> Would you mind doing the following tests looping the SPI interface MISO/M=
OSI?
>=20
> ```
> cd /tmp
>=20
> dd if=3D/dev/urandom of=3D4k-spi-test-data.bin bs=3D1 count=3D4k
> spidev_test -D "$device" -s 4000000 -i 4k-spi-test-data.bin -o 4k-spi-tes=
t-result.bin
>=20
> dd if=3D/dev/urandom of=3D16bytes-spi-test-data.bin bs=3D1 count=3D16
> spidev_test -D "$device" -s 16000 -i 16bytes-spi-test-data.bin -o 16bytes=
-spi-test-result.bin
> ```
>=20
> with "$device" being your actual spidev device?
>=20
> Those tests are passing on 6.7.0-rc2 for me.
>=20
Francesco