Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp2098115rdb; Mon, 20 Nov 2023 01:40:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IGW69p2sPAYVdJ5hcU+v+DbSSG/3L0ASwdYF87sI4pLRJ064b+4XBxfQ8QjAuZOC8HIlcAA X-Received: by 2002:a17:902:e885:b0:1cc:7d96:3fba with SMTP id w5-20020a170902e88500b001cc7d963fbamr6003131plg.17.1700473212194; Mon, 20 Nov 2023 01:40:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700473212; cv=none; d=google.com; s=arc-20160816; b=K3wDsIXsSHzFcbVBMAzBTE5zr2HCQ5khRJF1BEh9WsMvXw9g2vpj+XzWMHAySHVTlO wbt8js1ePbbM2QeTdW5C/Hi9R+I5e1oSCqeNdKir5NkSGuGS1zjmIBlGh7qh4kvL/PhQ 1kOkhhYNART2duZTAD4Z4cZGfc9mrXsU9UpFl+j41xRiBr4ueSjkr6/sDH0cYFoy35jI 1psOspmjKxplcOxim/ZGj6Bb60VTARQcnkYXyAwfZiCSlj5UG8lcGcslKnQGJo9q/6j8 0XKtpnlX5CIxZIjMAeS9n8L/a8LTduv9guqa1q/hQfxM+VsZN+LUloVTeBmd/B6wGYJR RyMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=+CHgsTGKnTpbF8MedKWJQOq6ykdOdu6WVq7LnYx1a7Q=; fh=zSdfwdfY54C9/udZTRlhmjTBbI0CKWDSGiWvzuMGAEs=; b=GrVe8z1Fp58hcXguPWWGT/q8voSZ3cEe35zv/mEbThIHVpaJQQF0eTy5rk+lsc7kgs AchOT69ZAj+W66VVd2KzANJM0jz/J8JcVytsWI5Pf7olglmiRhBCJIjW5fqYgza7WLGz URBGgPutupRguN/909WHzdtIs3nEQtRsmk4XMIKdNYzO2y0tpjllgOpJkUygbVNOH2Uu zJgJ8YU1POvq0lg4TX7Rn3V4uI1Y1X2Dz/CtuTuNVYSiXdmCvVdFLSHmDrhxmcsWvmrf V80cfh+kwJC+nNovOdrCS3j+0J616lmpGMYSeEAwO8aaf9LiVGSg/5OQJ99pCGaovg+A fUlw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=etwpbxU6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id lk5-20020a17090308c500b001cc411b53f4si8399104plb.106.2023.11.20.01.40.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 01:40:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=etwpbxU6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id B6879805B9DD; Mon, 20 Nov 2023 01:40:09 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232349AbjKTJj7 (ORCPT + 99 others); Mon, 20 Nov 2023 04:39:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232138AbjKTJj6 (ORCPT ); Mon, 20 Nov 2023 04:39:58 -0500 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A325CD; Mon, 20 Nov 2023 01:39:54 -0800 (PST) Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AK9MbmM022686; Mon, 20 Nov 2023 09:39:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=+CHgsTGKnTpbF8MedKWJQOq6ykdOdu6WVq7LnYx1a7Q=; b=etwpbxU6zp6AgOTdX8UqfPg8zF7yyYh1SdvY1wMGVkOa3BpOjCMwXSorJSofrxedgpN4 3/EBpWJGK34s6UYJNl3k0mqIZhvOiid4ApMu62x5+8h7ddY3DUf7Wa+t7MM3Sn8wsIc6 xd+4iZPqDe4++tUGqsTuob+VKuhPs4m8KV9twFmzKld29P89yQPmeAMcM3hMcd8qwyDZ bSZ0S32Xqkxt2ncCGX94W5RM0WLUd6YlrYEBMLkdCjtB2Wdwg1l/lYG7LGNDFsYWyN5V sIY3LzVtoVgDRjGUD+7m4rWdGeW6/y119IKe3QSFZxcKn5EZQoG2FUdWay7JtYyeQj+R GA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ug4rv0g4x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Nov 2023 09:39:44 +0000 Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3AK9OiqB029893; Mon, 20 Nov 2023 09:39:44 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ug4rv0g08-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Nov 2023 09:39:44 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3AK7KM1o008909; Mon, 20 Nov 2023 09:39:40 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3uf7yy8e4g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Nov 2023 09:39:40 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3AK9dbaq39846224 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Nov 2023 09:39:37 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0C87D2004B; Mon, 20 Nov 2023 09:39:37 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7E20B20040; Mon, 20 Nov 2023 09:39:36 +0000 (GMT) Received: from li-2b55cdcc-350b-11b2-a85c-a78bff51fc11.ibm.com (unknown [9.171.34.73]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTPS; Mon, 20 Nov 2023 09:39:36 +0000 (GMT) Date: Mon, 20 Nov 2023 10:39:35 +0100 From: Sumanth Korikkar To: David Hildenbrand Cc: linux-mm , Andrew Morton , Oscar Salvador , Michal Hocko , "Aneesh Kumar K.V" , Anshuman Khandual , Gerald Schaefer , Alexander Gordeev , Heiko Carstens , Vasily Gorbik , linux-s390 , LKML Subject: Re: [PATCH 3/3] mm: use vmem_altmap code without CONFIG_ZONE_DEVICE Message-ID: References: <20231120072317.3169630-1-sumanthk@linux.ibm.com> <20231120072317.3169630-4-sumanthk@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-TM-AS-GCONF: 00 X-Proofpoint-GUID: Vcg2raKPY6RueXma9dVQd7y2O_sVaTn3 X-Proofpoint-ORIG-GUID: 9GXehSnBmUTDmVh2u1Uvqyx1pa7sbyHS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-20_07,2023-11-17_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0 mlxlogscore=333 malwarescore=0 impostorscore=0 priorityscore=1501 suspectscore=0 spamscore=0 bulkscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311200064 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 20 Nov 2023 01:40:09 -0800 (PST) On Mon, Nov 20, 2023 at 10:01:13AM +0100, David Hildenbrand wrote: > > What speaks against just moving them to the header instead? They surely are > tiny ... > I followed the previous convention. Sure, will make it inline and put those definitions in header file. Thanks