Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp2102707rdb; Mon, 20 Nov 2023 01:52:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IE6F+OGH0AYBm9GyKBasbQxXlHeaMKDCBPtrbY6NRoOlZ1H+4V2BeVV06I1rBEXyy5BVrz0 X-Received: by 2002:a17:903:2282:b0:1cf:56ff:28af with SMTP id b2-20020a170903228200b001cf56ff28afmr5066268plh.47.1700473949996; Mon, 20 Nov 2023 01:52:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700473949; cv=none; d=google.com; s=arc-20160816; b=uQpq5KKNUGohApE2grDRDsFonl8DfFSgoSJBDFu3EwTp+goJq1NGiPQ8k52fpr3DKR XIh4gW27A3VdS0gGVYsbwvaJSC+AJTIDj5lCZ0p+r3s4IGvkatNnz936vzETaEXMHLoX KC3WjZgoLtNv0jpR/w/a35VJInwVtt0AbnCsetZPEwt4bqOsXf5DwVeuu+TXrGMzClrP wG3Hyq0AJDOwEqssB4Bm+COCpCCCtRXj7YXf3P7XCFnqdQXkbIh/b5L8k7Pa2lUwcSu0 SeIqN3NsjPzPMsh6CzOln/DPmFLyUA5D1Z7NGO9wXuUGEDDoumYxbaGI1YLNfmO5xZVx dl9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=GhKWm8A2BWOujxS2VA+boNZBF8/Ex9YH9TtbKdo0egc=; fh=ICNw+ZbXRqSikCFIL/H5EijSsqCBVAhnBl+64lIaDNw=; b=N4Vt8eGTiSAhtzLQ4Cu167d297wqEtrnLoHfPfhfKsT9sCq6XBuzwoU4sdYVcP+qRQ a04cjDM1NlW94DxUEeMcfsoVU1D0YVfCcOydvvfid9dOML0ix53+vE52AWKZXoOU+1Ro qCz/6zAl5TP0cZ8NGF6f6T41J3DkkOtQXF990WDQNsExfhEIj8qPnbUpb7Wr70UqVudM hT/HQi/hZkydYgHJa4Huy0b35OF801L7bG3BawA6S4aTvaagr4IlnhqOmBKxChJCL8PA xlr7rvs4jDZx/ds3RDRp+nysRf5i88lzPeoxUd7mrK+wP+76Qq3JdcvTAs+ONaBG+d8D CzFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=mWRKKubF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id h12-20020a170902f7cc00b001c9f6df8a7csi7369563plw.531.2023.11.20.01.52.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 01:52:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=mWRKKubF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 0ED68806AFD0; Mon, 20 Nov 2023 01:52:09 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232305AbjKTJvp (ORCPT + 99 others); Mon, 20 Nov 2023 04:51:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232138AbjKTJvp (ORCPT ); Mon, 20 Nov 2023 04:51:45 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4DBC8F; Mon, 20 Nov 2023 01:51:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=GhKWm8A2BWOujxS2VA+boNZBF8/Ex9YH9TtbKdo0egc=; b=mWRKKubFdHTVqP+snfCHCV6owX 9QfWgA5RVXvA4VSIfQPxyIskbBfrQEsWoDdi6yprvf9swQGPwxt4VkxiwSMeDqcttnjdmM2zV2QVM 5JUHAephk1vbuI0O4K9sz6ZnNjVOyvyWWJDYS+KNOFNICMqpRHNUC0FQ1o7M5wiSCkJkZ3JGMcvrT R/uV3lr1BDk5dkDMSspLW42F0aKiggidrtTVkd3csn5kVSWr0vBJl4t9TQ5mymXIiJqj57u1sZCXp mt/+ZdTF/uM6APIiHI//zXImLdaJjR4ap/WTqEBQFEcJWnJhpQ4/imfOqJggqXQBCx8ewf7tsiId9 +qb16UUw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:42320) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1r50wI-0005GM-0o; Mon, 20 Nov 2023 09:51:34 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1r50wI-00034i-ST; Mon, 20 Nov 2023 09:51:34 +0000 Date: Mon, 20 Nov 2023 09:51:34 +0000 From: "Russell King (Oracle)" To: Lukas Funke Cc: Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Lukas Funke , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: phy: Fix potential null pointer access Message-ID: References: <20231120093256.3642327-1-lukas.funke-oss@weidmueller.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231120093256.3642327-1-lukas.funke-oss@weidmueller.com> Sender: Russell King (Oracle) X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 20 Nov 2023 01:52:09 -0800 (PST) On Mon, Nov 20, 2023 at 10:32:54AM +0100, Lukas Funke wrote: > From: Lukas Funke > > When there is no driver associated with the phydev, there will be a > nullptr access. The commit checks if the phydev driver is set before > access. What's the call path that we encounter a NULL drv pointer? Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!