Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758984AbXK0Pfq (ORCPT ); Tue, 27 Nov 2007 10:35:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755583AbXK0Pfj (ORCPT ); Tue, 27 Nov 2007 10:35:39 -0500 Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:46573 "EHLO ebiederm.dsl.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751204AbXK0Pfi (ORCPT ); Tue, 27 Nov 2007 10:35:38 -0500 From: ebiederm@xmission.com (Eric W. Biederman) To: Pavel Emelyanov Cc: Oleg Nesterov , linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/3] start the global /sbin/init with 0,0 special pids References: <20071127135948.GA8370@tv-sign.ru> <474C33DC.7090407@openvz.org> Date: Tue, 27 Nov 2007 08:34:33 -0700 In-Reply-To: <474C33DC.7090407@openvz.org> (Pavel Emelyanov's message of "Tue, 27 Nov 2007 18:12:28 +0300") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1147 Lines: 29 Pavel Emelyanov writes: > Eric W. Biederman wrote: >> Oleg Nesterov writes: >> >>> As Eric pointed out, there is no problem with init starting with sid == pgid >>> == 0, and this was historical linux behavior changed in 2.6.18. >>> >>> Remove kernel_init()->__set_special_pids(). >>> >>> This change and the previous change in daemonize() mean that /sbin/init does >>> not need the special "session != 1" hack in sys_setsid() any longer. We can't >>> remove this check yet, we should cleanup copy_process(CLONE_NEWPID) first, so >>> update the comment only. >> >> I guess that works. As long as we get there. We just need one more patch >> in this series to fix the copy_process(CLONE_NEWPID). > > I hope this will NOT be the fix that creates the namespace's > init with the pid == 0 ;) No just with session == pgrp == (unchanged and thus with vpid 0). Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/