Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Mon, 20 Nov 2023 09:55:22 +0000
From:   Charles Keepax <ckeepax@opensource.cirrus.com>
To:     Maciej Strozek <mstrozek@opensource.cirrus.com>
CC:     Mark Brown <broonie@kernel.org>,
        James Schulman <james.schulman@cirrus.com>,
        David Rhodes <david.rhodes@cirrus.com>,
        "Liam Girdwood" <lgirdwood@gmail.com>,
        <alsa-devel@alsa-project.org>, <patches@opensource.cirrus.com>,
        <linux-sound@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/7] ASoC: cs43130: Allow driver to work without IRQ
 thread
Message-ID: <20231120095522.GH32655@ediswmail.ad.cirrus.com>
References: <20231117141344.64320-1-mstrozek@opensource.cirrus.com>
 <20231117141344.64320-7-mstrozek@opensource.cirrus.com>
 <ZVeWfefrEQJIx0YL@finisterre.sirena.org.uk>
 <153531080cd3d36fea86263d393ef885533f6e44.camel@opensource.cirrus.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <153531080cd3d36fea86263d393ef885533f6e44.camel@opensource.cirrus.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk

On Mon, Nov 20, 2023 at 09:43:25AM +0000, Maciej Strozek wrote:
> W dniu pią, 17.11.2023 o godzinie 16∶36 +0000, użytkownik Mark Brown
> napisał:
> > On Fri, Nov 17, 2023 at 02:13:43PM +0000, Maciej Strozek wrote:
> > > Signed-off-by: Maciej Strozek <mstrozek@opensource.cirrus.com>
> > > ---
> > >  sound/soc/codecs/cs43130.c | 56 +++++++++++++++++++++++++++++++---
> > > ----
> > >  sound/soc/codecs/cs43130.h |  1 +
> > >  2 files changed, 47 insertions(+), 10 deletions(-)
> > 
> > Why?  This isn't some obvious fix, you need to write a changelog
> > motivating open coding interrupt handling if there's some reason for
> > doing that.
> 
> This is to support systems without physical IRQ connection. The device
> only requires the IRQ for a couple of internal delays, this polling
> mechanism is a fallback when no IRQ is specified.
> 

Yeah pop that in the change log and resend the patch as a v2.

Thanks,
Charles