Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp2110377rdb; Mon, 20 Nov 2023 02:09:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IGlDvQupj+AyHWV7D/Gnp+YNUZwapWLTBtUBGmfpT4gppiop08QxHhU9rLDukfF6nPyAGEU X-Received: by 2002:a05:6a00:88d:b0:6be:43f8:4e0b with SMTP id q13-20020a056a00088d00b006be43f84e0bmr5819420pfj.24.1700474943267; Mon, 20 Nov 2023 02:09:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700474943; cv=none; d=google.com; s=arc-20160816; b=UjpVcMfDJIQRszUDCOfvSIGvzUtZE6RzulOeLa7lKDO6IfuXS9cqUhfWdge8lT6lef wtgbBL48/iJSIM/B7lYpMEEvAvNt74O/Kd7/lm0Z2xLHruHeAVSStO6QUHOFZQts9a6m DlWwkLhdTrB6TfgkJ0ctMshRtyI9TimavEh5lQNHmH0TOSVZVy43hfT4CfI7bBtGtJJJ wRRBEnvscr+so4GSWYNIIxJA2fDYTh6FUo23DD7cePG6342n/4hgjPe9RQ0KRuxIn41S si7YmzGbwl1d/W0IYngsCyudwrFxSSbEFgDx4GIwBbxQSbDMVDrYCaIxkTXE3Wy/NB3B c3yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=DNEecYXDNkISAqeuDHyscyNZH+ll3zAc9H0rsEG8n/A=; fh=PUK5fDm3R4Vh8/ugS67Ou2J04C3xQTxos56K5jZd8tw=; b=PulKTQ4qGwfzdj85Be/UjYLwfgOfnT5J+6G33/DjZ2uiOxIt/BN7xPbpxU7sgWXcol fJ1liI4iqm3YIizY7743W2m1yu4YIK8j2lj8xTLvC0Rxi0uorOBUTZxMgLgPPNZmFU7C 5i/KN73ifyxgsHMIiL9nrHy0hGsw2JPvZzgZ/xMAYmV9kEvXEvDSil8ElHvqZhNYQoS3 YwXTQw+lPI76olIlPIim4rC3MM7PW39Ab3AVWSxVNavZRrthlaTA2N4/38ymLN+SYHri 5iS1iehi6fXQT2gqpMb7ymUShIN39CzU0C9Sjj130yE9I4jb27jHYJPi0ida9WYZQQUw g4Wg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=G+W0JkTa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id ca8-20020a056a02068800b005b96c2ab110si8240646pgb.131.2023.11.20.02.09.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 02:09:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=G+W0JkTa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id A277D80713D5; Mon, 20 Nov 2023 02:07:25 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232461AbjKTKGx (ORCPT + 99 others); Mon, 20 Nov 2023 05:06:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232941AbjKTKGi (ORCPT ); Mon, 20 Nov 2023 05:06:38 -0500 Received: from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com [IPv6:2607:f8b0:4864:20::1133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13B9C136 for ; Mon, 20 Nov 2023 02:06:35 -0800 (PST) Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-5ac376d311aso44358237b3.1 for ; Mon, 20 Nov 2023 02:06:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700474794; x=1701079594; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=DNEecYXDNkISAqeuDHyscyNZH+ll3zAc9H0rsEG8n/A=; b=G+W0JkTabZjzRg06iACmB6/FkqkGR0NbpYn2PvvZRPMxb8Uirl59ZxQJP0qVAfCO8g OVbFCB6RqEPRx8o9n79qK14HODSK9iOEKuRit6J0YUW/4mYA3PO+PuhsyWu8UM6m1iqV BW3EejeDVT872yAm/LsvqpBeJUtWNIlAn+ne5lb3XYpR+GxUwA4O8G07ljjF1wfsD3hd FeKdki4H4/iJ8sYSIpXk25vZPJg25XxTUrKtCyZidnGxWCTky/ii8/nH3/l+VEdL37gh w8OiP8JrBk5QlLW6u1rdTgamWjyQUas9p9DnLMlmTk3hc5wVeFvCM+xx1Wg1re3w8wfN 5Ipg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700474794; x=1701079594; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DNEecYXDNkISAqeuDHyscyNZH+ll3zAc9H0rsEG8n/A=; b=vgfj8A6/98MCIsYWo9RIeqDmEwvyeDievwiOt5ArrsqYwiGqOJWzCQWGk5TK/6FciQ Yfj4Xw/OljElrVL1CUZcdNZvxhwD4fu7G9j9J4X5g1X4mvjMwDZdGnzD3+2kc6YS52S0 hRQNvXC/wRa+IcagSPS15YzEP8LPSZmLogE2aByeheFxmQS/fn1fL2Jzh868UR04VC8y Kh45cpMuRFCyJv3QiBYpwp08HEU4Gdmy4rHZ8yaoUnjYrIBjNgwPATSKmRkXJ97AEvHy 5yC7pQE8DPzKjp7yKSBxopTkAtJll2PpiofD7SSIAb5nXOZOiE1pGDtE1qoBprJfShyx Z3Ow== X-Gm-Message-State: AOJu0YydTeaxGHAipYSDnvdk7plQbzlFJiFj5Gbh66q1TU9NLveknYRJ k56CIwCjVStBWQm3Fg+9G8nUYZjzu8oxcpgj/9dVcg== X-Received: by 2002:a81:5404:0:b0:5a7:e3f9:a1fb with SMTP id i4-20020a815404000000b005a7e3f9a1fbmr8128022ywb.42.1700474794228; Mon, 20 Nov 2023 02:06:34 -0800 (PST) MIME-Version: 1.0 References: <20231114150130.497915-1-sui.jingfeng@linux.dev> <20231114150130.497915-9-sui.jingfeng@linux.dev> <1b59d647-c345-4260-b07b-22abb70ae17a@linux.dev> <7b85d057-3d66-435a-a657-dd69067b6bef@linux.dev> <954e2f85-7ed8-4768-97c4-970315afeec1@linux.dev> In-Reply-To: <954e2f85-7ed8-4768-97c4-970315afeec1@linux.dev> From: Dmitry Baryshkov Date: Mon, 20 Nov 2023 12:06:22 +0200 Message-ID: Subject: Re: [PATCH 8/8] drm/bridge: it66121: Allow link this driver as a lib To: Sui Jingfeng Cc: Phong LE , Neil Armstrong , Maxime Ripard , Sui Jingfeng , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Laurent Pinchart , Thomas Zimmermann Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 20 Nov 2023 02:07:25 -0800 (PST) On Fri, 17 Nov 2023 at 19:36, Sui Jingfeng wrote: > > Hi, > > > On 2023/11/17 17:03, Dmitry Baryshkov wrote: > > On Fri, 17 Nov 2023 at 06:24, Sui Jingfeng wrote: > >> Hi, > >> > >> On 2023/11/16 23:23, Dmitry Baryshkov wrote: > >>>>>> Then you will need some way (fwnode?) to > >>>>>> discover the bridge chain. And at the last point you will get into the > >>>>>> device data and/or properties business. > >>>>>> > >>>>> No, leave that chance to a more better programmer and forgive me please, > >>>>> too difficult, I'm afraid of not able to solve. Thanks a lot for the > >>>>> trust! > >>> From my point of view: no. > >> > >> I respect the fact that the community prefer generic mechanisms. > >> If our approach is not what the community want, can I switch back > >> to my previous solution? I can reduce the duplication of our > >> localized it66121 driver to a minimal, rewrite it until it meets > >> the community's requirement. I know our device looks weird and > >> our approach is not elegant. But at the very least, we could not > >> mess the community's design up by localize. Otherwise, I don't know > >> what is the better approach to solve such a problem. > >> > >> Can I switch back or any other ideas? > > I keep on repeating: create the i2c device from your root device > > driver, which parses BIOS data. > > > You didn't focus on solve the problem, You are focus on solving me. > How does the method that parsing BIOS data can be generic and applied > universally? Parsing BIOS data is unique to your platform (as well as your BIOS tables). However using and extending (instead of replacing it just for your platform) is a generic item. -- With best wishes Dmitry