Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp2125869rdb; Mon, 20 Nov 2023 02:46:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IEhVyGNZJID0ilWanuhfdgTck96vauviHqD6QvUVGHl4FCt+6QqZR4ZCI9/3caM/ZYU3BCc X-Received: by 2002:aca:1a0e:0:b0:3b6:6ec9:9301 with SMTP id a14-20020aca1a0e000000b003b66ec99301mr8131466oia.39.1700477171580; Mon, 20 Nov 2023 02:46:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700477171; cv=none; d=google.com; s=arc-20160816; b=l/QEOGQcMxUNqDoNaWdg3pyC3tQ0BHid9tjoymFqHxjnblJF/2CAy7OCAT315gC8Zm Gm0/859HRirOm4WkRjkMfAxXF5UHSSqzSXQXWOBBAsYKRqcBHmXhcKWFTPbFxWfBRMmJ bcRe1P2j/fxauFWTdD77migQguHu2I552yy3XZKoEG8/FL+K4izo33sGDQplq3PxE7Ys qjMmogoh25W7rjADQjjPxbtFLTiKjaHgEhXF4BiiDSvRiqNY3ROCfklAyZkKUrOoQl5E xIzHTD3aTzo6PzlmrmICjK0VkRJ1MgtDJHQtanAcq8wGMxsC54/IacqpJJgDqCcYPmCs ePAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=pEGM8ev0APvf3tLYEQebZXb/D0A2uaiSExo0/kQhZG0=; fh=stMAePkZF8NaBGyhTsDzbCidUa7S5ezJzr2r9PcQtt0=; b=GuWhdyDqPcZswaHO61KXcUEqf3zdj9xgY1WkVXVae42R80x766inuKfwZaE2KkSsAx ZekwqrYvmZAXSTdEAG1u3TcFHkUP7ce/6+67ktIYiYwz0HtJJ+znnSYBTKoukNIsu8zd +nm/b6jCsP5NCLqWexRmF3D4Y9y7mc2OBhIO1j8+pBC9PaZdv+ZZfTJggKSSOzHCx6PQ TW4nStvCbAywC6HOpDz+kFtzXsJrJEte5VxIZRcV8Iez24ZFh7oxpp1imSTZIkRMwEu4 lE0TfDN6QYb3r51Wzt4Hymm2F1cQtk1vMRQIQ+q32DcvLxqHkcyOirWotyAv2CSS6SgX 7XiA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Oyz9Wlzd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id bn6-20020a056a02030600b00578b8d202b0si8169890pgb.536.2023.11.20.02.46.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 02:46:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Oyz9Wlzd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 765E5805A5CB; Mon, 20 Nov 2023 02:46:05 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232627AbjKTKp4 (ORCPT + 99 others); Mon, 20 Nov 2023 05:45:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232701AbjKTKpl (ORCPT ); Mon, 20 Nov 2023 05:45:41 -0500 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F4AED61 for ; Mon, 20 Nov 2023 02:45:09 -0800 (PST) Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-9c603e2354fso794261266b.1 for ; Mon, 20 Nov 2023 02:45:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700477108; x=1701081908; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pEGM8ev0APvf3tLYEQebZXb/D0A2uaiSExo0/kQhZG0=; b=Oyz9WlzdoI5o5V//eW3QSSkJIoSQVQv3wIWFk0JciwpsRs5MtA5nDb+B6vcKrveMhP 7OFPE61Ts4DGx1fa30J5i6aDFuojZUpnccEF40/zFDkfZ6fJoYamVe9Tqygqety0jZhk mH993JNh/gWmTOEH36F5mqtq6ff7IY0dJvmbX6uZ0UtLOY2AzHrxRKzw1LEbMK4+mVdU re5IzyhZSyoIkgSODIlCFIRE4C/j1KTMsxSe4GybQJ760mpd5e8/TIRQljDoubhSZBI0 I+gpeScraINRWIiBSv0ct6w5iBFkgnBUpujv5bmFwsZ0rmKxQ2+tHg2cuDwGSj97OfTS BG0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700477108; x=1701081908; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pEGM8ev0APvf3tLYEQebZXb/D0A2uaiSExo0/kQhZG0=; b=m/Ejeb1c6bv3qTNFVeaRVMiwRCNL2UyEZWMAr2hVY2skBCRHZVMIZ/UC93APpBB6aY o1WTrmoB28771oRi4d1MwaKw81/Kudj5fu2JEWdjugMNaVVycZfAoUTLnoFCPzhD7WQI h4kCQfNLevgncm+2AAcTwD78EA3q24emrbgTXvBm/OoaKlKigveyrLBrWdzp/bZluAce TEzZBxWlXV5ddf5w4YWpJltKwdzBUgn/Z3AMnooiu4xc0rqLjddyEAJRqOFxag876No3 X1fIbbvvRSNAF9rRJoGUHGtisv/1zJT61U7bMO3ECbcVdKCYl0C5DCUWnQQuBDR6Mwb1 biTw== X-Gm-Message-State: AOJu0YznSwPLC7B+Il5JzmefJcFP04wlsLSEpTMjdBG7gnH+yOizqvpz i8NSDAl00G7Wq7AydkG3yRHjMA== X-Received: by 2002:a17:906:259:b0:9ee:85ed:3196 with SMTP id 25-20020a170906025900b009ee85ed3196mr1455343ejl.0.1700477107696; Mon, 20 Nov 2023 02:45:07 -0800 (PST) Received: from [192.168.1.20] ([178.197.222.11]) by smtp.gmail.com with ESMTPSA id lz10-20020a170906fb0a00b009737b8d47b6sm3732334ejb.203.2023.11.20.02.45.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Nov 2023 02:45:07 -0800 (PST) Message-ID: Date: Mon, 20 Nov 2023 11:45:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] nfc: virtual_ncidev: Add variable to check if ndev is running Content-Language: en-US To: Nguyen Dinh Phi , bongsu.jeon@samsung.com Cc: "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "syzbot+6eb09d75211863f15e3e@syzkaller.appspotmail.com" References: <20231119164705.1991375-1-phind.uet@gmail.com> <20231120044706epcms2p48c4579db14cc4f3274031036caac4718@epcms2p4> <20d93e83-66c0-28d9-4426-a0d4c098f303@gmail.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20d93e83-66c0-28d9-4426-a0d4c098f303@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 20 Nov 2023 02:46:05 -0800 (PST) On 20/11/2023 11:39, Nguyen Dinh Phi wrote: >>>> mutex_lock(&vdev->mtx); >>>> kfree_skb(vdev->send_buff); >>>> vdev->send_buff = NULL; >>>> + vdev->running = false; >>>> mutex_unlock(&vdev->mtx); >>>> >>>> return 0; >>>> @@ -50,7 +55,7 @@ static int virtual_nci_send(struct nci_dev *ndev, struct sk_buff *skb) >>>> struct virtual_nci_dev *vdev = nci_get_drvdata(ndev); >>>> >>>> mutex_lock(&vdev->mtx); >>>> - if (vdev->send_buff) { >>>> + if (vdev->send_buff || !vdev->running) { >>> >>> Dear Krzysztof, >>> >>> I agree this defensive code. >>> But i think NFC submodule has to avoid this situation.(calling send function of closed nci_dev) >>> Could you check this? >> >> This code looks not effective. At this point vdev->send_buff is always >> false, so the additional check would not bring any value. >> >> I don't see this fixing anything. Syzbot also does not seem to agree. >> >> Nguyen, please test your patches against syzbot *before* sending them. >> If you claim this fixes the report, please provide me the link to syzbot >> test results confirming it is fixed. >> >> I looked at syzbot dashboard and do not see this issue fixed with this >> patch. >> >> Best regards, >> Krzysztof >> > > Hi Krzysztof, > > I've submitted it to syzbot, it is the test request that created at > [2023/11/20 09:39] in dashboard link > https://syzkaller.appspot.com/bug?extid=6eb09d75211863f15e3e ...and I see there two errors. I don't know, maybe I miss something obvious (our brains like to do it sometimes), but please explain me how this could fix anything? Best regards, Krzysztof