Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
MIME-Version: 1.0
References: <20231119194740.94101-1-ryncsn@gmail.com> <20231119194740.94101-17-ryncsn@gmail.com>
 <ZVp6Lt0socttCB9+@casper.infradead.org>
In-Reply-To: <ZVp6Lt0socttCB9+@casper.infradead.org>
From:   Kairui Song <ryncsn@gmail.com>
Date:   Mon, 20 Nov 2023 19:14:42 +0800
Message-ID: <CAMgjq7Aq22AbFC9pWLnwSGDtofu4t9Ew3GrKPHgWtRJcAtoV3A@mail.gmail.com>
Subject: Re: [PATCH 16/24] mm/swap: reduce scope of get_swap_device in swapin path
To:     Matthew Wilcox <willy@infradead.org>
Cc:     linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
        "Huang, Ying" <ying.huang@intel.com>,
        David Hildenbrand <david@redhat.com>,
        Hugh Dickins <hughd@google.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@suse.com>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Matthew Wilcox <willy@infradead.org> =E4=BA=8E2023=E5=B9=B411=E6=9C=8820=E6=
=97=A5=E5=91=A8=E4=B8=80 05:12=E5=86=99=E9=81=93=EF=BC=9A
>
> On Mon, Nov 20, 2023 at 03:47:32AM +0800, Kairui Song wrote:
> >       page =3D swapin_readahead(entry, GFP_HIGHUSER_MOVABLE,
> >                               vmf, &cache_result);
> > -     if (page) {
> > +     if (PTR_ERR(page) =3D=3D -EBUSY) {
>
>         if (page =3D=3D ERR_PTR(-EBUSY)) {
>

Thanks, I'll fix this.