Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759316AbXK0QfH (ORCPT ); Tue, 27 Nov 2007 11:35:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756429AbXK0Qe5 (ORCPT ); Tue, 27 Nov 2007 11:34:57 -0500 Received: from mx2.suse.de ([195.135.220.15]:37294 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754206AbXK0Qe4 (ORCPT ); Tue, 27 Nov 2007 11:34:56 -0500 Subject: Re: [alsa-devel] [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table From: Thomas Renninger Reply-To: trenn@suse.de To: Rene Herman Cc: ALSA devel , linux-kernel , "yakui.zhao" , "Li, Shaohua" , akpm , Alan Cox , Bjorn Helgaas , Takashi Iwai In-Reply-To: References: <1195552283.23700.166.camel@queen.suse.de> <20071120123102.03bdaa67@the-village.bc.nu> <1195568360.23700.202.camel@queen.suse.de> <4742EFBE.6030407@keyaccess.nl> Content-Type: text/plain Organization: Novell/SUSE Date: Tue, 27 Nov 2007 17:34:51 +0100 Message-Id: <1196181292.23251.53.camel@queen.suse.de> Mime-Version: 1.0 X-Mailer: Evolution 2.8.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1736 Lines: 41 On Wed, 2007-11-21 at 10:53 +0100, Takashi Iwai wrote: > At Tue, 20 Nov 2007 15:31:26 +0100, > Rene Herman wrote: > > > > On 20-11-07 15:19, Thomas Renninger wrote: > > > > > At the end is some example code how things could get even more cleaned > > > up. It shows how I think pnp layer and one example driver would get > > > adjusted. There are not that much drivers making use of > > > pnp_resource_change... > > > > The ALSA ISA-PnP drivers do in what I personally consider a bad layering > > violation. Brought up not doing that a while ago on alsa-devel, but no > > discussion ensued. If the PnP maintainer(s) agree with me though, I'd be > > more than happy to rip all of that out of ALSA. Rene: Could you do that, pls. > > I'm fine with removal of that stuff now. It was implemented in that > way because there was no proper way to re-assign ISA PnP resources on > 2.4 kernel time. On 2.6, it makes no longer any sense (except for > compatibility, but this is almost no problem for PnP boards). I wasted some time on thinking about how this pnp_resource_change and pnp_manual_config_dev could get workarounded..., but it's impossible without changing the (more a workaround than an) interface. If you worked on this already, would you mind ripping these out? If I understand Takashi correctly, the driver code using pnp_resource_change and pnp_manual_config_dev can simply be removed and devices could get resources assigned via sysfs "set" interface. Thanks, Thomas - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/