Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <618e3f85-10a5-4e65-a91f-20e0cd5f4c0f@suse.com>
Date:   Mon, 20 Nov 2023 12:39:29 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 21/34] usb: cdc-acm: optimize acm_softint()
Content-Language: en-US
To:     Yury Norov <yury.norov@gmail.com>, linux-kernel@vger.kernel.org,
        Oliver Neukum <oneukum@suse.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org
Cc:     Jan Kara <jack@suse.cz>,
        Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>,
        Matthew Wilcox <willy@infradead.org>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>,
        Alexey Klimov <klimov.linux@gmail.com>
References: <20231118155105.25678-1-yury.norov@gmail.com>
 <20231118155105.25678-22-yury.norov@gmail.com>
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <20231118155105.25678-22-yury.norov@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?KzFnbE1FaTh0b2hJZ1F4OWpLQjJSWURqMmNLa2ZyNDczVkJpcUdtQzQwbUQ2?=
 =?utf-8?B?RGNRQ2NiYTUyLzVyM1BVUnZMa21rT0hWTy91Z3pJb0Q3ZjZkekVPTkJqNVhX?=
 =?utf-8?B?Vm5ZTXM0ZThLRXg4VkNSc0RkMEJqeitjclphYkh1NVVLL0JKcnBzNnZGTzRr?=
 =?utf-8?B?c3hodE9IcW12elh1dTFzbXZkRy9vZG5FTVlBczBMTkw5RTIreTJDMG5LRXdp?=
 =?utf-8?B?T0NldTFteFVVOU9TTTloOFlTWlBBUDB6UkdQVnIxZ0plVit4U3FjWDNOL2Vx?=
 =?utf-8?B?S3NFSk44MzBEU05YUmo3NGR3NGhSa3dXZUlwajllTGx5NHdGcGkyMzMvRlRz?=
 =?utf-8?B?TzNHNWN3R05qOHJVUUFZTE5pYkN2QjBNVHR0S2psNXlaNnJZMWloVlVhb1dC?=
 =?utf-8?B?WEtrRGpPN0tQandHWnZBVTJHYTFaYkM3UkRiS05taXhjemtuZ0wwRUY5aXoz?=
 =?utf-8?B?OFNWeUJUdEdCMXYvb1hsdVU5NFNqb1lvM3AvdXdkZmc2ejdTbUN4aDNubS9T?=
 =?utf-8?B?cDJVTFpXSmVyUkRtRk5GcjhjRjNobEJjVFY0S05obmFiYjVlQmhMN2p1Q1Ro?=
 =?utf-8?B?T0poR2FzT2RIMVVsWSs1eHNZUWxsK2hNclJGKy9McFM0NnEwbGZyWTBVWVBo?=
 =?utf-8?B?QlR6Uk9qNEptL2tEdVlNOHhmSkdwamNIbUEwNjRGTlpXcmZvS3MrSUFocWdY?=
 =?utf-8?B?Q1JNOUVyY0ptMW03ZDhBOUQ3Njdublc5Q0tqY3dqWDhKVStUajJ1THNNSVFP?=
 =?utf-8?B?aTR4YzFlT3FLNjVYSjBGRTlFQ245NnM0MkhOcHd4YVJMa2dERkRibmJsMmFh?=
 =?utf-8?B?akl2ZkNQZnJIS0tvZGxBVXpyby9sQWoxNHhJMTJyMDFxY2FBVFhIa3ExRFFr?=
 =?utf-8?B?QmxidDZ6QlZrb0o4SHJEb0tnMHpLNEhoZUJNM0NVL3BqLzhSeWF2MkVVb1NQ?=
 =?utf-8?B?QkVNU2F2OEl2S3Q1am9LWmlYVWlzcFpURTc2U29CN24wSHpER0sxTkJiOE5M?=
 =?utf-8?B?b1hBbGFrcFVkUVZIS2J4aWc3NE5GcUMzUEtQVEp3bGZ3TmpOT3IwREZIWWR4?=
 =?utf-8?B?ek1DbWlrVjloUHBiQk5qWlRKaEI4N1llM1p1ZUpiQ2M4UmRTZ3BJV1lZa3Vy?=
 =?utf-8?B?dlMrbjJLTlZUcExzVXpzZDF0Q0pJRW9tWDZlSjR2eXhQOUI3VEcyV3dTNkxF?=
 =?utf-8?B?RFh0TjNLK2JEOHBySkU4UFE3ZnNnc1R5OUVtRGFzVnpRZ1FWcWlUNXZqaFVV?=
 =?utf-8?B?aW9aSzMzT1RrN05EeW1vVXRpL0FTenNtS1ZuK0J2UExVb2ZkMmpQWC8zdzgz?=
 =?utf-8?B?R3Z1SFhDa3B0KzNyVHk0OUJEaHBnbnZiaHVFOFlSVVA0QWIrVGYreUx2S1py?=
 =?utf-8?B?VGRYNlZXem15Qjl0SjRGaHoySDRtcnZoOE9uWlZHQzUweldhWFZCL1NLQUpv?=
 =?utf-8?B?OGtDWldSeTR1eisyRVFWN3lsUCs3bmpVZGNmNXEvSXZBUUFMZFFQMHB5Q2s2?=
 =?utf-8?B?SHg3T3MwcXlmeGRxK1VnWFo1dko5Y1dHTXpaa296bEd3V3NsOHNpMTBhRzNH?=
 =?utf-8?B?M0JHdmppVUp2cmVpcEp4eDMvQ3M2dmJNc3dwSjNyUmNHSFFIcGFvRXlpNW9T?=
 =?utf-8?B?dEYyVWpaQU5Fa2VXM1ozTlJ2L1U1Z2c0bW5oMC9VbkJBUStjeUJMMEdOSjZH?=
 =?utf-8?B?bEdXazN5QzRzeUVYb1h0RHF0RGVKU0pjSEtrZGhtaENZSjZkcU53TldFMysy?=
 =?utf-8?B?YUROWUJ2OEs3SVZVZ2tmVXlYTUVRSXpsbGh4MUhJNW5EVHlxbEFxTUdON21Y?=
 =?utf-8?B?TE9GaWVBQURER1NYaWc0Y1hZVThra3UzVmszaHJLWFc1TjZNc012NHpxL0I4?=
 =?utf-8?B?enJJdGRTV1JqWjdMNDRtVDcyc0tDN3BQWWpONjZ6bmFpUS85bmg1TDU5b3ZV?=
 =?utf-8?B?eVQwNmNYcmp1VXNzM1JFNklSKzNPRDBkcmJXWkl3bmxYcS9VdzBKQVI3eU5C?=
 =?utf-8?B?YzdBTFN0RG9jdWYyT0o5c1U0YUhPMmx2RWJrSkRiR0JWVEVDQnEwTkxVSnNO?=
 =?utf-8?B?STIxd3JHeHoyWU93WU1kTEFLbFZGMEFaYlZPNVBnVjliU1hyQUVpUVZlYXha?=
 =?utf-8?B?SUE2anhBcnI0dWlmVCtLbTNoUHNQOGhmMmdjOHQ1WVFLOEgxaGxrNnNTdVI2?=
 =?utf-8?Q?gcyaEBNqIuYzPc/EerWqFrp+92LYSY/Uu5u75Ow7HKbB?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f4bff1d2-895e-4362-30fe-08dbe9bd5cd4
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6467.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2023 11:39:32.1362
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +70KCHE5Pa9kxFbT2GhDQDbik/O6K8kq84iYchYuqxeZm98uQszOhhetek9YPofYDxaXqTvGSGQavCrguTTgxA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8477
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 20 Nov 2023 03:39:46 -0800 (PST)


On 18.11.23 16:50, Yury Norov wrote:
> acm_softint(), uses for-loop to traverse urbs_in_error_delay bitmap
> bit by bit to find and clear set bits.
> 
> We can do it better by using for_each_test_and_clear_bit(), because it
> doesn't test already clear bits.
> 
> Signed-off-by: Yury Norov <yury.norov@gmail.com>
Acked-by: Oliver Neukum <oneukum@suse.com>