Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <5ce53c5c-d80a-4bb3-83d5-e70317052ed0@intel.com>
Date:   Mon, 20 Nov 2023 13:29:11 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [net-next PATCH v2 2/2] octeontx2-pf: TC flower offload support
 for mirror
Content-Language: en-US
To:     Suman Ghosh <sumang@marvell.com>, <sgoutham@marvell.com>,
        <gakula@marvell.com>, <sbhatta@marvell.com>, <hkelam@marvell.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <lcherian@marvell.com>,
        <jerinj@marvell.com>
References: <20231118180157.3593084-1-sumang@marvell.com>
 <20231118180157.3593084-3-sumang@marvell.com>
From:   Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <20231118180157.3593084-3-sumang@marvell.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V3o3VjlVQmtocEcwZTJqMWk2L29JTWRQcFQ3cXZsZ2JxZnpMU0lMbWp4WlJ3?=
 =?utf-8?B?RExBNDQ4eWVsWW5JcENZanF6REw3aXllRlhOck8wdEFtek53dW95Q0JCQ1RS?=
 =?utf-8?B?eDN5OXlFYmZqNHF3cUhJRXA3N1AyVDZOQXc5Vm00RDNleDN0Q1BwMnQyVzR5?=
 =?utf-8?B?VjcvWmJzdzVaM3FhUDBiSzdtUi9za0RoakRHanBhelFQdTRHZk5rYzJ1Q1VV?=
 =?utf-8?B?ZFJyZjRma3JaQjF1ejlIc2NkSmxQMjluRExzYU1SK2dJK0tKV3FpeWd2Yzg5?=
 =?utf-8?B?TmxWalZFeC91VURTRGE2dEVxcVhqV0ZRNTZHU1RJZWxrWnBZNXdoNnlFbWxn?=
 =?utf-8?B?cktObHpJeUI1ckZNb1NvdDlxRjZJMEdOZWo1bjNpSTc2Z3Q4ZjFlQ0o2aGZK?=
 =?utf-8?B?OFJJcEhOb2Z4TU1Cd3R2NElMNCtob2xpNWUzNGFneEhtVWNsM0JGbW5kOTBD?=
 =?utf-8?B?RnppMzJRZnFUWGtJNVNtV0xnTVRkaFp0NzRhenFTTDZvK3RTbll2bDBkT2Vo?=
 =?utf-8?B?TTZ5QlpXM0hxa0E2WnBYSVZVanlxYTRiVlFqZjZ5cFdlekNUaVRVSjBzUXYz?=
 =?utf-8?B?clVQR0NzMU9VRmwvM2t4Z2hhVUtWamtMMGFNbEpOS3oveDhYaTdYekJIZlpY?=
 =?utf-8?B?WU9nOE5haTVaMjlZdUd1NE95Y1FCb1B4d0ZTWWVEY0VKUk5wUmZnNE1MZ1NX?=
 =?utf-8?B?WUNVN05hejVVVUtXTjlKLzRla2tvZE9nK1BuV2V4eXQ3SmY2clFXVkxKdGZ4?=
 =?utf-8?B?NU83RTdIbUxjcXhrRGxhbG9zREluVnNWOFU3c2ZtdXROUFIwcEdMeUYralkx?=
 =?utf-8?B?NjlGY3IyN0tlcEx4cEt5WGI0WGF5dlkyVHFHZm8rZ3NwcERWWDN5VnJCUEpw?=
 =?utf-8?B?aTFzVnFHZ2RxTU9WRzdDM2xMV1B5TG02ZXhGZ1V4VjFZSURhY3ZzbURyT0R4?=
 =?utf-8?B?dU8vZFo4QjNXbUhTUUVtdGRqQUlQcnlBMnpuN2JvU0x3ekVpWXZNdDcvbSt0?=
 =?utf-8?B?ZmI0YzZRN2ZwK0lRTWljSlNiR3libTZrVlRyUmNhSWlFTmNaMWNncGVXUGdm?=
 =?utf-8?B?MTUrSXhMSUhzcTVNcjR4dDR0aFhCbkVRQUM3Vjl0a2ZMaFdTb25JMjIrckVG?=
 =?utf-8?B?TkdvdWNZa0pEcy8wTkkzOUhSL2Nra3BGTmhWeVMwNDV6dHVrUGZaT1V2YzZr?=
 =?utf-8?B?V2FSeWhnY2xKTkpSdERMQkJXOHZ0cHljWWZOMVVCSXVKRVdYNGVkNUZGSjhP?=
 =?utf-8?B?bkVvUzRBMVllMUlxN1BXOGZEczhXLzdVNFNWRmN5U1cvUlRFanZYZjhKWVpF?=
 =?utf-8?B?WVk1RVlMaFM5YjM3dmszQUpzS1JpMWVYWFVTK0JHU3c0SFVMYjdYbWVKalQr?=
 =?utf-8?B?ajhaMXRLbHNVa211YXZCL3VQbEpTQTAwL21QZWl5Zlg5WnVnWDVqdTdKK0x6?=
 =?utf-8?B?YnE0aUY2QzdKNjRKTHBva1RWVk16eVpVclRHbnM5TlpieUN5ZG5mWnJ4QTM5?=
 =?utf-8?B?VEN1U1krZjlwZjZlSFQxNE84VnZXeW1WendGMEVqU3V4NDhaNXF4RmQrWFlN?=
 =?utf-8?B?QVRjMkZwRVBwcElsUm1lN2NObVlKZXpRZnRoSllUZ3ZmckMwMDFNSGl3YlJB?=
 =?utf-8?B?em90RG5DT1R3Nk82Um15QzNZMzE5Wi9wUjdmdDdYcHh6d09xNjZFS2hRczdx?=
 =?utf-8?B?RFlPdWhMU204RGtMc2dQL3ZvT0dCNHZxWEQyR1Facm44aVpBUGpwS0x6VDJa?=
 =?utf-8?B?eWc2ZVQzZnY4elRodnBpVDdQeXFNMytlMHI1Nlkzb0g4UXY5enJXYTRVcGNZ?=
 =?utf-8?B?c2h3UG1nNGlRS0YyWEV1dmNsaXprYXg3ckIxUmI0NHBZQUk2VW96VXNEOS8w?=
 =?utf-8?B?RUV5OTI4aS93eVlVbjk3angxRDhINHNDYTBJTDJ4MnZ5Q2ZmbVFGU3ppREpP?=
 =?utf-8?B?OTlPc1U2dTltSjZQMnNrU0l3QlF0aEplbUZWZWlXeW8rVGc5LzE2TVVYRHdH?=
 =?utf-8?B?ZlRNMG95S0tyT0pSbEc3Z2l1dWd0QzZXQUxsc0NJekRNRlNZeG11RHRqaG1q?=
 =?utf-8?B?UUc1SmNRMnZzcFk0Q3FUMVFIZXFLeHRLS0o0ajhFa0xGVE1DbG9IUFNFZUJS?=
 =?utf-8?B?cnptQlFTYXlJeWFxUXJQdFJtd2Y0MFhtejdhM3RGWkJGS2tKRzZmRURTWkRY?=
 =?utf-8?B?TkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4480fc9d-7fbd-45f4-8941-08dbe9c4505a
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2023 12:29:17.6284
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L02cQ8C1Kw7LjRLlRG5z2wH3TaGhgKBacz+bKGMt0ur/NyzMy20+z/F9yQDjMEjjuUVU7L44D/R1UylEYMWtaV3AwbzxmTyAArRHj2Q9jbs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6419
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 20 Nov 2023 04:29:49 -0800 (PST)


On 18.11.2023 19:01, Suman Ghosh wrote:
> This patch extends TC flower offload support for mirroring ingress/egress
> traffic to a different PF/VF. Below is an example command,
> 
> 'tc filter add dev eth1 ingress protocol ip flower src_ip <ip-addr>
> skip_sw action mirred ingress mirror dev eth2'
> 
> Signed-off-by: Suman Ghosh <sumang@marvell.com>
> ---

I already added my tag here, you can add it to the next versions.
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>

>  .../ethernet/marvell/octeontx2/nic/otx2_tc.c  | 113 +++++++++++++++++-
>  1 file changed, 110 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
> index 8a5e3987a482..17a8d9778193 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_tc.c
> @@ -29,6 +29,8 @@
>  
>  #define OTX2_UNSUPP_LSE_DEPTH		GENMASK(6, 4)
>  
> +#define MCAST_INVALID_GRP		(-1U)
> +
>  struct otx2_tc_flow_stats {
>  	u64 bytes;
>  	u64 pkts;
> @@ -47,6 +49,7 @@ struct otx2_tc_flow {
>  	bool				is_act_police;
>  	u32				prio;
>  	struct npc_install_flow_req	req;
> +	u32				mcast_grp_idx;
>  };
>  
>  static void otx2_get_egress_burst_cfg(struct otx2_nic *nic, u32 burst,
> @@ -336,22 +339,96 @@ static int otx2_tc_act_set_police(struct otx2_nic *nic,
>  	return rc;
>  }
>  
> +static int otx2_tc_update_mcast(struct otx2_nic *nic,
> +				struct npc_install_flow_req *req,
> +				struct netlink_ext_ack *extack,
> +				struct otx2_tc_flow *node,
> +				struct nix_mcast_grp_update_req *ureq,
> +				u8 num_intf)
> +{
> +	struct nix_mcast_grp_update_req *grp_update_req;
> +	struct nix_mcast_grp_create_req *creq;
> +	struct nix_mcast_grp_create_rsp *crsp;
> +	u32 grp_index;
> +	int rc;
> +
> +	mutex_lock(&nic->mbox.lock);
> +	creq = otx2_mbox_alloc_msg_nix_mcast_grp_create(&nic->mbox);
> +	if (!creq) {
> +		rc = -ENOMEM;
> +		goto error;
> +	}
> +
> +	creq->dir = NIX_MCAST_INGRESS;
> +	/* Send message to AF */
> +	rc = otx2_sync_mbox_msg(&nic->mbox);
> +	if (rc) {
> +		NL_SET_ERR_MSG_MOD(extack, "Failed to create multicast group");
> +		goto error;
> +	}
> +
> +	crsp = (struct nix_mcast_grp_create_rsp *)otx2_mbox_get_rsp(&nic->mbox.mbox,
> +			0,
> +			&creq->hdr);
> +	if (IS_ERR(crsp)) {
> +		rc = PTR_ERR(crsp);
> +		goto error;
> +	}
> +
> +	grp_index = crsp->mcast_grp_idx;
> +	grp_update_req = otx2_mbox_alloc_msg_nix_mcast_grp_update(&nic->mbox);
> +	if (!grp_update_req) {
> +		NL_SET_ERR_MSG_MOD(extack, "Failed to update multicast group");
> +		rc = -ENOMEM;
> +		goto error;
> +	}
> +
> +	ureq->op = NIX_MCAST_OP_ADD_ENTRY;
> +	ureq->mcast_grp_idx = grp_index;
> +	ureq->num_mce_entry = num_intf;
> +	ureq->pcifunc[0] = nic->pcifunc;
> +	ureq->channel[0] = nic->hw.tx_chan_base;
> +
> +	ureq->dest_type[0] = NIX_RX_RSS;
> +	ureq->rq_rss_index[0] = 0;
> +	memcpy(&ureq->hdr, &grp_update_req->hdr, sizeof(struct mbox_msghdr));
> +	memcpy(grp_update_req, ureq, sizeof(struct nix_mcast_grp_update_req));
> +
> +	/* Send message to AF */
> +	rc = otx2_sync_mbox_msg(&nic->mbox);
> +	if (rc) {
> +		NL_SET_ERR_MSG_MOD(extack, "Failed to update multicast group");
> +		goto error;
> +	}
> +
> +	mutex_unlock(&nic->mbox.lock);
> +	req->op = NIX_RX_ACTIONOP_MCAST;
> +	req->index = grp_index;
> +	node->mcast_grp_idx = grp_index;
> +	return 0;
> +
> +error:
> +	mutex_unlock(&nic->mbox.lock);
> +	return rc;
> +}
> +
>  static int otx2_tc_parse_actions(struct otx2_nic *nic,
>  				 struct flow_action *flow_action,
>  				 struct npc_install_flow_req *req,
>  				 struct flow_cls_offload *f,
>  				 struct otx2_tc_flow *node)
>  {
> +	struct nix_mcast_grp_update_req dummy_grp_update_req = { 0 };
>  	struct netlink_ext_ack *extack = f->common.extack;
> +	bool pps = false, mcast = false;
>  	struct flow_action_entry *act;
>  	struct net_device *target;
>  	struct otx2_nic *priv;
>  	u32 burst, mark = 0;
>  	u8 nr_police = 0;
> -	bool pps = false;
> +	u8 num_intf = 1;
> +	int err, i;
>  	u64 rate;
> -	int err;
> -	int i;
>  
>  	if (!flow_action_has_entries(flow_action)) {
>  		NL_SET_ERR_MSG_MOD(extack, "no tc actions specified");
> @@ -423,11 +500,30 @@ static int otx2_tc_parse_actions(struct otx2_nic *nic,
>  			req->index = act->rx_queue;
>  			break;
>  
> +		case FLOW_ACTION_MIRRED_INGRESS:
> +			target = act->dev;
> +			priv = netdev_priv(target);
> +			dummy_grp_update_req.pcifunc[num_intf] = priv->pcifunc;
> +			dummy_grp_update_req.channel[num_intf] = priv->hw.tx_chan_base;
> +			dummy_grp_update_req.dest_type[num_intf] = NIX_RX_RSS;
> +			dummy_grp_update_req.rq_rss_index[num_intf] = 0;
> +			mcast = true;
> +			num_intf++;
> +			break;
> +
>  		default:
>  			return -EOPNOTSUPP;
>  		}
>  	}
>  
> +	if (mcast) {
> +		err = otx2_tc_update_mcast(nic, req, extack, node,
> +					   &dummy_grp_update_req,
> +					   num_intf);
> +		if (err)
> +			return err;
> +	}
> +
>  	if (nr_police > 1) {
>  		NL_SET_ERR_MSG_MOD(extack,
>  				   "rate limit police offload requires a single action");
> @@ -1033,6 +1129,7 @@ static int otx2_tc_del_flow(struct otx2_nic *nic,
>  			    struct flow_cls_offload *tc_flow_cmd)
>  {
>  	struct otx2_flow_config *flow_cfg = nic->flow_cfg;
> +	struct nix_mcast_grp_destroy_req *grp_destroy_req;
>  	struct otx2_tc_flow *flow_node;
>  	int err;
>  
> @@ -1064,6 +1161,15 @@ static int otx2_tc_del_flow(struct otx2_nic *nic,
>  		mutex_unlock(&nic->mbox.lock);
>  	}
>  
> +	/* Remove the multicast/mirror related nodes */
> +	if (flow_node->mcast_grp_idx != MCAST_INVALID_GRP) {
> +		mutex_lock(&nic->mbox.lock);
> +		grp_destroy_req = otx2_mbox_alloc_msg_nix_mcast_grp_destroy(&nic->mbox);
> +		grp_destroy_req->mcast_grp_idx = flow_node->mcast_grp_idx;
> +		otx2_sync_mbox_msg(&nic->mbox);
> +		mutex_unlock(&nic->mbox.lock);
> +	}
> +
>  	otx2_del_mcam_flow_entry(nic, flow_node->entry, NULL);
>  	otx2_tc_update_mcam_table(nic, flow_cfg, flow_node, false);
>  	kfree_rcu(flow_node, rcu);
> @@ -1096,6 +1202,7 @@ static int otx2_tc_add_flow(struct otx2_nic *nic,
>  	spin_lock_init(&new_node->lock);
>  	new_node->cookie = tc_flow_cmd->cookie;
>  	new_node->prio = tc_flow_cmd->common.prio;
> +	new_node->mcast_grp_idx = MCAST_INVALID_GRP;
>  
>  	memset(&dummy, 0, sizeof(struct npc_install_flow_req));
>