Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp2178507rdb; Mon, 20 Nov 2023 04:31:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IH9iykJe+a/L0I/lROGtPpXz43vs6+zC1b61iVgdNizjwgqj39Ajh3UtIFEqfTdyEJcPhvP X-Received: by 2002:a92:c90f:0:b0:35b:ce4:cb81 with SMTP id t15-20020a92c90f000000b0035b0ce4cb81mr439081ilp.29.1700483465308; Mon, 20 Nov 2023 04:31:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700483465; cv=none; d=google.com; s=arc-20160816; b=UDoxEHh7Opp+ckWHgdcSz9eTe2kLxM6pnX0ftqdjOn/HikMLGszZmfUqjCYqAieIK8 Vml2/9ltk/8+c5YuXD3MBzKTxbtI7s7z8CwWT/M3kF8+fHmYqvNqHFLwqNiCoIowPgVP RGmAFyYUaIDW20AsQI221FfhXTtgCcrUjnq0RFWgqm6WDF64JrOTmlU4qfyNamnWv0lb /M/PQCXTGYRG+L4is2J1VnnIxfaYI1oXFn2H6uPy8IKKRb/c9CByj1p8lWkatB+Rckpf g3jqNZpNtoHFEFCpH6xSNtIIWpvGem5YQxYIwMZkqmq79qrvn32B3/dH3OXFuS+XiLby UX1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=EevClquVp+K+Xs6zLHPZTlqrFA7f/h/qtRHgwhMpzvI=; fh=61MsDxO2nlB28w/gDedjzWsFJxOlFE0AkoXm0k2ZWfg=; b=hNxJ2oYEPPGm4LPvteUo0QfuNC2fqDKdIrSGrkpFo+E27G34yIPoWKDuhRphRO/4w3 gqcIL0UyI5C7q/olbaN6QZR2LxuERdOk8j00/oevY+9qvvTbJywbvVGJdy6Z7iifhmP4 41ETynDwiRmqtQoPg1kpVB07UBSxwXOZkk7R/Sl8azOLj/FvDqPo/DHDJrEZBkqq3aI6 LZpbo0MfANNdr+317/aHegK45WxeeDrp7RVgIOUrH5zNVv3RTaJPnauxdcwn6O/pwpBx y2Et+LdNCRp6H1dRMaxblUOFxbHi9NcmtrcNFZZeRFO3TCuOQ99rTbNIhajJEGJr75SW 88iw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id a13-20020a65640d000000b005ace065e529si8341195pgv.333.2023.11.20.04.31.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 04:31:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 555DC8078300; Mon, 20 Nov 2023 04:30:37 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233652AbjKTMaR (ORCPT + 99 others); Mon, 20 Nov 2023 07:30:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233478AbjKTMaP (ORCPT ); Mon, 20 Nov 2023 07:30:15 -0500 Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC465F1 for ; Mon, 20 Nov 2023 04:30:11 -0800 (PST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 0143AFF813; Mon, 20 Nov 2023 12:30:08 +0000 (UTC) From: Quentin Schulz To: Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Mark Yao Cc: Quentin Schulz , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Fabio Estevam , Quentin Schulz Subject: [PATCH v2 1/2] drm/rockchip: lvds: do not overwrite error code Date: Mon, 20 Nov 2023 13:29:48 +0100 Message-ID: <20231120-rk-lvds-defer-msg-v2-1-9c59a5779cf9@theobroma-systems.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231120-rk-lvds-defer-msg-v2-0-9c59a5779cf9@theobroma-systems.com> References: <20231120-rk-lvds-defer-msg-v2-0-9c59a5779cf9@theobroma-systems.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Mailer: b4 0.12.4 Content-Transfer-Encoding: 8bit X-GND-Sasl: foss@0leil.net X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 20 Nov 2023 04:30:37 -0800 (PST) From: Quentin Schulz ret variable stores the return value of drm_of_find_panel_or_bridge which can return error codes different from EPROBE_DEFER. Therefore, let's just return that error code instead of forcing it to EPROBE_DEFER. Fixes: 34cc0aa25456 ("drm/rockchip: Add support for Rockchip Soc LVDS") Cc: Quentin Schulz Signed-off-by: Quentin Schulz --- drivers/gpu/drm/rockchip/rockchip_lvds.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c b/drivers/gpu/drm/rockchip/rockchip_lvds.c index f0f47e9abf5a..17d8fc797151 100644 --- a/drivers/gpu/drm/rockchip/rockchip_lvds.c +++ b/drivers/gpu/drm/rockchip/rockchip_lvds.c @@ -578,7 +578,6 @@ static int rockchip_lvds_bind(struct device *dev, struct device *master, goto err_put_port; } else if (ret) { DRM_DEV_ERROR(dev, "failed to find panel and bridge node\n"); - ret = -EPROBE_DEFER; goto err_put_port; } if (lvds->panel) -- 2.42.0