Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp2211585rdb; Mon, 20 Nov 2023 05:24:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IEWMtYvTwLfwxiimGxuMos8ktATFqAfItu9wKNR/rLxRI0EihrBe7XuQD9U2kwNNzxTEPTa X-Received: by 2002:a05:6a20:1592:b0:187:c184:58dc with SMTP id h18-20020a056a20159200b00187c18458dcmr5783089pzj.17.1700486645984; Mon, 20 Nov 2023 05:24:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700486645; cv=none; d=google.com; s=arc-20160816; b=viY+wXvVlhrJjv8GIhcTPmoSuN7SWDiMnnVrRqdLpd3NkejdIjWjyBg/jdpu3GZJUv 9vHXYF7kyj84cPIAwvXugytHa9M7yrntLkruybGtyCbqjzhRRvbmurKQvDBe6NQscDIM 3sOUGmqRKihtR1R+Xnwxhh5fXXGNNi6x+fd+XL8fsiVBYTXNnBCR8NDBooLd81u/ABxn aPdAywUXSb0PB5tTV46i2KleOuBsssU/Cae0jBAVUYaV56l55Onyc9XpZYdUxq5aWETZ FnbJLIBYiWt77mzlgeiQqnLMUSRw3+i2yOOKCzWs6cW04xrCVDu8k926lWi+yNTbIvc5 BREg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from; bh=1nhPQyeLc74MjtdswkPpJjax5RsvJp/MJ9wUo/Yr2xc=; fh=IYJcvjruGo/ROSo30p5Adi0uNhPR2XdImYJiyUWh+ug=; b=UG1sTzCKcFezDaj6aEaiuUVgo8L2ZxsCWLVQ4FQ1HxxaaAPbNftorUZPRn+uCA1ibh 4ohz7Z0ZqDG7ZBz/ijm1Ds8OIfp1lSaf9mx1WUV3wybheiirIYIAABL/9vs/keIXvvAo ZDLRqx7UPQutBEB+SMa7NHFG8Tjfj43i0x8zuv2+R/UD0irPlUt5NoLxjoPm7bFQFnUz djPJ/HiXRF9VlkQJxMI/EnUggTwGZuLozv78Amla48f51eclVFcP8GOZpwVMMwS7ueSa +OSsKBuLWBfo1RNy3uSWUXL7KyZVl/GbH6VvDAFpqFU3FzH5kkrKQe+qpHiiyPL78Cl5 RGvw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id c8-20020aa79528000000b006c33988ea3esi7613038pfp.402.2023.11.20.05.24.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 05:24:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 03CAF80557DC; Mon, 20 Nov 2023 05:24:03 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233163AbjKTNXn convert rfc822-to-8bit (ORCPT + 99 others); Mon, 20 Nov 2023 08:23:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233330AbjKTNX3 (ORCPT ); Mon, 20 Nov 2023 08:23:29 -0500 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E641D6D; Mon, 20 Nov 2023 05:23:04 -0800 (PST) X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 3AKDMZCI0801065, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36506.realtek.com.tw[172.21.6.27]) by rtits2.realtek.com.tw (8.15.2/2.95/5.92) with ESMTPS id 3AKDMZCI0801065 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Nov 2023 21:22:35 +0800 Received: from RTEXMBS05.realtek.com.tw (172.21.6.98) by RTEXH36506.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Mon, 20 Nov 2023 21:22:35 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXMBS05.realtek.com.tw (172.21.6.98) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Mon, 20 Nov 2023 21:22:32 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::40c2:6c24:2df4:e6c7]) by RTEXMBS04.realtek.com.tw ([fe80::40c2:6c24:2df4:e6c7%5]) with mapi id 15.01.2375.007; Mon, 20 Nov 2023 21:22:32 +0800 From: Justin Lai To: Jakub Kicinski CC: "davem@davemloft.net" , "edumazet@google.com" , "pabeni@redhat.com" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "andrew@lunn.ch" , Ping-Ke Shih , Larry Chiu Subject: RE: [PATCH net-next v11 05/13] net:ethernet:realtek:rtase: Implement hardware configuration function Thread-Topic: [PATCH net-next v11 05/13] net:ethernet:realtek:rtase: Implement hardware configuration function Thread-Index: AQHaF8h2HvTf1F/vj0i3mzSIlPQ+NLCALagAgAMLV4A= Date: Mon, 20 Nov 2023 13:22:32 +0000 Message-ID: References: <20231115133414.1221480-1-justinlai0215@realtek.com> <20231115133414.1221480-6-justinlai0215@realtek.com> <20231118145046.7bb8efca@kernel.org> In-Reply-To: <20231118145046.7bb8efca@kernel.org> Accept-Language: zh-TW, en-US Content-Language: zh-TW x-originating-ip: [172.21.210.185] x-kse-serverinfo: RTEXMBS05.realtek.com.tw, 9 x-kse-antispam-interceptor-info: fallback x-kse-antivirus-interceptor-info: fallback Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-KSE-AntiSpam-Interceptor-Info: fallback X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 20 Nov 2023 05:24:03 -0800 (PST) > On Wed, 15 Nov 2023 21:34:06 +0800 Justin Lai wrote: > > + .ndo_vlan_rx_add_vid = rtase_vlan_rx_add_vid, > > + .ndo_vlan_rx_kill_vid = rtase_vlan_rx_kill_vid, #ifdef > > +CONFIG_NET_POLL_CONTROLLER > > + .ndo_poll_controller = rtase_netpoll, #endif > > + .ndo_setup_tc = rtase_setup_tc, > > This patch is still way too huge. Please remove more functionality from the > initial version of the driver. You certainly don't need VLAN support or CBS > offload to pass packets. Thanks for your review, I will remove some less necessary functions and make the patch smaller.