Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp2230212rdb; Mon, 20 Nov 2023 05:54:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IEG8qn00UZTRwQy/6hF3q9j3DqY6dscNf54RRyXjvekvMix41nFIZqwDt5AoygvITYGpa12 X-Received: by 2002:a17:903:120d:b0:1c9:e229:f5e2 with SMTP id l13-20020a170903120d00b001c9e229f5e2mr6337490plh.34.1700488454671; Mon, 20 Nov 2023 05:54:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700488454; cv=none; d=google.com; s=arc-20160816; b=IIK9REN2WY/LzcaxAe/ggPlr/iueagwL7/SFB+xkjUVl8Dze/rkfF6hXvXf0KFKlyN ArvrMstdlQ3hVV5OS19SnTYqSECsP81/c7eS7w9ZEK8TGShbNtelVH25eQ3kYbPPwgT1 fGvEOcyY9DmHC4ZBpBrsAfmunpk9YFACvl8kTNhONpZUhbJlHVlGIG8FkRT3hObnT6cE /kW8nNT6XTVhhWNt6WtgJJaJuhYg2ETkhCAFo64nOFp3XT7v5KMWWnbtkQj2Sv1k1eLm o1vz/PNnZ6cDg+DAPK2JT5Arf82FHccN4cmeQqx83CI10sVuXzEWKW6uoUWuGkYx8b41 y6Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=Fxba1kYMA1eupI9Avrj6/S3g58MdFYbeVhsqFUI7604=; fh=FAHM3tbCwJnRa64okJUK4jQpVL/hF017uMrLb7nKLZA=; b=s6Gjc1kANvqWP66+TBXp9X6z32Dd2ECBFrGEdgl1+/j9eU12Sq0xKScWwOypLzYfkM L+EWZ+MEYPZmGJOHOHcYWWSUlYzdiZfRDeHgQwhZeYUmtwtytn/eziEeYLQfumE8PFfx 89FsU2iMD1DYVwLxVATybiz7kzv6PR9tNdIgORaD7G3kCs6d6Rnai06G98BZT3CapMpq HUFOdsbDeeyFaTJnDZViaULMOUjXbZF9EGvvKl+4ykbVIQo2WTrwRwu6mQGrjVaIpXs3 ASYgXgVWrjpi3erAZKFAKbTN5EafCjL9T/lH3ag73J2xKA22ZQOlm6/9YAWjEFNw394k ZlUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id c16-20020a170903235000b001b3fb1742e4si8177201plh.547.2023.11.20.05.54.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 05:54:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 6908E8038F99; Mon, 20 Nov 2023 05:54:12 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233627AbjKTNx4 (ORCPT + 99 others); Mon, 20 Nov 2023 08:53:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233602AbjKTNxj (ORCPT ); Mon, 20 Nov 2023 08:53:39 -0500 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 880671709; Mon, 20 Nov 2023 05:52:42 -0800 (PST) Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-32f8246103cso1193133f8f.1; Mon, 20 Nov 2023 05:52:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700488361; x=1701093161; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Fxba1kYMA1eupI9Avrj6/S3g58MdFYbeVhsqFUI7604=; b=YFyemUCIgt4BDePZ2hWYh3NoYS4ly2fSqtuEcFwvxvFXco31YXyxR0mz/n6VbPHpdH PgEz9F8Gknhj2z0nI3MKQwWDFU/x2QE4AwZ0zqAynvWemL4D03brw8jZJmpjO2ZW+pxt CHUGr8LiqltPIhZe7gm4WT4+qoMls1M7m94T5CsPpslxwng0CrGwB7yh6yB5hvP3bcye Jh2KNRpzCRleZUA3Cbr//qWmMZSLyzo7upnk6L/ATM04JR7UTQsXJZuJ9ivYqI3l9t51 UhZasYG3jtvITqRaWNklmSJVrh9DBeAteXeZZCclqiNIo77C/ylQ1+pjCLEN31kOpghC PrMg== X-Gm-Message-State: AOJu0Yy/RG7pyvs1stVdjqox9Mrobou1Zf0YyyYcbPpM2pqnnwoIEq7Z BADzjFsiM9U/i+brPAiaZ9KPyyy1X6E= X-Received: by 2002:adf:e7c3:0:b0:32d:d932:5848 with SMTP id e3-20020adfe7c3000000b0032dd9325848mr5111777wrn.2.1700488360967; Mon, 20 Nov 2023 05:52:40 -0800 (PST) Received: from [192.168.64.177] (bzq-219-42-90.isdn.bezeqint.net. [62.219.42.90]) by smtp.gmail.com with ESMTPSA id z18-20020a5d4c92000000b00331424a1266sm11249805wrs.84.2023.11.20.05.52.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Nov 2023 05:52:40 -0800 (PST) Message-ID: <3a304aea-23a3-4ac7-beca-f814624a466d@grimberg.me> Date: Mon, 20 Nov 2023 15:52:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] nvme-tcp: Fix a memory leak Content-Language: en-US To: Christoph Hellwig , Christophe JAILLET Cc: Keith Busch , Jens Axboe , Hannes Reinecke , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-nvme@lists.infradead.org References: <7f132cc47e627d63ddb084f3d0fcad10956d1e35.1698677322.git.christophe.jaillet@wanadoo.fr> <20231030145220.GA28484@lst.de> From: Sagi Grimberg In-Reply-To: <20231030145220.GA28484@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 20 Nov 2023 05:54:12 -0800 (PST) > Looks good: > > Reviewed-by: Christoph Hellwig > >> Personally I prefer v1. Pick the one you prefer :) > > I think we should be consistent with one style or another in a > given function. Otherwise I wouldn't even have mentioned it. This looks good too: Reviewed-by: Sagi Grimberg