Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Mon, 20 Nov 2023 14:53:19 +0100
Subject: Re: [PATCH v3 6/6] tty: serial: amba-pl011: factor QDF2400 SoC
 erratum 44 out of probe
Cc:     "Russell King" <linux@armlinux.org.uk>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        "Jiri Slaby" <jirislaby@kernel.org>,
        "LKML" <linux-kernel@vger.kernel.org>,
        "linux-serial" <linux-serial@vger.kernel.org>,
        "Linus Walleij" <linus.walleij@linaro.org>,
        =?utf-8?q?Gr=C3=A9gory_Clement?= <gregory.clement@bootlin.com>,
        "Alexandre Belloni" <alexandre.belloni@bootlin.com>,
        "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
        "Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
        "Tawfik Bayouk" <tawfik.bayouk@mobileye.com>
To:     =?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
From:   =?utf-8?q?Th=C3=A9o_Lebrun?= <theo.lebrun@bootlin.com>
Message-Id: <CX3OTU62O1C4.1XI8WONTYYFU1@tleb-bootlin-xps13-01>
References: <20231120-mbly-uart-v3-0-07ae35979f1f@bootlin.com>
 <20231120-mbly-uart-v3-6-07ae35979f1f@bootlin.com>
 <5c10e247-3fe-7455-a13-fde4c3cb0b4@linux.intel.com>
In-Reply-To: <5c10e247-3fe-7455-a13-fde4c3cb0b4@linux.intel.com>
Precedence: bulk

Hello,

On Mon Nov 20, 2023 at 10:55 AM CET, Ilpo J=C3=A4rvinen wrote:
> On Mon, 20 Nov 2023, Th=C3=A9o Lebrun wrote:
>
> > On this platform, different vendor data is used. That requires a
> > compile-time check as we access (1) a global boolean & (2) our local
> > vendor data. Both symbols are accessible only when
> > CONFIG_ACPI_SPCR_TABLE is enabled.
> >=20
> > Factor the vendor data overriding to a separate function that is empty
> > when CONFIG_ACPI_SPCR_TABLE is not defined.
> >=20
> > Suggested-by: Ilpo J=C3=A4rvinen <ilpo.jarvinen@linux.intel.com>
> > Signed-off-by: Th=C3=A9o Lebrun <theo.lebrun@bootlin.com>
> > ---
> >  drivers/tty/serial/amba-pl011.c | 25 ++++++++++++++++++-------
> >  1 file changed, 18 insertions(+), 7 deletions(-)
> >=20
> > diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-=
pl011.c
> > index 4185d6fd243b..e08a32eb0ed1 100644
> > --- a/drivers/tty/serial/amba-pl011.c
> > +++ b/drivers/tty/serial/amba-pl011.c
> > @@ -2874,6 +2874,22 @@ static int pl011_resume(struct device *dev)
> > =20
> >  static SIMPLE_DEV_PM_OPS(pl011_dev_pm_ops, pl011_suspend, pl011_resume=
);
> > =20
> > +#ifdef CONFIG_ACPI_SPCR_TABLE
> > +static void qpdf2400_erratum44_workaround(struct device *dev,
> > +					  struct uart_amba_port *uap)
> > +{
> > +	if (qdf2400_e44_present)
>
> This should be !qdf2400_e44_present.

Completely right! I reversed the if-logic to see how it looked & I
forgot negating the condition when going back to the current shape.
I've got the fix ready for a v4. You've got some good eyes, thanks.

I'll wait a bit to see if there are any other review & avoid spamming
the maintainers.

Thanks,

--
Th=C3=A9o Lebrun, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com