Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759382AbXK0RZL (ORCPT ); Tue, 27 Nov 2007 12:25:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757526AbXK0RY4 (ORCPT ); Tue, 27 Nov 2007 12:24:56 -0500 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:36083 "EHLO mailhub.stusta.mhn.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757515AbXK0RYz (ORCPT ); Tue, 27 Nov 2007 12:24:55 -0500 Date: Tue, 27 Nov 2007 18:24:44 +0100 From: Adrian Bunk To: Andi Kleen Cc: Tom Tucker , Rusty Russell , Roland Dreier , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, sam@ravnborg.org Subject: Re: [PATCH RFC] [1/9] Core module symbol namespaces code and intro. Message-ID: <20071127172444.GC3406@stusta.de> References: <20071122343.446909000@suse.de> <200711271549.37670.rusty@rustcorp.com.au> <1196141742.9876.49.camel@trinity.ogc.int> <200711271002.22958.ak@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <200711271002.22958.ak@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1435 Lines: 40 On Tue, Nov 27, 2007 at 10:02:22AM +0100, Andi Kleen wrote: >... > That is EXPORT_SYMBOL already. The trouble is just that it covers > too much. My patchkit is trying to limit it again for a specific > use case -- exporting an "internal" interface to another module. > Or rather a set of modules. > > Standard example is TCP: TCP exports nearly everything and the > single user is the TCP code in ipv6.ko. Instead those symbols should > be limited to be only accessable to ipv6.ko. >... Let's forget about external modules that are anyway irrelevant for upstream kernel development. Do you have past examples where this would have brought advantages for the upstream kernel justifying all the work required for creating and maintaining these namespaces? IOW, where modules were submitted for upstream inclusion and merging them was impossible or much harder only because they were developed aginst the wrong API? > -ANdi cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/