Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Mon, 20 Nov 2023 14:02:30 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>
Cc:     tudor.ambarus@linaro.org, pratyush@kernel.org,
        miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
        sbinding@opensource.cirrus.com, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org, michael@walle.cc,
        linux-mtd@lists.infradead.org, nicolas.ferre@microchip.com,
        alexandre.belloni@bootlin.com, claudiu.beznea@tuxon.dev,
        michal.simek@amd.com, linux-arm-kernel@lists.infradead.org,
        git@amd.com, amitrkcian2002@gmail.com
Subject: Re: [PATCH v10 1/8] spi: Add multi-cs memories support in SPI core
Message-ID: <281c9708-f965-4bb1-821e-3e6cfe26ba5d@sirena.org.uk>
References: <20231118135446.52783-1-amit.kumar-mahapatra@amd.com>
 <20231118135446.52783-2-amit.kumar-mahapatra@amd.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="m2cq6RiF6dDmRuer"
Content-Disposition: inline
In-Reply-To: <20231118135446.52783-2-amit.kumar-mahapatra@amd.com>
Precedence: bulk


--m2cq6RiF6dDmRuer
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Nov 18, 2023 at 07:24:39PM +0530, Amit Kumar Mahapatra wrote:
> AMD-Xilinx GQSPI controller has two advanced mode that allows the
> controller to consider two flashes as one single device.

This breaks an x86 allmodconfig build:

/build/stage/linux/sound/pci/hda/cs35l56_hda_spi.c: In function =E2=80=98cs=
35l56_hda_spi
_probe=E2=80=99:
/build/stage/linux/sound/pci/hda/cs35l56_hda_spi.c:32:52: error: passing ar=
gumen
t 2 of =E2=80=98cs35l56_hda_common_probe=E2=80=99 makes integer from pointe=
r without a cast [-We
rror=3Dint-conversion]
   32 |         ret =3D cs35l56_hda_common_probe(cs35l56, spi->chip_select);
      |                                                 ~~~^~~~~~~~~~~~~
      |                                                    |
      |                                                    u8 * {aka unsign=
ed ch
ar *}
In file included from /build/stage/linux/sound/pci/hda/cs35l56_hda_spi.c:12:
/build/stage/linux/sound/pci/hda/cs35l56_hda.h:45:63: note: expected =E2=80=
=98int=E2=80=99 but a
rgument is of type =E2=80=98u8 *=E2=80=99 {aka =E2=80=98unsigned char *=E2=
=80=99}
   45 | int cs35l56_hda_common_probe(struct cs35l56_hda *cs35l56, int id);
      |                                                           ~~~~^~

--m2cq6RiF6dDmRuer
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmVbZvUACgkQJNaLcl1U
h9C7+wf/Y66EoAefhFbBRGn/F667fF8eGVlw/njem/yf50HB8iNFULY3b1FDiQN2
tkohmbFFMPuwef2VX7ughOqk3b6vFTY6YRNVjvQvItlKJL85m8zuPVmetJ35s42O
+5htT9J+WhIbBIvaeL7gRms/hltTunTTSE0maVCT2sA8UTFFOXHLZ8SrYfRGMcHE
7h9rnmV7eJR/BttTqDtVyQg3n/MiRWvWZb+nhVQAE7ytHZVyydUYIWd8Cl4o941d
t0MJ4sTVXUwh4k1V2Km6CwTbfAFHmyQlv0Kgzmwb+F5xevmaymXutZqVlWYv5cR6
UZerV5/EA6GdypcQYNSC5y91TI9xUw==
=9H0Y
-----END PGP SIGNATURE-----

--m2cq6RiF6dDmRuer--