Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   Zi Yan <ziy@nvidia.com>
To:     Baolin Wang <baolin.wang@linux.alibaba.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        "\"Huang, Ying\"" <ying.huang@intel.com>,
        Ryan Roberts <ryan.roberts@arm.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>,
        David Hildenbrand <david@redhat.com>,
        "\"Yin, Fengwei\"" <fengwei.yin@intel.com>,
        Yu Zhao <yuzhao@google.com>, Vlastimil Babka <vbabka@suse.cz>,
        "\"Kirill A . Shutemov\"" <kirill.shutemov@linux.intel.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Kemeng Shi <shikemeng@huaweicloud.com>,
        Mel Gorman <mgorman@techsingularity.net>,
        Rohan Puri <rohan.puri15@gmail.com>,
        Mcgrof Chamberlain <mcgrof@kernel.org>,
        Adam Manzanares <a.manzanares@samsung.com>,
        "\"Vishal Moola (Oracle)\"" <vishal.moola@gmail.com>
Subject: Re: [PATCH v1 1/4] mm/compaction: enable compacting >0 order folios.
Date:   Mon, 20 Nov 2023 09:05:59 -0500
Message-ID: <300AECEE-2B86-4124-8571-E74E97988C50@nvidia.com>
In-Reply-To: <f2111ca6-4be7-4125-af3f-ffab47378bf1@linux.alibaba.com>
References: <20231113170157.280181-1-zi.yan@sent.com>
 <20231113170157.280181-2-zi.yan@sent.com>
 <f2111ca6-4be7-4125-af3f-ffab47378bf1@linux.alibaba.com>
Content-Type: multipart/signed;
 boundary="=_MailMate_9D869630-A5F2-4105-89F7-20631DE21D43_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XLsrDgAjNPx1B1cZvFPnbOXgxCi9yqCeBOLWw8HBEwXiKD5hdAbr2CSFPx2F?=
 =?us-ascii?Q?cAZI5ALN2+csUqM8JQx8W3umJmTRiIcfm6/jXeIBrIiHYXNhQ1Fvlze+e4Qz?=
 =?us-ascii?Q?J9iTmk8SrRblDryjcGbS23AfXJhdBWzAph9u/0np1vmMQK2pURJHR9wV8Ghw?=
 =?us-ascii?Q?AvTnPvmb4P2BPS9E06BRpWugM12fKiILlTnZ0EMv9GjSzTrQ8IsaImQLonOC?=
 =?us-ascii?Q?uW9EaG4KBr+H3XHoye9uwP2SyGHKpD/dcwQ0mitVRLXRXIJg4LWho3ZtYSwh?=
 =?us-ascii?Q?WoHGJjf6AAFZFh74LsCRH/iL2n+CaT/iXBhKIn5o9TOQsI7dfWpUQquwwl78?=
 =?us-ascii?Q?51mctHKtydIcv2ftlLMlocju5J40KIdU7ehoHN1iJhVcef2nFN+E7EBlNPwR?=
 =?us-ascii?Q?EPnSFPo+1WgcJG+in1dg+yEKhYbWpt4vMh4baJ34ELPbh7fQilsUj6qp82P2?=
 =?us-ascii?Q?wUWyFInv28oQSCO8HOMTDTjza4kHY2XnGdFXywoCYq8XJEDiH8mVY3L6z+u4?=
 =?us-ascii?Q?1SwEnW0B5nJTnMmMwAxFXOqvEkaYMgrRSpLcFZDCr9x5XXEOVfiKUl4kdGX9?=
 =?us-ascii?Q?VFRx2wj+r3/onuevP3HYcXVN7YdfPA+6cWODlSCthC8wj2hp/LgViVlOdo9G?=
 =?us-ascii?Q?3A89SDiuMVgB6m6vDk9ebdtslUiLd2Sso1Z291bEWJRikLxxZmnFKjAMuBm5?=
 =?us-ascii?Q?WnzDJroIj/LNRsalsUsJD9sT9ZYfhNRM9P4mgYlAktBAuR4WaB3BkgNxcWts?=
 =?us-ascii?Q?Eaj1BZYxdUiQfJetsVWutwzyFQmITbV/+vDxq1WnAiEefGkgTeiBalC64hf+?=
 =?us-ascii?Q?e9hF5hWF+01fuYVSwGl+CF9uf0LrXsPHdTDBbE8eYDA1y9Z2QrajcoKUXA4q?=
 =?us-ascii?Q?04OKtmzxX4n5WXZhB9/cHWB2qTB0uaBz1oHCk/itZ2vn4lP8yYXJ6J6oJPJx?=
 =?us-ascii?Q?XPpqXE2evavczxXvFofpYPNfRYHG9GSYLj3MTMh10EjMlKyZzfuF1rsfXHJF?=
 =?us-ascii?Q?7exdcSI+uqKSN094ShK//99mluJFEIXI/UMgp4kS5oJysZjrdGRWh6OZusLS?=
 =?us-ascii?Q?wLa8ihvhh40+rnssjO03BGEhoOS9qvH1T3ojN5D/3qzlO3wyd+HFQ8BBNDcT?=
 =?us-ascii?Q?aCBU0dXrd8Pbw9otwdwFwNeb5tPVOim2qqXEhk5aIJelffR11CbvRFuzyJGI?=
 =?us-ascii?Q?0PDZMk/L5aMvlf3jsYH130ImikW51sTlGCWnTIa/yuPPbMt+aN6VtSAn1il1?=
 =?us-ascii?Q?dLrLGdEFHlEDBe9Rn0VnpOUuzGeqRuiwICnm16VGWYu0MwICMwqnh5UYWkvv?=
 =?us-ascii?Q?0a5uhG84W+kYMSqKyqW/wsfU1sLTea2091E5+eLhuTBkmuSeF5ZJkrrr6q4p?=
 =?us-ascii?Q?wdVCipRjJINKh9/giUwAJNlhVeUxc3XYPJ6BRsGMJNDq28IY0yjLHGiSY1n3?=
 =?us-ascii?Q?M7By2aAcu92Cnkm+FNk53ojCL3wV3diBYa0Ra9GUsOQRlg26j2B1dsJCV4ZR?=
 =?us-ascii?Q?SV8JdtK5qlORadUJLTTWtwjZV/ST81qupXiBx2IvMp4DP7vg3PG1St+Xmj2B?=
 =?us-ascii?Q?CnLCZVIv1E+Ypb7Pfh4=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c9715b2e-7937-44ab-8283-08dbe9d1d3de
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2023 14:06:01.7606
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Qe5hx1yvZiqEpKYLpiFjAtVqX0EXnMsoiOlfi5QMWhi24rE4N3NkLC1pakN1fatI
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB8138
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 20 Nov 2023 06:06:30 -0800 (PST)

--=_MailMate_9D869630-A5F2-4105-89F7-20631DE21D43_=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

>> @@ -1144,17 +1166,18 @@ isolate_migratepages_block(struct compact_cont=
rol *cc, unsigned long low_pfn,
>>   					goto isolate_abort;
>>   				}
>>   			}
>> +		}
>>  -			/*
>> -			 * folio become large since the non-locked check,
>> -			 * and it's on LRU.
>> -			 */
>> -			if (unlikely(folio_test_large(folio) && !cc->alloc_contig)) {
>> -				low_pfn +=3D folio_nr_pages(folio) - 1;
>> -				nr_scanned +=3D folio_nr_pages(folio) - 1;
>> -				folio_set_lru(folio);
>> -				goto isolate_fail_put;
>> -			}
>> +		/*
>> +		 * Check LRU folio order under the lock
>> +		 */
>> +		if (unlikely(skip_isolation_on_order(folio_order(folio),
>> +						     cc->order) &&
>> +			     !cc->alloc_contig)) {
>> +			low_pfn +=3D folio_nr_pages(folio) - 1;
>> +			nr_scanned +=3D folio_nr_pages(folio) - 1;
>> +			folio_set_lru(folio);
>> +			goto isolate_fail_put;
>>   		}
>
> Why was this part moved out of the 'if (lruvec !=3D locked)' block? If =
we hold the lru lock, then we do not need to check again, right?

Probably I messed this up during rebase. Thank you for pointing this out.=

Will fix it in the next version.

--
Best Regards,
Yan, Zi

--=_MailMate_9D869630-A5F2-4105-89F7-20631DE21D43_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmVbZ8cPHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUlVAQAIuX29TF/X30FxrAuTCtXBdv5V5VaUW6WpbI
/isXd5guHRFYCCAK1LOwoJI1ClarvQ3tM8mClfzSx1vzkvjp0V+T+SATuWWnNZTD
6iHovlyjp/wHGkHT4Llwi50b+Nf4P2W/HHlmQGGZrwAm9nvVDrlUIps/AHYx1kf4
bkSxYQj521o4Y2zK5vjVaGBhI3EteK4dPFdN+s1arnqDnJoaVqghMRbAF0fSnDQm
7Wv5Cbj2Le/pzsSDRu3phzLqoDq2fOdyRmU6UE+rrpYCgIoOEkI/HBErlAs+WyGu
QUk2ceSjeD37Vkeg3KoRW2ETZSIxIc7fN2X1laiFaY6/w2AlRXgUO+kxQR3FUKCc
AxasHGvqcnArOUoVkZCcLRkZJo3koIER2K8ln4oUNPKVu+UA+gu3CZS4Genq1WtR
mM5HBtTIVgpeE7jEcEfkFvxqZufL/fcOdngZdNCuFmH7cO/mOoGXNbw2TXkk6r/8
k3SZ3bZIRX8Mdrg1D2SarGD7hMjYUaRZ3uMEcBJkW5jSY3ES1h/7fv+EiObnwuog
NucEyoFr3Yyyb7bIG80pl7S0au2reP0RIYL1E9QHH6GmBudNneZYwMz9D+YfZrMO
Si6EmlvI+kLuffuv5VpznFS0SdVx6nVRmVK896D66vYoMEmXZyzAgkAE0xiwOsYs
dTKbjHWz
=grbg
-----END PGP SIGNATURE-----

--=_MailMate_9D869630-A5F2-4105-89F7-20631DE21D43_=--