Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Mon, 20 Nov 2023 10:29:28 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
Cc:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        alex.williamson@redhat.com, yishaih@nvidia.com,
        kevin.tian@intel.com, linuxarm@huawei.com, liulongfang@huawei.com
Subject: Re: [PATCH] hisi_acc_vfio_pci: Update migration data pointer
 correctly on saving/resume
Message-ID: <20231120142928.GC6083@nvidia.com>
References: <20231120091406.780-1-shameerali.kolothum.thodi@huawei.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231120091406.780-1-shameerali.kolothum.thodi@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xZfk56657jGwqquCaFd/cg7zG7bDT6KpGM5ZSTccH9BbmS7t2JyVmEOZpBRs?=
 =?us-ascii?Q?kkaslQ9gcyv5q1CqhUBDSg3apHsTABcVomOgX+YGtldNs6VCgV24kq/bUTDJ?=
 =?us-ascii?Q?U1BEUhJZgjeAI8grDlq7ghCiqoOWIVpy1F2ZTJW3sJuibShFSovU6jNRvyp6?=
 =?us-ascii?Q?YWlZZ0VZVi5f3267UkD3X9PmN9B+zGlKntP3B24n3OCDm57QqbVgfGyBHKhO?=
 =?us-ascii?Q?nudUriagPxEGJEmyNpB8I4YFNbi7K8Vqa814QGrTZspS6QIpbZorJ3Z+J674?=
 =?us-ascii?Q?78eRUTSJ9/zZr6F1qCO/8aeETNsbn9ceHTZGbLgJMvZ/ppd3ClsxUMXsvAnO?=
 =?us-ascii?Q?1OZmOyd76UHrCQQUxsGMDPrSSuR64BNygY8QSZkTfOWuKl3Rezbr9Bp3HJKt?=
 =?us-ascii?Q?VbsrDLlftpp2WTI3aNFllyLHawG/BrsIFZwN5nLBuA5y9ej4WoBKXP93bqUZ?=
 =?us-ascii?Q?t5r72MGkpXUUw/56sjZtgNRAQkNSly9h/jfw60/CzMjWhtjUGfEn6i8EA3Nl?=
 =?us-ascii?Q?KMtc1tKOX7AgCwoSX/bwSCYhWUVsTGvhIEEvU68QxJhcuITlpuK8lPh25kVm?=
 =?us-ascii?Q?n6ADZLni4bOkwRYI5Af0zvjeRqLidjACBLMBNbCMUFo1HmqrAxN/KMUgxEMw?=
 =?us-ascii?Q?TE198KQk61owGw2+m41Wi0Al/D9P9/T4pHBzcgb84Y0UyJ9ZOLQjbMRTr31b?=
 =?us-ascii?Q?zcyI2BYYB7dNJl8c57KVrwFdsBzUedAwiPMNc6SRcwABylxa/ogh0Wxqb0wr?=
 =?us-ascii?Q?ju/deidxPofzyPiK6yC4XUgNZXR/a8VfGr4pdVP+1n8XBgD832kn0Po1DbLD?=
 =?us-ascii?Q?D42QMKf+nqDI1KGKVjtRNk3b8ayrLP/bOHBuN0s+vtEl70Jj3cxVBhjvefQ2?=
 =?us-ascii?Q?eU8mm/MHc5ShQSV0z30QPITSwJcI6HcwhJnAsN1gGpPFxlwhag0yb5FJL+TE?=
 =?us-ascii?Q?n5kODW9QqeeRFSOrXi2c0N9dbL+KKshNP6DwST0IM++quYtAoW/JarcKQb2e?=
 =?us-ascii?Q?j0oJbIRhR7GD6BsehTaP8fGVxInS6DVG0RmhieBH3R6CoDmucv1zbLzh4Eoy?=
 =?us-ascii?Q?XayeQupqRYzWRX9oKnaCz3wxmxtzCLUrIU1bqg0zMEkw6F4A9NSZvsbTScWJ?=
 =?us-ascii?Q?GDU+9faYV3RHcQ952BIZdzqXYH1EzgFcw05xGNHkgtnpqP6u1EvLGXox/Vq/?=
 =?us-ascii?Q?qfrBsGxgijYWiNK5mwFfFBG3gvvav5eIH25/WAuIlDys8lE3rWqPSfabbqom?=
 =?us-ascii?Q?aQjABpiL2PoKCjN6PXkVMzgKFVrQi/lc1PDVEQsrQZGQOGUBWOwVFmlEYo0P?=
 =?us-ascii?Q?cjq+2rB8S7Pm4M0hOY5A5Vg0iFPHW3Ci0pUQJPuEI9i5C1Ow5btTE//odBVG?=
 =?us-ascii?Q?k/TgBGhcLpBDeyIY6YxutjamWrFUzShkNRHKTnhjUn8HP1UQLCSADFqnlMZ0?=
 =?us-ascii?Q?S37e5CA3CXrorR8RMdgtW/N/KYOL9YC/uslshZsw1eWq8WYf/DoPm6dOUnWY?=
 =?us-ascii?Q?mmRbLQriieM6OmMLDFoMveN8k/1SOTYSkaq6WP693OJvL0KoC6JDm6T2U5Zg?=
 =?us-ascii?Q?tr/MjIsbERxpkS6AvEtOR4VvpMwNrkBSQvosI0Zi?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c6848490-6953-44f7-ae52-08dbe9d51bfe
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2023 14:29:31.1138
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SUDzEokSZ0+obN3Cm/rmZ50fS94M1m9c6NO0bDuhT3ijAvB4VPqWbbQ6CeMMgqte
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7307
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 20 Nov 2023 06:29:41 -0800 (PST)

On Mon, Nov 20, 2023 at 09:14:06AM +0000, Shameer Kolothum wrote:
> When the optional PRE_COPY support was added to speed up the device
> compatibility check, it failed to update the saving/resuming data
> pointers based on the fd offset. This results in migration data
> corruption and when the device gets started on the destination the
> following error is reported in some cases,
> 
> [  478.907684] arm-smmu-v3 arm-smmu-v3.2.auto: event 0x10 received:
> [  478.913691] arm-smmu-v3 arm-smmu-v3.2.auto:  0x0000310200000010
> [  478.919603] arm-smmu-v3 arm-smmu-v3.2.auto:  0x000002088000007f
> [  478.925515] arm-smmu-v3 arm-smmu-v3.2.auto:  0x0000000000000000
> [  478.931425] arm-smmu-v3 arm-smmu-v3.2.auto:  0x0000000000000000
> [  478.947552] hisi_zip 0000:31:00.0: qm_axi_rresp [error status=0x1] found
> [  478.955930] hisi_zip 0000:31:00.0: qm_db_timeout [error status=0x400] found
> [  478.955944] hisi_zip 0000:31:00.0: qm sq doorbell timeout in function 2
> 
> Fixes: d9a871e4a143 ("hisi_acc_vfio_pci: Introduce support for PRE_COPY state transitions")
> Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
> ---
>  drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason