Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
From:   Diederik de Haas <didi.debian@cknow.org>
To:     Heiko Stuebner <heiko@sntech.de>, Sandy Huang <hjc@rock-chips.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Tomasz Figa <tfiga@chromium.org>,
        linux-rockchip@lists.infradead.org, Jonas Karlman <jonas@kwiboo.se>
Cc:     Christopher Obbard <chris.obbard@collabora.com>,
        Andy Yan <andy.yan@rock-chips.com>,
        dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
        Jonas Karlman <jonas@kwiboo.se>
Subject: Re: [PATCH v2] drm/rockchip: vop: Fix color for RGB888/BGR888 format on VOP
 full
Date:   Mon, 20 Nov 2023 15:31:59 +0100
Message-ID: <4726930.fbnEVBQaF0@bagend>
Organization: Connecting Knowledge
In-Reply-To: <20231026191500.2994225-1-jonas@kwiboo.se>
References: <20231026191500.2994225-1-jonas@kwiboo.se>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart2134285.SbVt0S7CNQ";
 micalg="pgp-sha256"; protocol="application/pgp-signature"
Precedence: bulk

--nextPart2134285.SbVt0S7CNQ
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"; protected-headers="v1"
X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers.
From: Diederik de Haas <didi.debian@cknow.org>
Date: Mon, 20 Nov 2023 15:31:59 +0100
Message-ID: <4726930.fbnEVBQaF0@bagend>
Organization: Connecting Knowledge
In-Reply-To: <20231026191500.2994225-1-jonas@kwiboo.se>
References: <20231026191500.2994225-1-jonas@kwiboo.se>
MIME-Version: 1.0

On Thursday, 26 October 2023 21:14:58 CET Jonas Karlman wrote:
> Use of DRM_FORMAT_RGB888 and DRM_FORMAT_BGR888 on e.g. RK3288, RK3328
> and RK3399 result in wrong colors being displayed.
> 
> The issue can be observed using modetest:
> 
>   modetest -s <connector_id>@<crtc_id>:1920x1080-60@RG24
>   modetest -s <connector_id>@<crtc_id>:1920x1080-60@BG24

On my Rock64 (rk3328) I was able to see the problem without this patch and see 
it displaying correctly with it, so 

Tested-by: Diederik de Haas <didi.debian@cknow.org>
--nextPart2134285.SbVt0S7CNQ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZVtt3wAKCRDXblvOeH7b
bh3QAP9r8UfZ3jyDD/yp2jWUOlNzKz65zugAk67eVGxIULqbyAEAmtAgGSCuHdAN
t0RCnpEig29n4OGCexugcrRCnSp09wE=
=Aix3
-----END PGP SIGNATURE-----

--nextPart2134285.SbVt0S7CNQ--