Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp2271285rdb; Mon, 20 Nov 2023 06:51:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IGB0Ti09CRZ7QHOiw52npERc14JVtI62+7MRFNdHn4kk+G30pdTvFDuAehd3UYiCjSIjda5 X-Received: by 2002:a05:6808:1241:b0:3b2:d9d8:4039 with SMTP id o1-20020a056808124100b003b2d9d84039mr10391628oiv.24.1700491878784; Mon, 20 Nov 2023 06:51:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700491878; cv=none; d=google.com; s=arc-20160816; b=vxfU4/YXAszwuciOsAb5TswoS71/MCw2OHKyQM/q+lAhf0MS3isWlK5+p9dgJ94/Pn jb4DvJx7NamqfqLXOVSIYxSHaT64EnpoGA6cdLrVsfBa8u4Z7HaBw82lkZ3Y7AIyslP8 MhWNiJKmuHQnhbR7K3N02qT5fB2ZoxVyxvMjV7Rx+qTMIbXFzNxReDa7Im5+88nZobjQ cRy45UdGkYqZZv0UMG5gGjAyjIRYSdimhnwKY5ZmK6h/WjRjML80os0IiB3/XOOl8f9u sfJOXkO5cZXM/l9O3dcVRPUyrBFwTdYupPu1LgDIb5rqbLtBuWyIFFri9kt3csr9XiS/ lKVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=tJJwbkqvfCRGn7qw4NUfbsptbvx8KM0jIDYK6bPqbHI=; fh=/DmnEBnDKnsTEIthRH5Xt8r02RfggIJ5Wa+1F9OMYEs=; b=DzR/LrGM3lmEInXxLCR07LCFWRHOiB8FJXwFFivhQxuNH7w1s9+zfSpWoijfONrAJq Sn8ZlGnmN3/qrNJbkYdarZsA91j1IuM2qc4pWiqQoNufisB4jRCIzLHb9GIwXPuXoGzQ 6NF3vN8wk/gVcoOv1jZrr/GNnAo8PW2l/cBi9dW7jlPuQuUbVui/tJv3Px/RwRhoRKr2 dQcEDBSBVKMbRcvZR5kWjXHeD6D7mJt9LGAq+7IUE8vkXCJFIfUTxJ8yrvvi+Es+Oo7L RuOQee9Yz6/O3YAEd7dXoWTISrDcmGlCtxCCgGNBKDNKemDseA4NzEMah7Pd2s5+Stif bhLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EJkBVUr2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id e16-20020a635450000000b005bdfda8e044si7884524pgm.775.2023.11.20.06.51.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 06:51:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=EJkBVUr2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 9D6F780530D6; Mon, 20 Nov 2023 06:51:00 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233886AbjKTOtu (ORCPT + 99 others); Mon, 20 Nov 2023 09:49:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233809AbjKTOtd (ORCPT ); Mon, 20 Nov 2023 09:49:33 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0937A3595 for ; Mon, 20 Nov 2023 06:48:01 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-32fe1a29010so2858270f8f.0 for ; Mon, 20 Nov 2023 06:48:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700491680; x=1701096480; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tJJwbkqvfCRGn7qw4NUfbsptbvx8KM0jIDYK6bPqbHI=; b=EJkBVUr2+c3RAcw3VxduyTHIuIf1REIdnsgjfdk7u9UZ0PWKofiZsx2aypG+vLYMKC mLx39ZH3p7Q+WkVjQZ0n2kA7JQFaKv68JvR9/ceABCzsIQa8qWEdukoyXdBtonlrinnx MZTsPFhG77igmZLOI9Og1zd7SblfbOfPoSVuBf2SQX33rfveXiw9jX9AmEnr77X6Inb8 oEhBihbNzSa2G2sZcXLFs3zqC3qeTRvWT2onn9mVFz3Kbi7JYtcFD3PyqgS5RTt7V73d hiPH1P617/9ILHoet9GDWOd9WjajxZvlpq63l7lx/UtSy1bSUm+LpTcAfTFHlIZEZFJJ l06Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700491680; x=1701096480; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tJJwbkqvfCRGn7qw4NUfbsptbvx8KM0jIDYK6bPqbHI=; b=b8IbvUZ3lDPkA7hiT9AiYDbLCaYWiSyCXtkjC4LvdXrM/aW1PntmPOPHynqtl6Hfcy sTWD/s6LCxPUoWb8lRSbqg8o6EU634dx326MJ2F4QMLqhxu09DI6bW5RVKivwG8NboEX tmTSmPGBtNdL27eqvT3iQBTld3BU+aCvi6sp7K6wwUfmqURJ/X6/WmqE8LIrrGfdSGZb 9gXn8sUiTW2SUpCk62FZyryVb6lgWDR7+N4iaGxNqED8WdIGLEbX+df5xPv83w8oGYTG 5GNih6lw6Svc2GL+JW99Swwm6BFmmK6eD8VdnECxggz4rrbnIzQHe7dtgvr4lyeGk52t fBrw== X-Gm-Message-State: AOJu0YwOpugHyvHvJFH5+BBFud4DH2cDkTFOOdoQX2EU3Q0ZATX1tyDI 3v+JBUdKIVYfp4sqnbwNiQA22w== X-Received: by 2002:a05:6000:2c7:b0:32f:7cfd:4522 with SMTP id o7-20020a05600002c700b0032f7cfd4522mr4655078wry.70.1700491680256; Mon, 20 Nov 2023 06:48:00 -0800 (PST) Received: from [192.168.1.7] ([79.79.179.141]) by smtp.gmail.com with ESMTPSA id j3-20020a056000124300b0032f7e832cabsm11385126wrx.90.2023.11.20.06.47.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Nov 2023 06:47:59 -0800 (PST) Message-ID: <70402702-84d3-4577-9fd2-9e87add4283b@linaro.org> Date: Mon, 20 Nov 2023 14:47:58 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/3] arm64: dts: qcom: Add base qcs6490-rb3gen2 board dts Content-Language: en-US To: Komal Bajaj , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Naina Mehta References: <20231120134754.9526-1-quic_kbajaj@quicinc.com> <20231120134754.9526-4-quic_kbajaj@quicinc.com> From: Caleb Connolly In-Reply-To: <20231120134754.9526-4-quic_kbajaj@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 20 Nov 2023 06:51:01 -0800 (PST) X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email On 20/11/2023 13:47, Komal Bajaj wrote: > Add DTS for Qualcomm qcs6490-rb3gen2 board which uses > QCS6490 SoC. This adds debug uart and usb support along > with regulators found on this board. Hi, I understand there was a lot of previous discussion around these two boards, sorry to be bringing it up again here, but I have a few more questions. How similar are these two boards in terms of design? If they're derived from the same reference schematic then I think this is a good justification to de-duplicate the common DTS parts. Dropping them in a diff tool [1] it seems as though the only changes are the modem reserved memory for the IDP board, some minor regulator changes, and the sdcard on the IDP board being enabled. However it's important to differentiate between these just, being the same, vs them being based on the same reference design. I left some comments on the parts that differ between the boards below, but basically my question is: do these boards share enough of the same *design* that it would make sense to have a "qcm6490-iot.dtsi" file with the common reserved memory and regulators? The IDP and rb3 boards would then inherit from there, avoiding a lot of duplication and weirdness where some boards have certain regulator properties that others don't with it being hard to tell if this is intentional or not (this is the case with a lot of the existing upstream devices). On a related note, should we further split the rb3 board into a qcs6490-whatever-som.dtsi file which may define the SoM specific parts? This would undoubtebly make it easier for other boards based on the same SoM to be bought up and kept up to date. [1]: https://quickdiff.net/?unique_id=630F6851-C750-839E-1651-4CA6D997A74D [...] > diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > new file mode 100644 > index 000000000000..f023dcf768f1 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts > @@ -0,0 +1,410 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved. > + */ > + [...] > + > + vreg_l7b_2p952: ldo7 { The IDP board defined voltages here for the sdcard, does the rb3 board have an sdcard slot (if so which regulator does it use)? Is there a reason not to define the same voltage range for this board? > + regulator-allow-set-load; This property is set for rb3 but not for the idp board, even though this regulator is unused, should this be set? > + regulator-allowed-modes = ; > + regulator-initial-mode = ; > + }; > + [...] > + > + vreg_l9b_1p2: ldo9 { Same question as above > + regulator-allow-set-load; Same question > + regulator-allowed-modes = ; > + regulator-initial-mode = ; > + }; > + [...] > + vreg_l19b_1p8: ldo19 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <2000000>; > + regulator-initial-mode = ; The IDP board has the regulator-allow-set-load property here, as well as regulator-allowed-modes. This regulator is used for the sdcard on that board. Is it used for anything on rb3? Can these properties be the same? > + }; > + }; > + Thanks and regards, -- // Caleb (they/them)